hg: jdk8/tl/jaxws: Added tag jdk8-b33 for changeset ea80b2388dce

2012-04-11 Thread lana . steuck
Changeset: b3cad5619239 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b3cad5619239 Added tag jdk8-b33 for changeset ea80b2388dce ! .hgtags

hg: jdk8/tl/jaxp: Added tag jdk8-b33 for changeset 9bcab2b8b8ea

2012-04-11 Thread lana . steuck
Changeset: 19d53d500474 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/19d53d500474 Added tag jdk8-b33 for changeset 9bcab2b8b8ea ! .hgtags

hg: jdk8/tl/langtools: 3 new changesets

2012-04-11 Thread lana . steuck
Changeset: e4241f09e2b6 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e4241f09e2b6 Added tag jdk8-b33 for changeset 46831c72b7f6 ! .hgtags Changeset: 517f0789bd4e Author:lana Date: 2012-04-09 21:58 -0700 URL:

hg: jdk8/tl: 2 new changesets

2012-04-11 Thread lana . steuck
Changeset: 06ef0b4daa4c Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/06ef0b4daa4c Added tag jdk8-b33 for changeset 42f275168fa5 ! .hgtags Changeset: 3b70add6ae45 Author:lana Date: 2012-04-09 21:55 -0700 URL:

hg: jdk8/tl/jdk: 17 new changesets

2012-04-11 Thread lana . steuck
Changeset: 93ca9cbc8940 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93ca9cbc8940 Added tag jdk8-b33 for changeset 78cea258caab ! .hgtags Changeset: 100b6c2f75ba Author:rupashka Date: 2012-03-22 17:10 +0200 URL:

core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-11 Thread Deven You
Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. This issue is that the sun.management.Agent.loadManagementProperties() will invoke properties.putAll which will throw ConcurrentModifcationException if there are other

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-11 Thread Deven You
On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or rmic --iiop) invokes toString, maybe this is

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-11 Thread Staffan Larsen
Thank you all for your comments! New webrev here: http://cr.openjdk.java.net/~sla/7147848/webrev.01/ Changes: - Fixed Dmitry's comments - Updated TestTotalSwap.sh for Darwin (thanks Mandy) I have verified the values manually by running a Java program (see attachment) and comparing to top and

hg: jdk8/tl/langtools: 7154127: Inference cleanup: remove bound check analysis from visitors in Types.java

2012-04-11 Thread maurizio . cimadamore
Changeset: 6f0ed5a89c25 Author:mcimadamore Date: 2012-04-11 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6f0ed5a89c25 7154127: Inference cleanup: remove bound check analysis from visitors in Types.java Summary: Remove bound checking rules from recursive

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-11 Thread Dmitry Samersoff
Staffan, MacosxOperatingSystem.c Probably something went wrong with webrev: 48 if (kr != KERN_SUCCESS) { 49 return 0; 50 } 133 if (gettimeofday(now, NULL)) { 134return -1; 135 } -Dmitry On 2012-04-11 11:52, Staffan Larsen wrote: Thank you all for

Generics Reification Was Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-11 Thread Rémi Forax
On 04/07/2012 02:35 AM, Stuart Marks wrote: Hi Kurchi, I think we've converged on the code changes. Please prepare and post another webrev for a final cross-check before pushing. What follows is I think merely residual disagreement over the philosophy of how to handle generic casts vs

Integer.parseInt

2012-04-11 Thread Benedict Elliott Smith
Hi, Looking at the source code, it doesn't appear as though there is any reason to require the input be a String - only length() and charAt() are called, which are both declared by CharSequence. Is there a reason I can't fathom, or was it an oversight? It would be nice to widen the type for this

Re: Integer.parseInt

2012-04-11 Thread Benedict Elliott Smith
Sounds like a perfectly good reason! - and also that it should be a relatively safe change to implement. Any volunteers? I'd be happy to, but I expect the overhead for having a non-contributor do it would exceed the actual work by several orders of magnitude. On 11 April 2012 15:45, Rémi Forax

Re: New reviewers: 7160496 : Rename JDK8 JAXP source directory

2012-04-11 Thread Kelly O'Hair
Looks fine to me. -kto On Apr 10, 2012, at 8:39 PM, Joe Wang wrote: After removing the jaxp source drop bundle process, refer to 7150324, the source structure needs to be changed to be consistent with that of jdk7. I will rename jdk8/jaxp/src/share/classes to jdk8/jaxp/src before updating

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-11 Thread Sean Chou
Hi hotspot guys, Would any one like to take a look at this? I'm trying to fix a potential race in ZIP_Open, it is found classLoader.cpp uses this function. So a webrev for hotspot is made as well, but I need a sponsor from hotspot as suggested by Alan Bateman. The start of this thread is

Re: RFR 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with Address already in use

2012-04-11 Thread Rémi Forax
On 04/11/2012 08:06 PM, Jim Gish wrote: Hi, Please review the following Description: The current code uses the fixed port of 2 and the test fails if that port is in use. The patch creates the socket on any open port using new ServerSocket(0) and then determines the port in use with

Re: RFR 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with Address already in use

2012-04-11 Thread Alan Bateman
On 11/04/2012 19:06, Jim Gish wrote: Hi, Please review the following Description: The current code uses the fixed port of 2 and the test fails if that port is in use. The patch creates the socket on any open port using new ServerSocket(0) and then determines the port in use with

Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-11 Thread Mike Duigou
This thread has gone on long enough I've lost track of the reasoning behind some of the choices. Specifically, I'm wondering why Entry?,?[] is preferred over EntryK,V[] for HashMap and Hashtable. Understandably ?,? is needed to the array creation but the technique used by WeakHashMap would

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-11 Thread Alan Bateman
On 11/04/2012 15:58, Sean Chou wrote: Hi hotspot guys, Would any one like to take a look at this? I'm trying to fix a potential race in ZIP_Open, it is found classLoader.cpp uses this function. So a webrev for hotspot is made as well, but I need a sponsor from hotspot as suggested by

Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-11 Thread Rémi Forax
On 04/11/2012 10:06 PM, Mike Duigou wrote: This thread has gone on long enough I've lost track of the reasoning behind some of the choices. Specifically, I'm wondering why Entry?,?[] is preferred over EntryK,V[] for HashMap and Hashtable. Understandably?,? is needed to the array creation but

Re: RFR 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with Address already in use

2012-04-11 Thread Rémi Forax
On 04/11/2012 10:02 PM, Alan Bateman wrote: On 11/04/2012 19:06, Jim Gish wrote: Hi, Please review the following Description: The current code uses the fixed port of 2 and the test fails if that port is in use. The patch creates the socket on any open port using new ServerSocket(0)

review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-04-11 Thread Rob McKenna
Hi folks, I'm hoping for some feedback on the above. Webrev: http://cr.openjdk.java.net/~robm/4244896/webrev.00/ This bug adds two abstract methods to Process.java with the intention of: 1) providing a facility to implement a destroyForcibly method. In practical terms this means provide a

hg: jdk8/tl/jdk: 7157903: JSSE client sockets are very slow

2012-04-11 Thread bradford . wetmore
Changeset: 10480cf00dcd Author:wetmore Date: 2012-04-11 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10480cf00dcd 7157903: JSSE client sockets are very slow Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/AppOutputStream.java !

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-11 Thread Mandy Chung
On 4/11/2012 12:36 AM, Deven You wrote: Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. serviceability-dev (cc'ed) is the mailing list for this patch. This issue is that the

Re: Integer.parseInt

2012-04-11 Thread Joe Darcy
On 4/11/2012 7:45 AM, Rémi Forax wrote: On 04/11/2012 04:18 PM, Benedict Elliott Smith wrote: Hi, Looking at the source code, it doesn't appear as though there is any reason to require the input be a String - only length() and charAt() are called, which are both declared by CharSequence. Is

Codereview request for 7152690: Initialization error with charset SJIS_0213 when security manager is enabled

2012-04-11 Thread Xueming Shen
Hi Please help codereview the change for #7152690 http://cr.openjdk.java.net/~sherman/7152690/webrev This is an overlook when we changed SJIS_0213 implementation in 7. The resource reading obviously needs to be wrapped in doPrivileged block. Thanks! -Sherman

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-11 Thread Sean Chou
Hi Alan, Many thanks. I updated the patch, ZIP_Open frees the error message and set Zip file open error. The new webrev is : http://cr.openjdk.java.net/~zhouyx/7159982/webrev.01/ Please take a look once more. On Thu, Apr 12, 2012 at 4:09 AM, Alan Bateman