Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-13 Thread Mike Duigou
Looks good for commit. Just a few notes - The inconsistent use of by WeakHashMap and by the other Hash Map classes for their tables is a bit annoying but not a new problem. We should either make all of the maps use (my preference) or all use . There were lots of cases of introduced and tha

Code Review Request - Bug #6948101 & 7142596: RMI JPRT tests are failing

2012-04-13 Thread Darryl Mocek
Hello core-libs. Please review this webrev to fix Bug #6948101 and #7142596. This commit fixes concurrency issues with the RMI tests. - Added TestLibrary.getUnusedRandomPort method. This attempts to return a random port number, which is unused, between the port ranges 1024 and 64000 (inclus

Re: [7u6] RFR : 7161105 : unused classes in jdk7u repository

2012-04-13 Thread Joe Wang
I'd thank them for the services over the last 8 years :) On 4/13/2012 2:08 PM, Lance Andersen - Oracle wrote: looks good joe, say goodbye to them :-) On Apr 13, 2012, at 1:17 PM, Joe Wang wrote: In the patch for 7053556, the ObjectFactory/SecuritySupport classes that were duplicated in many

Re: [7u6] RFR : 7161105 : unused classes in jdk7u repository

2012-04-13 Thread Lance Andersen - Oracle
looks good joe, say goodbye to them :-) On Apr 13, 2012, at 1:17 PM, Joe Wang wrote: > In the patch for 7053556, the ObjectFactory/SecuritySupport classes that were > duplicated in many packages were replaced by a unified set under > xerces/internal/utils and xalan/internal/utils (Note that th

hg: jdk8/tl/jdk: 7152169: TEST_BUG: sun/security/tools/jarsigner/ec.sh occasionally fail due to keytool error on sparc

2012-04-13 Thread vincent . x . ryan
Changeset: 7340f4a3c830 Author:vinnie Date: 2012-04-13 19:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7340f4a3c830 7152169: TEST_BUG: sun/security/tools/jarsigner/ec.sh occasionally fail due to keytool error on sparc Reviewed-by: mullan ! src/share/classes/sun/securit

[7u6] RFR : 7161105 : unused classes in jdk7u repository

2012-04-13 Thread Joe Wang
In the patch for 7053556, the ObjectFactory/SecuritySupport classes that were duplicated in many packages were replaced by a unified set under xerces/internal/utils and xalan/internal/utils (Note that those under xpath/internal/utils were old). When the jaxp 1.4.5 source bundle was dropped howe

Re: strange java 7 behavior on windows ( star arg "*")

2012-04-13 Thread daniel lutoff
Thanks Kumar, Yes it seems very similar ! I'll try the workaround (instead of "*", use "*;") Thanks Daniel Le 13/04/12 17:14, Kumar Srinivasan a écrit : Hi Daniel, It is likely you are running into this issue: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146424 Thanks Kumar Hi al

Re: Codereview request 7067045: replaceAll("\u20ac", "$"); causses java.lang.StringIndexOutOfBoundsExceptio

2012-04-13 Thread Xueming Shen
Good catch. will fix it with next regex fix. Thanks! On 4/13/2012 3:07 AM, Alan Bateman wrote: On 12/04/2012 21:09, Xueming Shen wrote: Hi Please help review the change for 7067045. The change is to throw a more meaningful IAE instead of the StringIndexoutputOfBoundsException if backslash or

Re: strange java 7 behavior on windows ( star arg "*")

2012-04-13 Thread Kumar Srinivasan
Hi Daniel, It is likely you are running into this issue: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146424 Thanks Kumar Hi all, I've notice a strange java 7 behavior on windows when a "*" is used as argument: Here is the test case, just printed out the args (pretty simple as you

hg: jdk8/tl/jdk: 2 new changesets

2012-04-13 Thread sean . mullan
Changeset: fa26ac92b29e Author:mullan Date: 2012-04-13 09:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa26ac92b29e 7152564: Improve CodeSource.matchLocation(CodeSource) performance 7155693: CodeSource.matchLocation getPort test can be improved Reviewed-by: chegar ! src

Re: Codereview request 7067045: replaceAll("\u20ac", "$"); causses java.lang.StringIndexOutOfBoundsExceptio

2012-04-13 Thread Alan Bateman
On 12/04/2012 21:09, Xueming Shen wrote: Hi Please help review the change for 7067045. The change is to throw a more meaningful IAE instead of the StringIndexoutputOfBoundsException if backslash or $ is the last character in the replacement string. (as the API indicated, the backslash and $ c

Re: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-13 Thread Charles Lee
On 04/13/2012 04:45 PM, Alan Bateman wrote: On 13/04/2012 03:21, Charles Lee wrote: On 04/12/2012 04:26 PM, Alan Bateman wrote: On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICC

Re: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-13 Thread Alan Bateman
On 13/04/2012 03:21, Charles Lee wrote: On 04/12/2012 04:26 PM, Alan Bateman wrote: On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICClassPathTest.java but I didn't see it in the

strange java 7 behavior on windows ( star arg "*")

2012-04-13 Thread daniel lutoff
Hi all, I've notice a strange java 7 behavior on windows when a "*" is used as argument: Here is the test case, just printed out the args (pretty simple as you can see): public class TestStar { public static void main(String args[]) { for (String _arg : args)