Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Stuart Marks
On 5/1/12 10:16 AM, Rémi Forax wrote: On 05/01/2012 05:50 PM, Jim Gish wrote: Should I proceed with improvements to String.join() or wait, for example, until the lambda array support is there? better to ask Brian Goetz :) Hi guys, this came back around to me internally to Oracle since I've b

Re: Code Review Request: 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE

2012-05-01 Thread David Holmes
Hi Kurchi, You should also add: @throws NullPointerException {@inheritDoc} to the method spec so that the docs re-instate the fact that it is supposed to throw NPE. As it stands I could argue that AbstractPreferences.remove has chosen not to throw NPE for a null key - leaving it up to remove

hg: jdk8/tl/jdk: 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary

2012-05-01 Thread mandy . chung
Changeset: 46e0bd218fcc Author:mchung Date: 2012-05-01 19:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e0bd218fcc 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Reviewed-by: alanb, mullan, prr ! src/macosx/classes/apple/launcher

Re: [PATCH] Use #valueOf()-methods in Unsafe-based FieldAccessors

2012-05-01 Thread Rémi Forax
On 05/01/2012 09:33 PM, Andrej Golovnin wrote: Hi all, Hi Andrej, your far from Swing :) (I remember you from the glorious appframework time) Is there some reason for not using #valueOf-methods from wrapper classes in Unsafe-based FieldAccessors in sun.reflect-package (see the attached patch

[PATCH] Use #valueOf()-methods in Unsafe-based FieldAccessors

2012-05-01 Thread Andrej Golovnin
Hi all, Is there some reason for not using #valueOf-methods from wrapper classes in Unsafe-based FieldAccessors in sun.reflect-package (see the attached patch)? The main motivation for this patch is to reduce memory consumption in applications which make heavy use of reflection API (e.g. apps wh

Code Review Request: 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE

2012-05-01 Thread Kurchi Hazra
Hi, This is a simple fix to enable AbstractPreferences.remove() to check for a null argument and throw a NullPointerException if required. I have also modified test/java/util/prefs/RemoveNullKeyCheck.java to cover this case. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7165118

hg: jdk8/tl/jdk: 2 new changesets

2012-05-01 Thread lana . steuck
Changeset: 9e82ac15ab80 Author:katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e82ac15ab80 Added tag jdk8-b36 for changeset 45da9cb055ee ! .hgtags Changeset: 6c9c3d7ce9e2 Author:lana Date: 2012-05-01 11:30 -0700 URL: http://hg.

hg: jdk8/tl/langtools: Added tag jdk8-b36 for changeset 94bbaa67686f

2012-05-01 Thread lana . steuck
Changeset: 5891b38985e8 Author:katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5891b38985e8 Added tag jdk8-b36 for changeset 94bbaa67686f ! .hgtags

hg: jdk8/tl/hotspot: Added tag jdk8-b36 for changeset 50b4400ca1ec

2012-05-01 Thread lana . steuck
Changeset: bfcf92bfefb8 Author:katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfcf92bfefb8 Added tag jdk8-b36 for changeset 50b4400ca1ec ! .hgtags

hg: jdk8/tl/jaxp: Added tag jdk8-b36 for changeset cfd288fe1d3e

2012-05-01 Thread lana . steuck
Changeset: c388369cf4da Author:katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c388369cf4da Added tag jdk8-b36 for changeset cfd288fe1d3e ! .hgtags

hg: jdk8/tl/jaxws: Added tag jdk8-b36 for changeset 89b36c658e39

2012-05-01 Thread lana . steuck
Changeset: b05a948db1b6 Author:katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b05a948db1b6 Added tag jdk8-b36 for changeset 89b36c658e39 ! .hgtags

hg: jdk8/tl: Added tag jdk8-b36 for changeset 6a6ba0a07f33

2012-05-01 Thread lana . steuck
Changeset: 47aa0ddc9126 Author:katleman Date: 2012-04-26 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/47aa0ddc9126 Added tag jdk8-b36 for changeset 6a6ba0a07f33 ! .hgtags

hg: jdk8/tl/corba: 2 new changesets

2012-05-01 Thread lana . steuck
Changeset: 83fac66442cf Author:katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/83fac66442cf Added tag jdk8-b36 for changeset a5a61f259961 ! .hgtags Changeset: 4a653e435441 Author:lana Date: 2012-05-01 11:29 -0700 URL: http://h

Re: Proposed refactoring: introduce JLS7 language features to core libs

2012-05-01 Thread Stefan Reich
Hi Stuart, thank you for your reply. I sent a patch to the adopt-openjdk group that uses multi-catch for catch clauses with duplicate code blocks in the same try statement (message and patch attached). That patch covers all code in src/shared/classes. Martijn will help coordinating the effort w

Re: Codereview request for 7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H

2012-05-01 Thread Xueming Shen
Hi, Just noticed that webrev url was pointing to the blenderrev. The webrev is at http://cr.openjdk.java.net/~sherman/7014640/webrev Btw, this one has been approved by CCC. thanks, -Sherman On 04/21/2012 12:56 AM, Xueming Shen wrote: Hi Here are the webrev and blenderrev for the proposed

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Rémi Forax
On 05/01/2012 05:50 PM, Jim Gish wrote: Thanks - Should I proceed with improvements to String.join() or wait, for example, until the lambda array support is there? Jim better to ask Brian Goetz :) Rémi On 05/01/2012 07:02 AM, Rémi Forax wrote: On 04/30/2012 04:23 PM, Jim Gish wrote: T

Re: Proposed refactoring: introduce JLS7 language features to core libs

2012-05-01 Thread Martijn Verburg
Hi all, On 1 May 2012 10:33, Martijn Verburg wrote: > Hi all, > >> On 4/25/12 12:07 PM, Stefan Reich wrote: >>> >>> Hello, >>> >>> is there any interest to accept change sets based on OpenJDK 7 that update >>> the java classes in jdk/src/share/classes to use >>> >>> * multi-catch >>> * string swi

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Jim Gish
Thanks - Should I proceed with improvements to String.join() or wait, for example, until the lambda array support is there? Jim On 05/01/2012 07:02 AM, Rémi Forax wrote: On 04/30/2012 04:23 PM, Jim Gish wrote: Thanks Rémi, I'll take a look at defender methods on Iterable. As far as the pa

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Rémi Forax
On 05/01/2012 01:37 PM, Paul Sandoz wrote: On May 1, 2012, at 12:53 PM, Rémi Forax wrote: On 04/30/2012 11:03 AM, Paul Sandoz wrote: On Apr 28, 2012, at 1:01 AM, Rémi Forax wrote: Hi Jim, Yes, I've basically try to submit a patch each time I've written a method join in one of my applicati

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Paul Sandoz
On May 1, 2012, at 12:53 PM, Rémi Forax wrote: > On 04/30/2012 11:03 AM, Paul Sandoz wrote: >> On Apr 28, 2012, at 1:01 AM, Rémi Forax wrote: >> >>> Hi Jim, >>> Yes, I've basically try to submit a patch each time I've written a method >>> join >>> in one of my application :) >>> >>> The funny

RFR: 7165102 Only run assertion on Integer autoboxing cache size once

2012-05-01 Thread Rémi Forax
Here is the new webrev with the assert move after line 777 as Joe ask. http://cr.openjdk.java.net/~forax/integer_valueof2/ Alan or Joe, it let you commit it if there is no new issue. Rémi On 04/30/2012 06:09 PM, Alan Bateman wrote: On 27/04/2012 23:38, Rémi Forax wrote: : I have moved the as

Re: Remove the assert in Integer.valueOf()

2012-05-01 Thread Rémi Forax
On 05/01/2012 12:09 AM, Ulf Zibis wrote: Hi Rémi, Am 28.04.2012 00:42, schrieb Rémi Forax: While you are there: IntegerCache.cache/high/low are static final, so should be named _upper case_. Not done because the system property is also spelled in lower case. Hm, but does that justify violat

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Rémi Forax
On 04/30/2012 04:23 PM, Jim Gish wrote: Thanks Rémi, I'll take a look at defender methods on Iterable. As far as the parameter checks on String -- I had the same "Aha!" moment as soon as I got in my car to drive home on Friday. :) However, it does come down to a philosophy of style in that

hg: jdk8/tl/jdk: 7158688: Typo in SSLContext Spec

2012-05-01 Thread xuelei . fan
Changeset: 71fdf32fdc65 Author:xuelei Date: 2012-05-01 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71fdf32fdc65 7158688: Typo in SSLContext Spec Reviewed-by: weijun, wetmore ! src/share/classes/javax/net/ssl/SSLContext.java

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-05-01 Thread Rémi Forax
On 04/30/2012 11:03 AM, Paul Sandoz wrote: On Apr 28, 2012, at 1:01 AM, Rémi Forax wrote: Hi Jim, Yes, I've basically try to submit a patch each time I've written a method join in one of my application :) The funny think (in fact it's even not funny) is that I think that this methods should no

hg: jdk8/tl/jdk: 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11]

2012-05-01 Thread alan . bateman
Changeset: c22b2f9066dd Author:alanb Date: 2012-05-01 11:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c22b2f9066dd 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11] Reviewed-by: chegar ! src/solaris/classes/sun/nio/f

Re: Proposed refactoring: introduce JLS7 language features to core libs

2012-05-01 Thread Martijn Verburg
Hi all, > On 4/25/12 12:07 PM, Stefan Reich wrote: >> >> Hello, >> >> is there any interest to accept change sets based on OpenJDK 7 that update >> the java classes in jdk/src/share/classes to use >> >> * multi-catch >> * string switch statements as opposed to nested if statements when >> comparin