On 9/05/2012 12:53 PM, Stuart Marks wrote:
On 5/7/12 10:32 PM, David Holmes wrote:
As a general principle library code that catches IE and doesn't
rethrow it
should re-assert the interrupt state.
But this isn't library code it is a stand-alone test framework as I
understand
it. So if the framew
Changeset: abb63b7357a1
Author:luchsh
Date: 2012-05-09 11:19 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1
7165722: Invalid path in MemoryMonitor demo's README.txt
Reviewed-by: alanb, sla
! src/share/demo/management/MemoryMonitor/README.txt
On 5/7/12 10:32 PM, David Holmes wrote:
As a general principle library code that catches IE and doesn't rethrow it
should re-assert the interrupt state.
But this isn't library code it is a stand-alone test framework as I understand
it. So if the framework doesn't use interruption at all then the
Changeset: 0f63f3390ac9
Author:xuelei
Date: 2012-05-08 18:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9
7166570: JSSE certificate validation has started to fail for certificate chains
Reviewed-by: wetmore
! src/share/classes/sun/security/validator/SimpleVali
Changeset: fbf98cbd2e6b
Author:xuelei
Date: 2012-05-08 17:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbf98cbd2e6b
7167092: Need to put the return clause in the synchronized block
Summary: a regression fix for bug 7153184
Reviewed-by: wetmore
! src/share/classes/sun/se
Am 08.05.2012 23:13, schrieb David Holmes:
On 9/05/2012 1:03 AM, Ulf Zibis wrote:
Did you also noticed it in test class ?
I don't see anything wrong in the test class. Indent is 4. ??
Oops sorry, I was in wrong line.
Class ReflectUtil was just a suggestion. as it will be loaded anyway.
Lo
On 9/05/2012 1:03 AM, Ulf Zibis wrote:
Am 08.05.2012 12:30, schrieb David Holmes:
On 8/05/2012 8:22 PM, David Holmes wrote:
On 8/05/2012 8:02 PM, Ulf Zibis wrote:
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
I missed a couple of indent-2 that
Changeset: 1ece20885be4
Author:sherman
Date: 2012-05-08 11:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ece20885be4
7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its
position as 0
Summary: updated SeekableByteChannel.read() to count the bytes
Changeset: af209a223b6b
Author:sherman
Date: 2012-05-08 10:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af209a223b6b
7014640: To add a metachar \R for line ending and character classes for
vertical/horizontal ws \v \V \h \H
Summary: added propsoed constructs
Reviewed-by
Am 08.05.2012 12:30, schrieb David Holmes:
On 8/05/2012 8:22 PM, David Holmes wrote:
Hi Ulf,
On 8/05/2012 8:02 PM, Ulf Zibis wrote:
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
I missed a couple of indent-2 that should be indent-4.
A
Hi Alan, David, Vitaly,
Ok I will make these changes and push.
Thanks
Kumar
On 07/05/2012 21:21, Kumar Srinivasan wrote:
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7166955
I think the check needs to be:
if (retval < 0 || nVM != 1)
(checking if retval == JNI_OK is okay too but
On 08/05/2012 11:30, David Holmes wrote:
I was forgetting there's another major consideration here too, and that
is that this code sync's up with Doug Lea's JSR-166 CVS repository. The
changes I made are independent of the JDK used, but if I refactored
things into ReflectUtil then the code
On 8/05/2012 8:22 PM, David Holmes wrote:
Hi Ulf,
On 8/05/2012 8:02 PM, Ulf Zibis wrote:
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
I missed a couple of indent-2 that should be indent-4.
And something went awry with indentation in e
Hi Ulf,
On 8/05/2012 8:02 PM, Ulf Zibis wrote:
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
I missed a couple of indent-2 that should be indent-4.
And something went awry with indentation in ensureProtectedAccess.
Unfortunately the we
Hi all,
I'm a little bit late, but I just have seen:
(1) some indentations in the patch are broken
(2) following code snipped is repeated many times:
+ ClassLoader cl = tclass.getClassLoader();
+ ClassLoader ccl = caller.getClassLoader();
+ if ((ccl != null) && (ccl != cl) &&
+
On 07/05/2012 21:21, Kumar Srinivasan wrote:
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7166955
I think the check needs to be:
if (retval < 0 || nVM != 1)
(checking if retval == JNI_OK is okay too but amounts to the same thing).
-Alan
On 08/05/2012 04:14, David Holmes wrote:
I think it is clear that if there are no VMs then *nVMs is set to zero
and JNI_OK is returned.
I don't think it is clear and it should be made explicit in the spec.
BTW: Did you create a bug for the JNI spec work? I'll create one if you
haven't I jus
Changeset: 48513d156965
Author:dholmes
Date: 2012-05-08 02:59 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48513d156965
7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is
installed
Summary: Perform class.getField inside a doPrivileged block
Reviewed-b
18 matches
Mail list logo
