hg: jdk8/tl/jdk: 7171028: dots are missed in the datetime for Slovanian

2012-05-24 Thread littlee
Changeset: 85696e57d447 Author:youdwei Date: 2012-05-25 14:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85696e57d447 7171028: dots are missed in the datetime for Slovanian Reviewed-by: yhuang ! src/share/classes/sun/text/resources/FormatData_sl.java ! test/sun/text/reso

hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

2012-05-24 Thread littlee
Changeset: 71cf74329a9e Author:youdwei Date: 2012-05-25 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71cf74329a9e 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled Reviewed-by: okutsu ! src/windows/native/java/util/TimeZone_md.c + test/

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Vitaly Davidovich
Thanks Kris, good to know. As much as instanceof checks are usually a code smell, it sure would be nice if the interface version could be optimized somewhat (at least for shallow hierarchies). Cheers Sent from my phone On May 24, 2012 10:41 PM, "Krystal Mok" wrote: > Hi Mike, > > On Fri, May 2

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Krystal Mok
Hi Mike, On Fri, May 25, 2012 at 10:12 AM, Mike Duigou wrote: > > On May 24 2012, at 16:32 , Vitaly Davidovich wrote: > > > That's a bit odd as I thought the Klass object in the VM stored > something like 7 supers, which includes interfaces (if I'm not mistaken). > I know that instanceof checks

hg: jdk8/tl/jdk: 7117230: clean up warnings in java.text

2012-05-24 Thread stuart . marks
Changeset: e309917fb9af Author:dbhole Date: 2012-05-24 19:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af 7117230: clean up warnings in java.text Reviewed-by: jrose, smarks ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Mike Duigou
On May 24 2012, at 16:32 , Vitaly Davidovich wrote: > That's a bit odd as I thought the Klass object in the VM stored something > like 7 supers, which includes interfaces (if I'm not mistaken). I know that > instanceof checks against final classes are optimized into a simple cmp > against an

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Vitaly Davidovich
That's a bit odd as I thought the Klass object in the VM stored something like 7 supers, which includes interfaces (if I'm not mistaken). I know that instanceof checks against final classes are optimized into a simple cmp against an address, but I'm surprised that a check against an interface for

Re: Request for Review : CR#6924259: Remove String.count/String.offset

2012-05-24 Thread Mike Duigou
On May 24 2012, at 15:56 , Ulf Zibis wrote: > Am 24.05.2012 22:45, schrieb Mike Duigou: >> A patch of the changes to java.lang.String for JDK 8 are >> at. The changes for >> JDK 7 have only superficial differences (line offsets in the patch

Re: Request for Review : CR#6924259: Remove String.count/String.offset

2012-05-24 Thread Ulf Zibis
Am 24.05.2012 22:45, schrieb Mike Duigou: A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial differences (line offsets in the patch). Correct Copyright date. 157 public String(Str

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Mike Duigou
On May 23 2012, at 16:31 , David Holmes wrote: > On 24/05/2012 2:24 AM, Mike Duigou wrote: >> Hi Mike; >> >> The problem with using instanceof Hashable32 is that is much slower (often >> more than 25X) than instanceof String. It's slow enough that we won't >> reasonably consider using instance

Request for Review : CR#6924259: Remove String.count/String.offset

2012-05-24 Thread Mike Duigou
Hello all; For a long time preparations and planing have been underway to remove the offset and count fields from java.lang.String. These two fields enable multiple String instances to share the same backing character buffer. Shared character buffers were an important optimization for old bench

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-24 Thread Mike Duigou
Hello All; I have updated the webrevs for alternative hashing for String with feedback from Remi, Doug, Ulf and internal reviewers. Additional feedback is welcome. Mike [1] althashing "7" webrev : http://cr.openjdk.java.net/~mduigou/althashing7/9/webrev/ [2] althashing "8" webrev : http://c

hg: jdk8/tl/jdk: 2 new changesets

2012-05-24 Thread nils . loodin
Changeset: 5ec5588c733d Author:nloodin Date: 2012-05-24 09:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d 7143353: -Xrunhprof fails in Java 7 due to bad switch Reviewed-by: jrose, sspitsyn ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/javav

hg: jdk8/tl/jdk: 7160725: Strange or obsolete @see tags in some exception java.lang javadoc

2012-05-24 Thread alan . bateman
Changeset: a11c964d1319 Author:jgish Date: 2012-05-24 14:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a11c964d1319 7160725: Strange or obsolete @see tags in some exception java.lang javadoc Summary: update javadoc for IllegalArgumentException and NumberFormatException Re

hg: jdk8/tl/jdk: 7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events

2012-05-24 Thread alan . bateman
Changeset: 21703d431217 Author:alanb Date: 2012-05-24 10:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21703d431217 7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events Reviewed-by: chegar, coffeys ! src/solaris/classes/sun/nio/ch/De