hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-05-30 Thread mike . duigou
Changeset: 43bd5ee0205e Author:mduigou Date: 2012-05-30 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e 7126277: Alternative String hashing implementation Summary: All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap

hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String

2012-05-30 Thread mike . duigou
Changeset: 2c773daa825d Author:mduigou Date: 2012-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d 6924259: Remove offset and count fields from java.lang.String Summary: Removes the use of shared character array buffers by String along with the two fie

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Mike Duigou
On May 30 2012, at 07:05 , Ulf Zibis wrote: > Hi, > > there are still some "Yoda" style expressions in String, HashMap, maybe > more... They can be slightly surprising but aren't a bug. Nothing in the style guidelines suggests that they shouldn't be used. > there is still {@inheritDoc} in St

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Mike Duigou
On May 30 2012, at 17:59 , Rémi Forax wrote: > On 05/30/2012 06:23 PM, Mike Duigou wrote: >> On May 30 2012, at 07:38 , Rémi Forax wrote: >> >>> On 05/30/2012 01:05 AM, Mike Duigou wrote: Another round of updates for Java 7 [1] and Java 8 [2] implementations. This revision incorporate

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Rémi Forax
On 05/30/2012 06:23 PM, Mike Duigou wrote: On May 30 2012, at 07:38 , Rémi Forax wrote: On 05/30/2012 01:05 AM, Mike Duigou wrote: Another round of updates for Java 7 [1] and Java 8 [2] implementations. This revision incorporates Remi's suggestions and some feedback from Doug Lea regarding a

hg: jdk8/tl/jdk: 7168401: pack200 does not produce a compatible pack file for JDK7 classes if indy is not present

2012-05-30 Thread kumar . x . srinivasan
Changeset: 41dcfdbf8f07 Author:ksrini Date: 2012-05-29 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcfdbf8f07 7168401: pack200 does not produce a compatible pack file for JDK7 classes if indy is not present Reviewed-by: jrose ! src/share/classes/com/sun/java/util

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Mike Duigou
On May 30 2012, at 07:38 , Rémi Forax wrote: > On 05/30/2012 01:05 AM, Mike Duigou wrote: >> Another round of updates for Java 7 [1] and Java 8 [2] implementations. This >> revision incorporates Remi's suggestions and some feedback from Doug Lea >> regarding applying the per-instance seed to th

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Rémi Forax
On 05/30/2012 01:05 AM, Mike Duigou wrote: Another round of updates for Java 7 [1] and Java 8 [2] implementations. This revision incorporates Remi's suggestions and some feedback from Doug Lea regarding applying the per-instance seed to the result of String.hash32() [1] althashing "7" webrev :

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Ulf Zibis
Hi, there are still some "Yoda" style expressions in String, HashMap, maybe more... there is still {@inheritDoc} in String.hash32(), which points to nowhere, since interface Hashable32 is not implemented. -Ulf Am 30.05.2012 01:05, schrieb Mike Duigou: Another round of updates for Java 7 [1]

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Ulf Zibis
Am 29.05.2012 23:25, schrieb Mike Duigou: On May 28 2012, at 12:34 , Doug Lea wrote: On 05/25/12 21:43, Ulf Zibis wrote: To me it seems, that computing the murmur hash is more expensive, especially on short strings, than the old hash algorithm. It is definitely slower, but also definitely has

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-30 Thread Doug Lea
On 05/29/12 17:25, Mike Duigou wrote: An intrinsic and/or native version might be added later if it turns out that the Java murmur3 implementation is a performance bottleneck. I don't think that going native will make much difference. The main disadvantages of using Murmur3 for char[]s are tha

Re: [7u6] Request for approval: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows

2012-05-30 Thread Edvard Wendelin
Approved! On May 29, 2012, at 10:35 PM, Kurchi Hazra wrote: > > Requesting approval to commit fix for CR 7170169. > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 > Webrev: http://cr.openjdk.java.net/~khazra/7170169/7u6/webrev.00/ > > This had been reviewed by darcy, dholmes, a