Request for Reviews 7173918&7173919: Small follow-ons to alternative hashing

2012-06-03 Thread Mike Duigou
Two small issues related to the larger alternative string hashing changes (CR#7126277) from last week. One issue is for JDK 7 and the other is for JDK 8. Both are quite small. For the JDK 7 issue, as documented in the review request, the default threshold for the alternative hashing in that pat

Re: [doc]Small modification on the WeakHashMap doc

2012-06-03 Thread Mike Duigou
The change looks good to me. On Jun 3 2012, at 20:05 , David Holmes wrote: > On 4/06/2012 11:55 AM, Charles Lee wrote: >> Thanks David. Do I need another review? > > Yes. Someone from TL - Mike or Alan most likely. > > David > >> On 06/03/2012 06:15 AM, David Holmes wrote: >>> Hi Charles, >>>

Re: [doc]Small modification on the WeakHashMap doc

2012-06-03 Thread David Holmes
On 4/06/2012 11:55 AM, Charles Lee wrote: Thanks David. Do I need another review? Yes. Someone from TL - Mike or Alan most likely. David On 06/03/2012 06:15 AM, David Holmes wrote: Hi Charles, I have no problem with this clarification in the implementation notes being added. I've checked w

Re: [doc]Small modification on the WeakHashMap doc

2012-06-03 Thread Charles Lee
Thanks David. Do I need another review? On 06/03/2012 06:15 AM, David Holmes wrote: Hi Charles, I have no problem with this clarification in the implementation notes being added. I've checked with Joe and it does not require CCC approval. David - On 28/05/2012 5:36 PM, Charles Lee wrote

Re: hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String

2012-06-03 Thread Mike Duigou
[I trimmed the distribution list] On Jun 3 2012, at 13:44 , Peter Levart wrote: > On Thursday, May 31, 2012 03:22:35 AM mike.dui...@oracle.com wrote: >> Changeset: 2c773daa825d >> Author:mduigou >> Date: 2012-05-17 10:06 -0700 >> URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c77