On 8/06/2012 6:39 AM, chris hegarty wrote:
Looks fine Kris (given the same change is being made to
hotspot/src/share/vm/prims/jvm.h)
I can sponsor this for you. We can use the same bug number seeing as
these are two separate repositories.
Bzzzt! No you can't!
In theory you can use one CR to c
Am 08.06.2012 00:03, schrieb Joe Darcy:
I would have written this as
ClassLoader cl = (cc != null) ? cc.getClassLoader() : null;
Alternative:
return (cc != null) ? cc.getClassLoader() : null;
-Ulf
Personally I don't think it is a bug. A j.l.String represents a sequence
of UTF-16 chars. While
a pair of surrogates represents a supplementary character, a single
surrogate itself is still
a "legal" independent entity inside a String object and length of a
String is still defined as
the total n
Hi Joe,
Thank you for the note.
Here is the diff
ace2 51 =>hg diff DriverManager.java
diff -r fc0e508b713f src/share/classes/java/sql/DriverManager.java
--- a/src/share/classes/java/sql/DriverManager.java Thu Jun 07 01:01:09
2012 -0700
+++ b/src/share/classes/java/sql/DriverManager.java
The feature is: http://apache.org/xml/features/standard-uri-conformant
True: Requires that a URI has to be provided where a URI is expected.
False: Some invalid URI's are accepted as valid values when a URI
is expected. Examples include: using platform dependent file separator
in plac
Hi Lance,
On 6/7/2012 2:13 PM, Lance Andersen - Oracle wrote:
Thanks Chris, Alan, Joe, Mandy.
Joe I will update the copyright but will not plan on a webrev for that..
Sure.
I thought line 470 was readable
ClassLoader cl = cc != null ? cc.getClassLoader() : null;
I would have wr
Thanks Chris, Alan, Joe, Mandy.
Joe I will update the copyright but will not plan on a webrev for that..
I thought line 470 was readable
ClassLoader cl = cc != null ? cc.getClassLoader() : null;
I would prefer to get this back for now vs. make that change as part of an
additional cle
Changeset: 633700642caf
Author:joehw
Date: 2012-06-07 13:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/633700642caf
7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform
subbenchmark
Summary: roll back XalanJ-2271 that caused the regression
Reviewed
Looks good. It's a good clean up.
Mandy
On 6/7/2012 11:47 AM, Lance Andersen - Oracle wrote:
Hi all,
Another review request (to go with the others that are outstanding).
This is change is for jigsaw, where we are removing the native code used by
DriverManager. The webrev can be found at:
On Fri, Jun 8, 2012 at 4:39 AM, chris hegarty wrote:
> Looks fine Kris (given the same change is being made to
> hotspot/src/share/vm/prims/**jvm.h)
>
> Yes. jvm.h in both the hotspot and jdk workspaces had incorrect comments
on JVM_SupportsCX8 before this change, but they were different because t
Generally looks fine, but I recommend some adjustments:
I'd like to see some "()" on this line!
470 ClassLoader cl = cc != null ? cc.getClassLoader() : null;
I prefer to update the copyright year as part of making the code changes.
-Joe
On 6/7/2012 11:47 AM, Lance Andersen - Oracl
Looks fine Kris (given the same change is being made to
hotspot/src/share/vm/prims/jvm.h)
I can sponsor this for you. We can use the same bug number seeing as
these are two separate repositories.
-Chris.
On 07/06/2012 21:10, Krystal Mok wrote:
Hi all,
As discussed on hotspot-compiler-dev [
On 07/06/2012 19:47, Lance Andersen - Oracle wrote:
Hi all,
Another review request (to go with the others that are outstanding).
This is change is for jigsaw, where we are removing the native code used by
DriverManager. The webrev can be found at:
http://cr.openjdk.java.net/~lancea/7172551/w
Looks fine to me.
-Chris.
On 07/06/2012 19:47, Lance Andersen - Oracle wrote:
Hi all,
Another review request (to go with the others that are outstanding).
This is change is for jigsaw, where we are removing the native code used by
DriverManager. The webrev can be found at:
http://cr.openjd
Hi all,
As discussed on hotspot-compiler-dev [1], I came across a typo in the
exported jvm.h in the jdk workspace while working on 7174218.
The fix is simple [2], and sync up with the changes in 7174218:
diff -r 7def50698e78 src/share/javavm/export/jvm.h
--- a/src/share/javavm/export/jvm.h Thu Ma
Hi, I'm a committer to the Apache Lucene project. We have randomized
tests and one seed hit the following (simplified) scenario:
String s1 = "AB\uD840\uDC00C";
String s2 = s1.replaceAll("", "X");
the input contains an extended unicode character (any surrogate pair
will do). The pattern is a
Hi all,
Another review request (to go with the others that are outstanding).
This is change is for jigsaw, where we are removing the native code used by
DriverManager. The webrev can be found at:
http://cr.openjdk.java.net/~lancea/7172551/webrev.00
Best,
Lance
Lance Andersen| Principal Membe
Changeset: fc0e508b713f
Author:mduigou
Date: 2012-06-07 01:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f
7174736: JCK test api/java_util/HashMap/index_EntrySet failing
Summary: Corrects a problem with HashMap.removeEntry() that caused a JCK test
to fail
Revi
I will give it a try.
Thanks,
muralx
On Thu, Jun 7, 2012 at 2:57 PM, Rémi Forax wrote:
> On 06/07/2012 07:14 PM, Diego Belfer wrote:
>
>> Hi Alan,
>>
>> Thanks to you. I will look for another issue I can solve.
>>
>> Is there any other tool for looking for open issues? The bugs database (
>> bu
On 06/07/2012 07:14 PM, Diego Belfer wrote:
Hi Alan,
Thanks to you. I will look for another issue I can solve.
Is there any other tool for looking for open issues? The bugs database (
bugs.sun.com) does not have an advance search which allows to look for open
issue and/or filtering by categorie
Changeset: 23f8be788c77
Author:alanb
Date: 2012-06-07 18:42 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23f8be788c77
7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win]
Reviewed-by: mduigou
! test/java/lang/ProcessBuilder/Basic.java
Hi Alan,
Thanks to you. I will look for another issue I can solve.
Is there any other tool for looking for open issues? The bugs database (
bugs.sun.com) does not have an advance search which allows to look for open
issue and/or filtering by categories.
Best,
Diego
On Thu, Jun 7, 2012 at 8:41 A
I am ok with it based on a once-over and the fact you are passing all of the
tests
Best
Lance
On Jun 5, 2012, at 11:23 PM, Joe Wang wrote:
> I tested through all of the Xalan updates and found XalanJ-2271 to be the
> culprit. It [1] was intended to improve performance in webserver environment
Changeset: 9b814b887240
Author:weijun
Date: 2012-06-07 22:33 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b814b887240
7175041: HttpTimestamper should accept https URI
Reviewed-by: mullan
! src/share/classes/sun/security/timestamp/HttpTimestamper.java
Mike,
ProcessBuilder/Basic.java has been failing on Windows since the hash
work went into jdk8/tl. This test is 11500 tests in one and the
removeMappings fix fixes some of the failures. I looked into remaining
issues today and it's another assumption on iteration order. A child
process prints
Changeset: c89018e3f3b6
Author:nloodin
Date: 2012-06-05 13:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c89018e3f3b6
7163471: Licensee source bundle failed around 7u4
Reviewed-by: dholmes, sla, brutisso, erikj
! make/com/oracle/Makefile
On 04/06/2012 16:33, Diego Belfer wrote:
Hi Alan,
I've already sent the signed OCA. Will you sponsor the patch ?
It's pushed now, see:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-June/010443.html
Thanks for the contribution.
-Alan.
Changeset: 757a5129fad7
Author:alanb
Date: 2012-06-07 12:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/757a5129fad7
7164256: EnumMap clone doesn't clear the entrySet keeping a reference to the
original Map
Reviewed-by: alanb, chegar, forax, mduigou
Contributed-by: dbel..
Changeset: 636f9486fde7
Author:alanb
Date: 2012-06-07 10:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/636f9486fde7
7175011: ProblemList.txt updates (6/2012)
Reviewed-by: mduigou, chegar
! test/ProblemList.txt
Thanks Alan, for doing this.
-Chris.
On 07/06/2012 09:14, Alan Bateman wrote:
We have two test failures that look like they will take a while to get
resolved in jdk8/tl. One of them is the FPU precision issue that Kelly
brought up a few days ago. The other is a jconsole test that was missed
by
We have two test failures that look like they will take a while to get
resolved in jdk8/tl. One of them is the FPU precision issue that Kelly
brought up a few days ago. The other is a jconsole test that was missed
by some recent refactoring in that area. I'd like to put these tests on
the Pro
Hello all;
Alan Bateman tracked down a regression introduced by the Alternative HashMap
changes which was caught by the JCK tests. The fix is a one liner:
diff --git a/src/share/classes/java/util/HashMap.java
b/src/share/classes/java/util/HashMap.java
--- a/src/share/classes/java/util/HashMap.j
32 matches
Mail list logo
