Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Xueming Shen
On 06/08/2012 12:07 PM, Ulf Zibis wrote: Thanks Sherman! Am 08.06.2012 20:36, schrieb Xueming Shen: On 06/08/2012 05:16 AM, Ulf Zibis wrote: Is there any spec weather the Java Regex API has a general contract with 16-bit chars or Unicode codepoints? The regex spec says Pattern and Matcher

Re: Fwd: Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly

2012-06-08 Thread Joe Wang
Lance, It looks fine to me. Best, Joe On 6/5/2012 7:16 AM, Lance Andersen - Oracle wrote: Looking for a reviewer here as well still Best Lance Begin forwarded message: From: Lance Andersen - Oracle Date: May 26, 2012 9:33:40 AM EDT Cc: core-libs-dev core-libs-dev Subject: Re: Review reques

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Ulf Zibis
Thanks Sherman! Am 08.06.2012 20:36, schrieb Xueming Shen: On 06/08/2012 05:16 AM, Ulf Zibis wrote: Is there any spec weather the Java Regex API has a general contract with 16-bit chars or Unicode codepoints? The regex spec says Pattern and Matcher work ON character sequence with the refe

hg: jdk8/tl/jaxp: 7157608: One feature is not recognized.

2012-06-08 Thread huizhe . wang
Changeset: 238d2d0249af Author:joehw Date: 2012-06-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/238d2d0249af 7157608: One feature is not recognized. Summary: adding feature standard-uri-conformant into the recognized list Reviewed-by: psandoz ! src/com/sun/org/ap

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Xueming Shen
On 06/08/2012 05:16 AM, Ulf Zibis wrote: Is there any spec weather the Java Regex API has a general contract with 16-bit chars or Unicode codepoints? The regex spec says Pattern and Matcher work ON character sequence with the reference to CharSequence interface, but the pattern itself does

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Xueming Shen
If we can re-design everything (not the lib, but the language) allover again from the very beginning , and if we all put an i18n engr's hat on:-) it might be nature to have a 32-bit char instead of the 16-bit (OK, it's totally a difference story if from performance point of view), and then we w

hg: jdk8/tl/jdk: 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true

2012-06-08 Thread rob . mckenna
Changeset: a7895dc61088 Author:robm Date: 2012-06-08 18:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7895dc61088 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Reviewed-by: alanb, chegar ! src/share/classes/sun/

hg: jdk8/tl: 7165257: Add JFR tests to the JDK code base

2012-06-08 Thread staffan . larsen
Changeset: df998cd4d51d Author:sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/df998cd4d51d 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties

hg: jdk8/tl/jdk: 2 new changesets

2012-06-08 Thread staffan . larsen
Changeset: 82c41d3065e2 Author:sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82c41d3065e2 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile Changeset: 961807959c5f Au

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Ulf Zibis
Oops, correction: StringBuilder sb = new StringBuilder(s1.length * 2 + 1); for (char c : s1.getChars()) sb.append('X').append(c); String s2 = sb.append('X').toString(); Am 08.06.2012 14:16, schrieb Ulf Zibis: I tend to agree Dawid. Especially the comparison with Python behaviour is demonstr

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Ulf Zibis
I tend to agree Dawid. Especially the comparison with Python behaviour is demonstrative. Is there any spec weather the Java Regex API has a general contract with 16-bit chars or Unicode codepoints? Thinking about the search pattern e.g. "[AB\uD840\uDC00C]"; what does it actually search for, th

hg: jdk8/tl/jdk: 2 new changesets

2012-06-08 Thread lance . andersen
Changeset: 8305ddc88a5a Author:lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile

Re: Request for Review(XS): 7156963 Incorrect copyright header in java/io/SerialCallbackContext

2012-06-08 Thread Edvard Wendelin
Correct! Thanks for pointing that out. Don't know how it ended up getting one extra space on each line. Updated webrev on http://cr.openjdk.java.net/~ewendeli/7156963/webrev.02/ Thanks, Edvard On 06/05/2012 02:25 AM, Weijun Wang wrote: It seems the whole copyright header is one-char shifted t

Re: Empty regexp replaceall and surrogate pairs results in corrupted utf16.

2012-06-08 Thread Dawid Weiss
I guess a lot depends on the point of view. From historical point of view (where a char[] and a String are basically unsigned values) that pattern should simply process every value (index) and work like you say. But from a practical point of view I think it is a bug -- it corrupts the string, trans

hg: jdk8/tl/jdk: 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h

2012-06-08 Thread chris . hegarty
Changeset: abe465d6a9b8 Author:chegar Date: 2012-06-08 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe465d6a9b8 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Reviewed-by: chegar Contributed-by: Krystal Mok ! src/share/javavm/export/jvm.h

Re: typo in comments of JVM_SupportsCX8 in jvm.h

2012-06-08 Thread Chris Hegarty
On 08/06/12 02:51, David Holmes wrote: On 8/06/2012 6:39 AM, chris hegarty wrote: Looks fine Kris (given the same change is being made to hotspot/src/share/vm/prims/jvm.h) I can sponsor this for you. We can use the same bug number seeing as these are two separate repositories. Bzzzt! No you c

Re: [7u6] RFR (JAXP) : 7157608: One feature is not recognized.

2012-06-08 Thread Paul Sandoz
Hi Joe, Looks OK to me. Paul. On Jun 8, 2012, at 12:27 AM, Joe Wang wrote: > The feature is: http://apache.org/xml/features/standard-uri-conformant > > True: Requires that a URI has to be provided where a URI is expected. > False: Some invalid URI's are accepted as valid values when