For the record, javadoc uses substring very heavily, and might be
impacted by this change.
-- Jon
On 06/03/2012 02:35 PM, Mike Duigou wrote:
[I trimmed the distribution list]
On Jun 3 2012, at 13:44 , Peter Levart wrote:
On Thursday, May 31, 2012 03:22:35 AM mike.dui...@oracle.com wrote:
C
Am 14.06.2012 22:26, schrieb Mike Duigou:
On Jun 14 2012, at 09:29 , Ulf Zibis wrote:
Hi Mike,
I like the 1-liner ... :-)
int h = hashSeed ^ k.hashCode();
... but I'm still missing a little comment, what this xor with a hashSeed
serves for. Such as brief, as the next following 3 lin
On Jun 14 2012, at 09:29 , Ulf Zibis wrote:
> Hi Mike,
>
> I like the 1-liner ... :-)
>int h = hashSeed ^ k.hashCode();
>
> ... but I'm still missing a little comment, what this xor with a hashSeed
> serves for. Such as brief, as the next following 3 lines about preventing
> from col
Looks good Mike
Best
Lance
On Jun 14, 2012, at 3:40 PM, Mike Duigou wrote:
> Hello all;
>
> This review is for test changes only. CR#7174736
> (http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f) corrected a problem
> uncovered by a JCK test. A regression test was not included in that
>
Hello all;
This review is for test changes only. CR#7174736
(http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0e508b713f) corrected a problem
uncovered by a JCK test. A regression test was not included in that changeset.
This patch adds a regression test for the root cause of CR#7174736 as well as
Thanks for the comments
On Jun 13, 2012, at 6:03 PM, Ulf Zibis wrote:
>
> Am 13.06.2012 13:04, schrieb Lance Andersen - Oracle:
>> Hi Paul,
>>
>> Thank you for taking the time to review the code.
>>
>>
>> I made the change you suggested below
>>
>> http://cr.openjdk.java.net/~lancea/7145913/
Changeset: 28588ace1fb9
Author:lancea
Date: 2012-06-14 15:05 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9
7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Reviewed-by: joehw, naoto, psandoz, forax
! src/share/classes/com/sun/rowset/internal/Cach
Hi Mike,
I like the 1-liner ... :-)
int h = hashSeed ^ k.hashCode();
... but I'm still missing a little comment, what this xor with a hashSeed serves for. Such as brief,
as the next following 3 lines about preventing from collisions.
WeakHashMap.hash(Object) could be private too, ins
Changeset: 505455116320
Author:mduigou
Date: 2012-06-13 16:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/505455116320
7173919: Minor optimization of hashing methods
Summary: several minor optimizations to hashing methods used by hash map classes
Reviewed-by: dholmes
! sr
Changeset: 4f99d146fce0
Author:alanb
Date: 2012-06-14 12:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f99d146fce0
7176630: (sc) SocketChannel.write does not write more than 128k when channel
configured blocking [win]
Reviewed-by: khazra, chegar
! src/windows/native/su
Diego,
It's not too difficult to create jars on the fly using the Jar API. Here
is a small example that I think would work nice in this case. Files
created ( and paths are relative to the jtreg scratch, or working dir if
running outside of jtreg ).
Do you think you could use similar to creat
11 matches
Mail list logo
