Thanks guys.
I lined up the indentation to make things a bit nicer.
I prefer the Oxford comma, though, and presumably so did the original author.
For further discussion see
http://en.wikipedia.org/wiki/Serial_comma
s'marks
On 6/29/12 4:02 PM, Ulf Zibis wrote:
I think, you could drop the co
Changeset: 9df29b658145
Author:smarks
Date: 2012-06-29 16:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9df29b658145
7170938: (str) incorrect wording in doc for String.subSequence
Reviewed-by: forax, mduigou
Contributed-by: Joe Bowbeer
! src/share/classes/java/lang/Stri
I think, you could drop the comma before "or" and align indentation after
@param, @return and @throws.
-Ulf
Am 30.06.2012 00:29, schrieb Stuart Marks:
Hi Core Libbers,
Please review some small wording and markup changes to the doc for
String.subSequence. The wording
change is simply fixing
Looks good from me too!
Mike
On Jun 29 2012, at 15:29 , Stuart Marks wrote:
> Hi Core Libbers,
>
> Please review some small wording and markup changes to the doc for
> String.subSequence. The wording change is simply fixing a mistake, not a
> semantic spec change.
>
> http://cr.openjdk.java.
Changeset: 9e15068b6946
Author:jgish
Date: 2012-06-29 15:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e15068b6946
7100996: (spec str) IndexOutOfBoundsException when using a StringBuffer from
multiple threads
Summary: add usage note to clarify thread safety
Reviewed-by:
On 06/30/2012 12:29 AM, Stuart Marks wrote:
Hi Core Libbers,
Please review some small wording and markup changes to the doc for
String.subSequence. The wording change is simply fixing a mistake, not
a semantic spec change.
http://cr.openjdk.java.net/~smarks/reviews/7170938/webrev.0/
Thanks,
Hi Core Libbers,
Please review some small wording and markup changes to the doc for
String.subSequence. The wording change is simply fixing a mistake, not a
semantic spec change.
http://cr.openjdk.java.net/~smarks/reviews/7170938/webrev.0/
Thanks,
s'marks
I've posted the updated webrev here:
http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webrev.1/
This code is pretty much the same as 6948101 and the same comments I had on
that bug apply here as well, so please make similar updates to this one.
Thanks.
s'marks
On 6/29/12 1:36 AM, Eric
Thanks for updating this. I've posted the revised webrev:
http://cr.openjdk.java.net/~smarks/yiming.wang/6948101/webrev.1/
It's good that this is getting simpler in that we don't have to deal with
finalization. But it can still get simpler The code is in the webrev but
I'll also paste it h
Hi Martijn,
Thanks for this contribution. I'm finally getting back to it. (Also, Kurchi,
Remi, thanks for taking a look as well.)
The java.util patches look good and are almost ready to go in. The only issue
is how to format the Contributed-by line in the changeset comment. What I have
so fa
Hi Stuart & David??
Attachment is the new changes to make code simply by following David
suggestion, Can you help please review again, Thanks a lot!
Regards,
Eric
On 2012/6/28 12:40, Stuart Marks wrote:
I've posted the webrev here:
http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webre
Hi David,
I have made changes by following your suggestion. Can you please help to
review again? Thanks a lot!
I also change the code of 7123972 which is sent in another mail.
Regards,
Eric
On 2012/6/29 11:04, David Holmes wrote:
On 29/06/2012 12:10 PM, Eric Wang wrote:
Hi Stuart,
Thank yo
12 matches
Mail list logo
