Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-05 Thread Eric Wang
Hi Marks, Thanks for your great help to review and push my first fix.:-) Regards, Eric On 2012/7/6 6:19, Stuart Marks wrote: Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd s'marks On 7/3/12 6:54 PM, Eric Wang wrote: Opps, It is my carelessness, I will be more careful in the

hg: jdk8/tl/jdk: 7181353: Update error message to distinguish native OOM and java OOM in net

2012-07-05 Thread luchsh
Changeset: 15a6b0bceb1e Author:zhouyx Date: 2012-07-06 10:36 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15a6b0bceb1e 7181353: Update error message to distinguish native OOM and java OOM in net Reviewed-by: chegar ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/sol

Re: [Patch] Review request - bug 7147060 com/sun/org/apache/xml/internal/security/transforms/ClassLoaderTest.java doesn't run in agentvm mode

2012-07-05 Thread Stuart Marks
(Note to core-libs-dev: further review and discussion of this bugfix is occurring on security-dev.) On 7/5/12 1:18 AM, Eric Wang wrote: Hi David & Stuart, Can you please help to review the fix for the bug 7147060 , Thanks you! The test report

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

2012-07-05 Thread Stuart Marks
Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad204cc7433 s'marks On 7/3/12 2:04 PM, Stuart Marks wrote: Webrev posted here: http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webrev.2/ The changes look good. If there's no further discussion, I'll push them in a couple days. s'mar

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-05 Thread Stuart Marks
Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd s'marks On 7/3/12 6:54 PM, Eric Wang wrote: Opps, It is my carelessness, I will be more careful in the next bug fixes. Thank you to review and change it. Regards, Eric On 2012/7/4 8:58, Stuart Marks wrote: Sure, I can take care

hg: jdk8/tl/jdk: 7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently

2012-07-05 Thread stuart . marks
Changeset: 4ad204cc7433 Author:smarks Date: 2012-07-05 15:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad204cc7433 7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently Reviewed-by: dholmes, smarks Contributed-by: Eric Wang ! test/ProblemList.tx

hg: jdk8/tl/jdk: 6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-05 Thread stuart . marks
Changeset: 97eb7a4b1fdd Author:smarks Date: 2012-07-05 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd 6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently Reviewed-by: dholmes, smarks Contributed-by: Eric Wang ! test/

Code Review Request 7142596: RMI JPRT tests are failing

2012-07-05 Thread Darryl Mocek
Hello core-libs. Please review this webrev to fix Bugs #7142596 and 7161503. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7142596/webrev.02. This commit fixes concurrency issues with the RMI tests. - Added TestLibrary.createRegistryOnUnusedPort method. This creates an RMIRe

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-05 Thread Lance Andersen - Oracle
Hi Deven, We had a holiday here on Weds, so I am still catching up. First, thank you for taking the time to propose a patch. Here are a few comments based on the changes I have made in my workspace and comparing to your proposed changes - The same issue applies to SerialClob - instead of d

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-07-05 Thread Xueming Shen
On 07/05/2012 01:40 AM, Dawid Weiss wrote: export LC_ALL=en_US.UTF-8; java Foo Not really, the shell won't let you use a multibyte locale (because of issues with null-terminated strings). And multibyte (with BOM) is most fun when you're trying to find buggy code ;) Encodings for those Chinese,

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-07-05 Thread Dawid Weiss
> export LC_ALL=en_US.UTF-8; java Foo Not really, the shell won't let you use a multibyte locale (because of issues with null-terminated strings). And multibyte (with BOM) is most fun when you're trying to find buggy code ;) > I would assume there is no en_US.UTF-16 locale there :-) I wish ther

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-07-05 Thread Xueming Shen
Given you are using -Dfile.encoding=xyz from command line, guess you might not have problem to do something like (on a bash for example) export LC_ALL=en_US.UTF-8; java Foo export LC_ALL=ja_JP.SJIS; java Foo you might need to install all those supported locales on you system though, but isn't

[Patch] Review request - bug 7147060 com/sun/org/apache/xml/internal/security/transforms/ClassLoaderTest.java doesn't run in agentvm mode

2012-07-05 Thread Eric Wang
Hi David & Stuart, Can you please help to review the fix for the bug 7147060 , Thanks you! The test reports ClassNotFoundException which is caused by below reasons: 1. Class can be found in "test.classes" instead of "test.src". 2. In agentvm m

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-07-05 Thread Dawid Weiss
Thanks for the explanation, it helps. Maybe I should follow-up with the rationale of why we want to override it in the first place. We randomize file.encoding to a small subset of JVM-supported encodings to make sure there are no hidden encoding-specific issues in Lucene/ Solr. This is actually a

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-07-05 Thread Xueming Shen
The code cited is a little shortcut, if there is locale over there is indeed using utf-16, or any encoding that needs to switch/shift into ASCII (or its single byte charset area) with a shift/in/out character.. So far I'm not aware of any such a locale on any our supported platform. Historically