hg: jdk8/tl/jdk: 7179879: SSLSocket connect times out instead of throwing socket closed exception

2012-07-26 Thread sean . coffey
Changeset: 35fec642fd32 Author:coffeys Date: 2012-07-26 22:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35fec642fd32 7179879: SSLSocket connect times out instead of throwing socket closed exception Reviewed-by: xuelei, chegar ! src/share/classes/sun/security/ssl/SSLSock

Re: RFR: 691423 - (str) Missing synchronization in java.lang.String#contentEquals(CharSequence)

2012-07-26 Thread Jim Gish
OK. With that in mind, here's an update where I leave contentEquals( StringBuffer ) in place (adding a clarifying spec), and defer the synchronization as I had it to the contentEquals( CharSequence ) method: diff --git a/src/share/classes/java/lang/String.java b/src/share/classes/java/lang/St

Re: RFR: 691423 - (str) Missing synchronization in java.lang.String#contentEquals(CharSequence)

2012-07-26 Thread Mike Duigou
This would appear to be source compatible but not binary compatible. I don't believe we can remove the contentsEqual(StringBuffer) overload. Code compiled against the existing interface would fail to find the CharSequence interface at runtime and fail. I believe it would be reasonable to add lo

RFR: 691423 - (str) Missing synchronization in java.lang.String#contentEquals(CharSequence)

2012-07-26 Thread Jim Gish
Summary: currently String.contentEquals( StringBuffer sb ) synchronizes on sb, but String.contentEquals( CharSequence cs ) does not sync when cs is a StringBuffer Proposed change: remove contentEquals( StringBuffer ) and have contentEquals( CharSequence ) do the checking and synchronize if the

hg: jdk8/tl/jdk: 7187051: ShortRSAKeynnn.sh tests should do cleanup before start test

2012-07-26 Thread weijun . wang
Changeset: f267302093d4 Author:weijun Date: 2012-07-26 20:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f267302093d4 7187051: ShortRSAKeynnn.sh tests should do cleanup before start test Reviewed-by: xuelei ! test/sun/security/mscapi/ShortRSAKey1024.sh