Codereview request for 7189363: Regex Pattern compilation buggy for special sequences

2012-08-08 Thread Xueming Shen
Hi It appears the optimization (flatten a binary tree structure into a branch/ switch) we put into JDK6 for alternation operation [1] has problem if the first construct is a group "(...)" followed by a greedy/reluctant "once or not at all" quantifier. For example regex "(a)?bc|d" or "(a)??bc|d"

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-08 Thread Naoto Sato
On 8/7/12 2:57 AM, Erik Joelsson wrote: See inline On 2012-07-13 22:20, Kelly O'Hair wrote: Something seems strange here: http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html It's like someone was avoiding overall quotes, but using them to add spaces someh

hg: jdk8/tl/langtools: 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}

2012-08-08 Thread sundararajan . athijegannathan
Changeset: f071cd32d297 Author:sundar Date: 2012-08-08 22:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f071cd32d297 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {} Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/tree/TreeInfo

hg: jdk8/tl/jdk: 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes

2012-08-08 Thread kumar . x . srinivasan
Changeset: a44671e0b6d7 Author:ksrini Date: 2012-08-08 09:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7 7189944: (launcher) test/tools/launcher/Aghs.java needs a couple of minor fixes Reviewed-by: darcy, jgish ! test/tools/launcher/Arrrghs.java ! test/t

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-08 Thread Neil Richards
On Wed, 2012-08-08 at 13:28 +0100, Alan Bateman wrote: > On 07/08/2012 19:07, Neil Richards wrote: > > : > > Digging back into its history, I see that it all stems from running java > > under 'nohup' (e.g. 'nohup java ProgramWithShutdownHooks&'). > > > > 'nohup' prevents things being registered aga

Re: Request for simple review of launcher tests 7189944

2012-08-08 Thread Joe Darcy
Looks fine Kumar. Cheers, -Joe On 8/8/2012 7:35 AM, Kumar Srinivasan wrote: Hi, In my previous push for http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/ I missed adding CR number to the regression test Arrrghs.java, also some minor improvements to TestHelper.java for better diagnosis o

Re: Request for simple review of launcher tests 7189944

2012-08-08 Thread Jim Gish
Looks good to me. Jim On 08/08/2012 10:35 AM, Kumar Srinivasan wrote: Hi, In my previous push for http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/ I missed adding CR number to the regression test Arrrghs.java, also some minor improvements to TestHelper.java for better diagnosis of failin

hg: jdk8/tl/jdk: 7189886: (aio) Add test coverage for AsynchronousChannelGroup.withThreadPool

2012-08-08 Thread alan . bateman
Changeset: a50e92a980a5 Author:alanb Date: 2012-08-08 15:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50e92a980a5 7189886: (aio) Add test coverage for AsynchronousChannelGroup.withThreadPool Reviewed-by: alanb Contributed-by: amy...@oracle.com ! test/java/nio/channels/

Request for simple review of launcher tests 7189944

2012-08-08 Thread Kumar Srinivasan
Hi, In my previous push for http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/ I missed adding CR number to the regression test Arrrghs.java, also some minor improvements to TestHelper.java for better diagnosis of failing tests. http://cr.openjdk.java.net/~ksrini/7189944/webrev.0/ Thanks K

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-08 Thread Alan Bateman
On 07/08/2012 19:07, Neil Richards wrote: : Digging back into its history, I see that it all stems from running java under 'nohup' (e.g. 'nohup java ProgramWithShutdownHooks&'). 'nohup' prevents things being registered against SIGHUP, so trying to do so causes an exception to be thrown. When th

Re: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c

2012-08-08 Thread Andrew Hughes
- Original Message - > On 08/08/2012 01:33, David Holmes wrote: > > On 8/08/2012 2:40 AM, Xueming Shen wrote: > >> > >> Andrew, > >> > >> Since we are here:-) are we also supposed to "free" the old_temp > >> at #250 > >> and old_temp and old_ev at the end? > > > > No. They are aliases for t

hg: jdk8/tl/jdk: 7189533: GetJavaProperties should free temporary file if subsequent allocations fails

2012-08-08 Thread ahughes
Changeset: d87e86aaf2b3 Author:andrew Date: 2012-08-08 12:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d87e86aaf2b3 7189533: GetJavaProperties should free temporary file if subsequent allocations fails Summary: Add missing calls to free Reviewed-by: alanb, dholmes, sher

Re: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c

2012-08-08 Thread Alan Bateman
On 08/08/2012 01:33, David Holmes wrote: On 8/08/2012 2:40 AM, Xueming Shen wrote: Andrew, Since we are here:-) are we also supposed to "free" the old_temp at #250 and old_temp and old_ev at the end? No. They are aliases for temp and encoding_variant, which are freed at the end. There are o