Re: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String

On 22/08/2012 11:52 AM, David Holmes wrote: StringBuilder.java /** + * @throws IllegalArgumentException if n < 0 {@inheritDoc} This is wrong as you've already written the inherited doc "if n < 0". + * @since 1.8 + */ + public StringBuilder append(int n, CharSequence cs) { + super.append(n, cs)

Re: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String

On 22 August 2012 10:46, Alan Bateman wrote: > On 21/08/2012 21:45, Jim Gish wrote: >> Please review http://cr.openjdk.java.net/~jgish/6984084-jdk8-StringRepeat/ >> >> >> This started in lambda, making changes to both StringJoiner an

Re: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String

FWIW, the few times I "needed" a repeat operation it's always been with a char, not a string. I think a common use case for this to create some layout in the printed string, such as adding a separator (e.g. "*", "-", etc) or adding white space padding (could also be something like

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

On 22/08/2012 08:54, Eric Wang wrote: Hi, Please help to review the fix below for bug 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Root cause is t

Re: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String

On 21/08/2012 21:45, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/6984084-jdk8-StringRepeat/ This started in lambda, making changes to both StringJoiner and String. However, the dependence of String.repeat()

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

On 22/08/2012 6:10 PM, Eric Wang wrote: Hi David, To use dirFile.length() == 0 to replace the disk space measurement as guess the original test tries to prove that there's no extra disk spent when creating empty folders. Sorry I don't understand. File.length() says: public long length() Retu

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi, Eric I'm a little confused about on which platform should this test run? In the old code, the test should run: i = 4,5,6 on all platforms except win_9 win_me ( and solaris due to machine issue(?)) i = 20 on windows only Now in new code, the whole test will only run on windows. Tha

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi David, To use dirFile.length() == 0 to replace the disk space measurement as guess the original test tries to prove that there's no extra disk spent when creating empty folders. Regards, Eric On 2012/8/22 16:02, David Holmes wrote: Hi Eric, On 22/08/2012 5:54 PM, Eric Wang wrote: Pleas

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi Eric, On 22/08/2012 5:54 PM, Eric Wang wrote: Please help to review the fix below for bug **6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Root caus

[PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

Hi, Please help to review the fix below for bug **6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Root cause is the test is not reliable when system i