Looks fine Kumar.
Cheers,
-Joe
On 9/4/2012 2:10 PM, Kumar Srinivasan wrote:
Hi Joe, Sherman,
Made the ScenarioB conditional on env variable or java property.
ScenarioA's files are not all that big.
The new webrev is here:
http://cr.openjdk.java.net/~ksrini/7194005/webrev.1/
The delta webrev
Hi Joe, Sherman,
Made the ScenarioB conditional on env variable or java property.
ScenarioA's files are not all that big.
The new webrev is here:
http://cr.openjdk.java.net/~ksrini/7194005/webrev.1/
The delta webrev from the last webrev is here:
http://cr.openjdk.java.net/~ksrini/7194005/webrev.
Changeset: 7dda50fe8e1c
Author:jjg
Date: 2012-09-04 12:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dda50fe8e1c
7195519: OutOfMemoryError in docs build after 7151010
Reviewed-by: darcy
! make/docs/Makefile
Hi Sherman,
Thanks for the review, I will make that test conditional.
As for using the entry points I looked at it, the issue
is that java_util_zip reading code is dependent on jni and the jvm
loaded, but here in the launcher we are still early in the
launch process and we do not yet have a
Kumar,
The change looks fine with me. Agreed that you definitely don't want to
run the auto test for
a > 4G file. The >4G test in zip/jar area was checked in as a manual test.
Just wonder you might want to consider to use (statically include, like
you do for those zlib
code) the zip_util/ZIP_
Hi Joe,
I was thinking about that too, yes I will make it conditional
on a system property or env variable.
Kumar
- joe.da...@oracle.com wrote:
> From: joe.da...@oracle.com
> To: kumar.x.sriniva...@oracle.com
> Cc: core-libs-dev@openjdk.java.net, xueming.s...@oracle.com,
> james.holm
Hi Kumar,
From a quick look I didn't seen any problems, but defaulting to running
a test that writes multiple gibabytes to disk may have unwanted
performance costs for general testing. Perhaps that scenario could be
included in the test code, but only run on an opt-in basis?
-Joe
On 9/4/20
Hi Sherman, Joe, et. al.
Please review the launcher changes to read the manifest of
a ZIP64 archive.
http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/
Thanks
Kumar
Changeset: b7b33a3c9df0
Author:xuelei
Date: 2012-09-04 02:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b33a3c9df0
7195733: TEST_BUG:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java
failing
Reviewed-by: chegar, alanb, xuelei
Contributed-by
