Re: Code Review Request: 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock"

2012-09-21 Thread Weijun Wang
I think jtreg would automatically reset any changed system property so othervm is not necessary. Have you tried running it with other tests in agentvm mode? Thanks Max 在 Sep 22, 2012,2:49 AM,Kurchi Hazra 写道: > > > On 21.09.2012 02:03, Chris Hegarty wrote: >> On 21/09/12 01:12, Dan Xu wrote:

Re: Code Review Request: 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock"

2012-09-21 Thread Kurchi Hazra
On 21.09.2012 02:03, Chris Hegarty wrote: On 21/09/12 01:12, Dan Xu wrote: Kurchi, Can you append bug number 7197662 to @bug field in each test so that it is easy to check its history? Yes, this is always a good idea. Sure, I missed adding the bug id. For your changes, I wonder why you

hg: jdk8/tl/jdk: 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer

2012-09-21 Thread alan . bateman
Changeset: 3cfb621d5e7e Author:alanb Date: 2012-09-21 15:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cfb621d5e7e 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer Reviewed-by: iris, dxu, chegar ! src/share/classes/java/

Re: Code Review Request: 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock"

2012-09-21 Thread Chris Hegarty
On 21/09/12 01:12, Dan Xu wrote: Kurchi, Can you append bug number 7197662 to @bug field in each test so that it is easy to check its history? Yes, this is always a good idea. For your changes, I wonder why you choose to run these tests in othervm mode. Thanks! The tests need to run in oth

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-09-21 Thread Alan Bateman
On 21/09/2012 04:21, Deven You wrote: Hi Lance, I am very busy with other work so I can't work with the SerialBlob/SerialClob item for long time. I am very happy to refine the current test case and create new tests for SerialClob. I have create a new webre[1] for this task, please review it.