hg: jdk8/tl/jdk: 7200295: CertificateRequest message is wrapping when using large numbers of Certs

2012-09-26 Thread xuelei . fan
Changeset: a58585051c4b Author:xuelei Date: 2012-09-26 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a58585051c4b 7200295: CertificateRequest message is wrapping when using large numbers of Certs Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/HandshakeMess

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Mandy Chung
Hi Jim, On 9/26/2012 2:19 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can sub-class java.util.logging.MemoryHandler and specify i

RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can sub-class java.util.logging.MemoryHandler and specify its configuration in a logging.properties file via

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Time to go home :-( I did send to the right list-- it's just that my mailer didn't show the whole address. Yikes! Sorry about the spam. Please review as originally requested. On 09/26/2012 06:21 PM, Jim Gish wrote: Sorry -- wrong list -- I mean to send to the openjdk list. On 09/26/2012

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Sorry -- wrong list -- I mean to send to the openjdk list. On 09/26/2012 05:19 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can sub-

Re: RFR: 6206780 (str) Forwarding append methods in String{Buffer, Builder} are inconsistent

2012-09-26 Thread Jim Gish
On 09/26/2012 06:12 AM, Chris Hegarty wrote: Hi Jim, This is a nice cleanup, and certainly makes builder and buffer more consistent. Some specific comments: - StringBuilder Why the change to the public doc for append(StringBuffer)? It looks wrong to me. It is now taking about the wron

hg: jdk8/tl/langtools: 7188968: New instance creation expression using diamond is checked twice

2012-09-26 Thread maurizio . cimadamore
Changeset: db36841709e4 Author:mcimadamore Date: 2012-09-26 14:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/db36841709e4 7188968: New instance creation expression using diamond is checked twice Summary: Unify method and constructor check logic Reviewed-by: jjg ! s

Re: RFR: 6206780 (str) Forwarding append methods in String{Buffer, Builder} are inconsistent

2012-09-26 Thread Chris Hegarty
Hi Jim, This is a nice cleanup, and certainly makes builder and buffer more consistent. Some specific comments: - StringBuilder Why the change to the public doc for append(StringBuffer)? It looks wrong to me. It is now taking about the wrong given type. - Trivially, the year in the he