Re: StackTraceElement question

2012-10-06 Thread Krystal Mok
Hi, I believe this discussion belongs to core-libs-dev list better. cc'd. - Kris On Sat, Oct 6, 2012 at 3:04 AM, Christos Zoulas wrote: > Hi, > > I don't know if this belongs to this list, but if it does not, > please point me to where it does. I think that it would be nice if > StackTraceElem

Re: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations

2012-10-06 Thread Jim Gish
Looks good, Alan. A minor typo: For the javadoc of private static class XmlSupport (line 1128 of java/util/Properties.java), probably should say "fully qualifed name" rather than "full-qualified name" Jim On 10/05/2012 09:41 AM, Alan Bateman wrote: Properties defines the loadFromXML and s

Re: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations

2012-10-06 Thread Remi Forax
On 10/06/2012 03:05 PM, Alan Bateman wrote: On 06/10/2012 13:42, Remi Forax wrote: Thanks Alan, I'm fine with methods loadProviderAsService and loadProviderFromProperty, but I think you can remove loadProvider because PROVIDER can be initialized in a static block. private static final XmlPro

Re: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations

2012-10-06 Thread Alan Bateman
On 06/10/2012 13:42, Remi Forax wrote: Thanks Alan, I'm fine with methods loadProviderAsService and loadProviderFromProperty, but I think you can remove loadProvider because PROVIDER can be initialized in a static block. private static final XmlPropertiesProvider PROVIDER; static { PROVIDE

Re: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations

2012-10-06 Thread Remi Forax
On 10/06/2012 01:30 PM, Alan Bateman wrote: On 05/10/2012 22:31, Remi Forax wrote: Hi Alan, just some minor nits, in Properties.XmlSupport, 'provider' should be PROVIDER because it's a constant and instead of using loadProvider(), you should initialize PROVIDER in a static block. line 1172,

Re: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations

2012-10-06 Thread Alan Bateman
On 05/10/2012 22:31, Remi Forax wrote: Hi Alan, just some minor nits, in Properties.XmlSupport, 'provider' should be PROVIDER because it's a constant and instead of using loadProvider(), you should initialize PROVIDER in a static block. line 1172, you declare a provider and line 1174, you ini

hg: jdk8/tl/langtools: 7177386: Add attribution support for method references

2012-10-06 Thread maurizio . cimadamore
Changeset: d4b3cb1ece84 Author:mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmit