hg: jdk8/tl/jdk: 8000954: Add final keyword to new method in SSLParameters

2012-10-19 Thread xuelei . fan
Changeset: 21f1b88e68ce Author:xuelei Date: 2012-10-19 20:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21f1b88e68ce 8000954: Add final keyword to new method in SSLParameters Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLParameters.java

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-19 Thread Xueming Shen
Understood. I do have the code:-) but I'm hesitated to go SharedSecrets simply for performance gain of a utility method. This definitely can be addressed if it turns out to be a real issue standing in critical path. -Sherman -

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-19 Thread Mike Duigou
For me the greater concern, which is hard to measure, is the GC pressure added by the discarded byte array. Mike On Oct 19 2012, at 17:03 , Xueming Shen wrote: > > I see a 20% performance gain on server vm if switch to pure char[] based > encoding > and then use the sharedSecrets to avoid the

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-19 Thread Xueming Shen
I see a 20% performance gain on server vm if switch to pure char[] based encoding and then use the sharedSecrets to avoid the copy. The dis-advantage is (1) have to use the sharedSecrets and (2) can't share the same between the encode(byte[]) and encode(String). Anyway it appears to be an al

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-19 Thread Christian Thalinger
On Oct 19, 2012, at 10:42 AM, Mandy Chung wrote: > On 10/18/2012 6:11 PM, David Holmes wrote: >> Hi Martin, >> >> On 19/10/2012 10:58 AM, Martin Buchholz wrote: >>> http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java >>> >> >

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-19 Thread Mandy Chung
On 10/18/2012 6:11 PM, David Holmes wrote: Hi Martin, On 19/10/2012 10:58 AM, Martin Buchholz wrote: http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java That code uses runFinalization in places which means it is not exercisi

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-19 Thread Christian Thalinger
On Oct 18, 2012, at 6:11 PM, David Holmes wrote: > Hi Martin, > > On 19/10/2012 10:58 AM, Martin Buchholz wrote: >> http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java > > That code uses runFinalization in places which means it

Re: bug fix for native kerberos libraries

2012-10-19 Thread Christos Zoulas
On Oct 19, 9:11am, weijun.w...@oracle.com (Weijun Wang) wrote: -- Subject: Re: bug fix for native kerberos libraries | Hi Christos | | You mean the exception thrown in NativeGSSFactory.java lines 52-60? | | Vector creds = GSSUtil.searchSubject | (name, mech, initiate, GSSC

hg: jdk8/tl/jdk: 8000206: Uninitialized variable in PlainDatagramSocketImpl.c

2012-10-19 Thread chris . hegarty
Changeset: 27f854a1e5c5 Author:chegar Date: 2012-10-19 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27f854a1e5c5 8000206: Uninitialized variable in PlainDatagramSocketImpl.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/ja

Re: RFR: 6519127 : user.home property not set correctly

2012-10-19 Thread Alan Bateman
On 19/10/2012 10:11, Sean Chou wrote: Hi all, This is a fix for 651912. The fix removed the code to read user.home from registry and get profile directory instead of the parent of desktop directory. As suggested in http://blogs.msdn.com/b/oldnewthing/archive/2003/11/03/55532.aspx from the b

RFR: 6519127 : user.home property not set correctly

2012-10-19 Thread Sean Chou
Hi all, This is a fix for 651912. The fix removed the code to read user.home from registry and get profile directory instead of the parent of desktop directory. As suggested in http://blogs.msdn.com/b/oldnewthing/archive/2003/11/03/55532.aspx from the bug page. Bug: bugs.sun.com/bugdatabase/v