hg: jdk8/tl/langtools: 8003562: Provide a CLI tool to analyze class dependencies

2012-12-28 Thread mandy . chung
Changeset: 0c244701188e Author:mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtool

hg: jdk8/tl: 8003562: Provide a CLI tool to analyze class dependencies

2012-12-28 Thread mandy . chung
Changeset: c37401e77c80 Author:mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl

Re: RFR 2: JDK-8005263: Logging APIs takes Supplier for message

2012-12-28 Thread Henry Jen
On Dec 28, 2012, at 4:11 PM, Henry Jen wrote: > Next version I'll enable defer message construction until Logger filter check. > On a second thought and after more reading into logging code in JDK, it seems like Filter is mostly applied to Handler instead of Logger, thus it's not really that

hg: jdk8/tl/jdk: 2 new changesets

2012-12-28 Thread stuart . marks
Changeset: 0cfcba56cfa7 Author:jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.j

Re: RFR 2: JDK-8005263: Logging APIs takes Supplier for message

2012-12-28 Thread Henry Jen
Jason, If I understand you correctly, there are two main concerns, 1. You want to encourage MessageFormat style logging, consider the other way is an anti-pattern. 2. The construction of message could be further eliminated when a filter is involved. Here is what I thought, For 1, the new API

Re: RFR: 8005118: (str) Javadoc styles are inconsistent

2012-12-28 Thread Jim Gish
Thanks, Joe. Could you please submit for me? Jim On 12/28/2012 02:07 PM, Joe Darcy wrote: Looks fine; cheers, -Joe On 12/28/2012 7:19 AM, Jim Gish wrote: Please revieiw the following change (simple, non-functional, non-spec change to bring some consistency to the javadoc tags - using {@code

Re: RFR: 8005118: (str) Javadoc styles are inconsistent

2012-12-28 Thread Joe Darcy
Looks fine; cheers, -Joe On 12/28/2012 7:19 AM, Jim Gish wrote: Please revieiw the following change (simple, non-functional, non-spec change to bring some consistency to the javadoc tags - using {@code } where possible, etc.} http://cr.openjdk.java.net/~jgish/Bug8005118-String-spec-consisten

RFR: 8005118: (str) Javadoc styles are inconsistent

2012-12-28 Thread Jim Gish
Please revieiw the following change (simple, non-functional, non-spec change to bring some consistency to the javadoc tags - using {@code } where possible, etc.} http://cr.openjdk.java.net/~jgish/Bug8005118-String-spec-consistency/

RE: RFR 2: JDK-8005263: Logging APIs takes Supplier for message

2012-12-28 Thread Jason Mehrens
Henry, It is beautiful if that code lives only inside of the logger and the caller is unaware of its existence. Same is true for writing a guard statement. The formatter can not always achieve the same laziness. If I converted your example in the API docs to be passed in the params argument

hg: jdk8/tl/jdk: 8003265: Need to clone array of input/output parameters

2012-12-28 Thread xuelei . fan
Changeset: 4472a641b4dc Author:xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/s

hg: jdk8/tl/jdk: 7109274: Restrict the use of certificates with RSA keys less than 1024 bits

2012-12-28 Thread xuelei . fan
Changeset: 645d774b683a Author:xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.cert