Re: RMI java processes left running on JPRT systems

2013-01-02 Thread Stuart Marks
Hi Kelly, Thanks for mentioning this. I was able to track down a couple of the log files from the test runs that had started these processes, and it looks like the test is trying to tear things down, but it's failing, and these processes get left running. I've filed 8005646 to track this probl

Re: core-libs-dev Digest, Vol 68, Issue 113

2013-01-02 Thread Brian Burkhalter
Hello Tim, Thank you for the updates. We'll take a closer look at this as soon as practically feasible. I have only recently been transferred into the core-libs area and expect to be dealing with the learning curve for some time to come. Regards, Brian > Date: Sat, 29 Dec 2012 15:18:01 +0100

hg: jdk8/tl/jdk: 8005118: Javadoc styles are inconsistent

2013-01-02 Thread stuart . marks
Changeset: cc78ceb99284 Author:jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy ! src/share/classes/java/lang/Abstrac

Re: Request for Review: Java SE 8 Compact Profiles

2013-01-02 Thread Mandy Chung
Hi David, On 12/20/2012 10:18 PM, David Holmes wrote: jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ I reviewed the src/test changes in the jdk repo and have a few comments: Attributes.java: 568* {@code Name} object for {@code Profile} manifest attribute used 569*

Re: RFR 8005634: TEST_BUG tools/launcher/VersionCheck.java fails version check on jdeps

2013-01-02 Thread Mandy Chung
Chris, Looks good. I missed this test in my default jprt run and thanks for fixing it. Mandy On 1/2/2013 6:11 AM, Chris Hegarty wrote: The jdeps tools (recently added by 8003562) does not support '-version'. It uses the gnu-style '--version'. It should be excluded from VersionCheck.testTo

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-02 Thread Peter Levart
On 01/02/2013 10:20 AM, Alan Bateman wrote: On 01/01/2013 23:13, Eric McCorkle wrote: Was the original purpose security-oriented? It seemed to me that the purpose was to make performance pathologies less likely. Consider, for example, a bad hash function that maps ip addresses directly to th

Re: RFR 2: JDK-8005263: Logging APIs takes Supplier for message

2013-01-02 Thread David M. Lloyd
Being a devil's advocate here, I'd like to point out that the particular example given: >logger.log(level, () -> String.format(...)); is better done through an API like this one: logger.logf(level, fmt, ...); which would in fact allow for the possibility of localization (using the fo

RFR 8005634: TEST_BUG tools/launcher/VersionCheck.java fails version check on jdeps

2013-01-02 Thread Chris Hegarty
The jdeps tools (recently added by 8003562) does not support '-version'. It uses the gnu-style '--version'. It should be excluded from VersionCheck.testToolVersion(), similar to the (un)pack200 tool. Long term we may need to re-visit this test to add support for gnu-style option checking, but t

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-02 Thread Alan Bateman
On 01/01/2013 23:13, Eric McCorkle wrote: Was the original purpose security-oriented? It seemed to me that the purpose was to make performance pathologies less likely. Consider, for example, a bad hash function that maps ip addresses directly to their integer representation. If an applicatio