8006413: Add utility classes for writing better multiprocess tests in jtreg

2013-01-30 Thread Yekaterina Kantserova
Hi everyone, Christian Törnqvist has done a great job to make it easier to run multi-process tests in jtreg. His webrev (http://cr.openjdk.java.net/~ctornqvi/webrev/8006413/webrev.03/) is already approved and on the way into the hotspot repo. This webrev http://cr.openjdk.java.net/~ykantser/

Request for review: 8006757: Refactor Socket and File I/O tracing

2013-01-30 Thread Claes Redestad
Hi all, this is a refactoring of the I/O trace instrumentation that's going into JDK 7u14. The fix is only applicable to jdk7 since the corresponding code does not yet exist in jdk8. Bug: 8006757: Refactor Socket and File I/O tracing http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006757

Re: Request for review: 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86

2013-01-30 Thread Kirk Pepperdine
On 2013-01-23, at 1:14 AM, Vitaly Davidovich wrote: > Personally, optimizing for interpreter (or even C1) doesn't seem worth it. > If something's truly hot and best perf is desired then use C2 or tiered. If > the method isn't hot enough to trigger the C2 threshold, then why bother? > You're

Re: Parameter reflection: parameters with "" as their name

2013-01-30 Thread Alex Buckley
This is a design/spec question, so should be discussed on enhanced-metadata-spec-discuss, not core-libs-dev. Alex On 1/24/2013 11:33 AM, Eric McCorkle wrote: The current version of the spec for parameter reflection, found here: http://cr.openjdk.java.net/~abuckley/8misc.pdf states that if a

JEP for adding support for static JNI libraries

2013-01-30 Thread Bob Vandette
Please review this JEP I'd like to propose for Java SE 8. Bob Vandette Java SE Embedded Architect

Please review this JEP I'd like to propose for Java SE 8.

2013-01-30 Thread Bob Vandette
Resending, mailer stripped out my attachment. Please review this JEP I'd like to propose for Java SE 8. Bob Vandette Java SE Embedded Architect Title: Add support for static JNI libraries Author: Bob

Re: 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-01-30 Thread Weijun Wang
Just take a brief look at the codes. It seems the library can launch a Java process, wait for it to finish, and collect all the output (stdout and stderr). Is that all? I would be glad if it supports manipulating the stdin, i.e. simulating input to a process. For example, I sometimes need to s

Re: code review request: Test case for JDK-7042126 HashMap.clone() memory leak

2013-01-30 Thread Martin Buchholz
Consider importing the popular GcFinalization https://cs.corp.google.com/#google3/java/com/google/common/testing/GcFinalization.java&sq=package:google3%20-file:%5Eexperimental&q=gcfinalization&type=cs&l=61 as a testing utility for the jdk proper. On Wed, Jan 30, 2013 at 5:09 AM, Alan Bateman wrote

Re: 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-01-30 Thread Martin Buchholz
[ email address fail: jdk-core-libs-dev_ww_...@oracle.com] On Wed, Jan 30, 2013 at 12:36 PM, Martin Buchholz wrote: > I don't have time for a detailed review, but I have some high-level > comments. > > A lot of this is good functionality that should be provided in the jdk > proper, > notably gett

Re: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects

2013-01-30 Thread Kelly O'Hair
I don't use these netbeans projects, but the changes seem fine to me. The copyright on the new files says 2007, I assume they need to say 2013? -kto On Jan 30, 2013, at 12:24 PM, Mike Duigou wrote: > This issue still needs a reviewer. > > Mike > > On Jan 22 2013, at 13:27 , Mike Duigou wrote:

Re: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects

2013-01-30 Thread Mike Duigou
This issue still needs a reviewer. Mike On Jan 22 2013, at 13:27 , Mike Duigou wrote: > Hello all; > > This is a patch that has been lingering around in the lambda/lambda repo for > a long time. It adds minimal support for the MacOSX platform to the JDK > NetBeans projects. It could also be u

JDK 8 code review request for 8007115: Refactor regression tests for java.lang.reflect.Parameter

2013-01-30 Thread Joe Darcy
Hello, Please review my refactoring of a regression test for the java.lang.reflect.Parameter feature: 8007115: Refactor regression tests for java.lang.reflect.Parameter http://cr.openjdk.java.net/~darcy/8007115.0/ The new approach is to encode the expected information in annotations

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-30 Thread Mike Duigou
Good work Steven! Some initial comments; - The changes to Long should be in a separate issue. It's generally encouraged for changesets to focus on only one change. Sorry, yes, it's additional overhead. - I would like to see if performed of toString() can be improved further by using String(c

Re: RFR: 6471906 - NegativeArraySizeException in tenToThe()

2013-01-30 Thread Brian Burkhalter
OK, I shall label the issue accordingly. Thanks, Brian On Jan 30, 2013, at 10:58 AM, Joe Darcy wrote: > Looks fine. I think not have a regression test for this is okay since it > would take a relatively long time to run and use a significant amount of > memory.

Re: RFR: 6471906 - NegativeArraySizeException in tenToThe()

2013-01-30 Thread Joe Darcy
Hi Brian, Looks fine. I think not have a regression test for this is okay since it would take a relatively long time to run and use a significant amount of memory. Thanks, -Joe On 01/30/2013 10:34 AM, Brian Burkhalter wrote: Please review at your convenience. Issue: JDK-6471906 Assessm

RFR: 6471906 - NegativeArraySizeException in tenToThe()

2013-01-30 Thread Brian Burkhalter
Please review at your convenience. Issue: JDK-6471906 Assessment: The problem occurs because an attempt is made to allocate an array of length > Integer.MAX_VALUE. Proposed solution: --- a/src/share/classes/java/math/BigDecimal.java Fri Jan 25 12:25:10 2013 -0800 +++ b/src/share/class

hg: jdk8/tl/langtools: 8007034: debug printer for javac internals

2013-01-30 Thread jonathan . gibbons
Changeset: c924291865e5 Author:jjg Date: 2013-01-30 09:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c924291865e5 8007034: debug printer for javac internals Reviewed-by: mcimadamore + test/tools/javac/lib/DPrinter.java

hg: jdk8/tl/langtools: 8007096: DocLint parsing problems with some comments

2013-01-30 Thread jonathan . gibbons
Changeset: 950d8195a5a4 Author:jjg Date: 2013-01-30 09:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/950d8195a5a4 8007096: DocLint parsing problems with some comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! sr

Re: code review request: Test case for JDK-7042126 HashMap.clone() memory leak

2013-01-30 Thread David Buck
Hi Alan! Thank you for your help. TL;DR version: Strictly speaking (going only by the specifications), this could give us false positives, but I believe this is VERY unlikely to actually happen in real life. Long version: Yes, I gave this some thought myself. For example, on JRockit, if th

Re: code review request: Test case for JDK-7042126 HashMap.clone() memory leak

2013-01-30 Thread Alan Bateman
On 29/01/2013 23:36, David Buck wrote: Hi! This is a review request to add only the test case for the following OracleJDK issue : [ 7042126 : (alt-rt) HashMap.clone implementation should be re-examined ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7042126 * please note: I just marked

Re: Java 8 syntax change between b63 and b65

2013-01-30 Thread David Holmes
Hi Frank, Probably best to confirm this on lambda-dev but I suspect that default method support introduced a bug in b63 that was fixed by b65. David On 30/01/2013 12:06 PM, Frank Ding wrote: Hi guys, I noticed there is a change in Java 8 between b63 and b65. The change can be illustrated by