Changeset: de932285124c
Author:jjg
Date: 2013-02-05 21:55 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de932285124c
8007485: test creates .class files in the test/ directory
Reviewed-by: mcimadamore
! test/tools/javac/api/8007344/Test.java
Hi,
This is an update on previous reviewed version, there are two new method
introduced for Comparators to convert a Comparator into a BinaryOperator
and corresponding test cases.
As there is one new class, java.util.Comparators for 8001667, so we need
to have makefile change, thus involve build-
This changeset was committed on 1/31 despite a) having inaccurate
javadoc and b) reducing even further the clarity of a probably
unnecessary type in the java.lang hierarchy.
Again, I request that the nature of when core reflection throws
AnnotationFormatError be raised on enhanced-metadata-spe
Hi Chris,
I don't speak fluent sh but ...
204 # Terminate with exit 0 only if all subprocesses were successful
205 ec=0
206 if [ -d ${tmp} ]; then
207 for rc in `ls ${tmp}/*.pid.rc` ; do
I don't think you need to subshell an invocation of ls, simply do
for rc in "${tmp}/*.pid.rc" ; do
Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle:
I can change that text and will do so before i put back.
fine!
Have you observed internal review ID of 2426775?
I have not seen this come through as of yet but will let you know when I do.
It was from 16.01.2013 15:19 +0100
-Ulf
Hi Ulf,
On Feb 5, 2013, at 6:07 PM, Ulf Zibis wrote:
> Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle:
>> HI,
>>
>>
>> This is a review request for
>> http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to
>> SQLInput/Ouput (used for UDTs) to have generic methods for
Greetings:
I modified the code in
src/windows/native/java/io/WinNTFileSystem_md.c
so that it checks the return value of realloc() and frees memory when there is
an error.
The webrev image of this change is visible at:
http://cr.openjdk.java.net/~jzavgren/8007609/webrev.01/
Thanks!
John Zavgren
On 5 Feb 2013, at 22:34, Mike Duigou wrote:
> Looks fine to me.
+1, looks good to me too.
-Chris
>
> Mike
>
> On Feb 5 2013, at 14:16 , Joe Darcy wrote:
>
>> Hello,
>>
>> As a follow-up to adding the FunctionalInterface annotation type to the
>> platform, the time has come to annotate J
Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle:
HI,
This is a review request for
http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to
SQLInput/Ouput (used for UDTs) to have generic methods for types allowing
support for JSR 310.
Hi Lance,
I would set the exce
Looks fine to me.
Mike
On Feb 5 2013, at 14:16 , Joe Darcy wrote:
> Hello,
>
> As a follow-up to adding the FunctionalInterface annotation type to the
> platform, the time has come to annotate JDK classes with the annotation.
>
> I ran an annotation processor over the sources in the jdk repo
Changeset: 9ffcd758e2be
Author:jbachorik
Date: 2013-02-05 12:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ffcd758e2be
7170447: Intermittent DeadListenerTest.java failure
Summary: Due to asynchronous nature of processing server notifications it may
happen that an "unreg
Changeset: 3119f0ebb58d
Author:jbachorik
Date: 2013-02-05 12:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3119f0ebb58d
8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector
Reviewed-by: rbackman
! src/share/classes/com/sun/jmx/mbeanserver/Intros
Hello,
As a follow-up to adding the FunctionalInterface annotation type to the
platform, the time has come to annotate JDK classes with the annotation.
I ran an annotation processor over the sources in the jdk repo to look
for candidates to be marked as FunctionalInterfaces and for a first cu
Clarification here: the issue's title is a bit more narrow than the
scope of the fix. It addresses some javadoc comments and handling of
nameless parameters as well.
On 02/05/13 14:58, Eric McCorkle wrote:
> Hello, please review this patch, which implements some spec changes for
> parameter refle
On Feb 4 2013, at 08:33 , Alan Bateman wrote:
> On 04/02/2013 16:02, Mike Duigou wrote:
>> :
>>> If so then I think we have to careful because -concurrency means a lot of
>>> virtual memory and I'm not convinced that we limit it via -vmoption in
>>> jdk/test/Makefile
>>> I could see us wanting
Hello, please review this patch, which implements some spec changes for
parameter reflection in the java.lang.reflect API.
This patch changes the SYNTHESIZED flag to MANDATED, and changes the
associated methods. It also updates some javadoc comments.
The webrev is here:
http://cr.openjdk.java.ne
Maybe comparing Files.getAttribute(p, "unix:uid") and
UnixSystem().getUid()? Is there a cross-platform way?
I noticed Files.getOwner(), but seems UserPrincipal has no method of its
own and all its implementation classes are non public.
Thanks
Max
Changeset: f0ad3747b40e
Author:emc
Date: 2013-02-05 14:56 +
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f0ad3747b40e
8007389: Remove uses of _ as identifier in jaxp
Reviewed-by: lancea, joehw
! src/javax/xml/validation/SchemaFactoryFinder.java
! src/javax/xml/xpath/XPathFa
HI,
This is a review request for
http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to
SQLInput/Ouput (used for UDTs) to have generic methods for types allowing
support for JSR 310.
Also now that 310 is in M6, update Types and JDBCType to add entries for
TIME/TIMESTAMP
Changeset: e526277b51be
Author:vinnie
Date: 2013-02-05 14:25 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e526277b51be
8007483: attributes are ignored when loading keys from a PKCS12 keystore
Reviewed-by: mullan
! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java
!
On 02/05/2013 06:21 AM, David Holmes wrote:
Chris,
When these failures occur does the failure get reflected in an error
exit code?
Not currently, good point.
I'm seeing hudson builds merilly buildinh OpenJDK instead of Oracle JDK
because the closed repos were skipped due to this bug :(
Thi
On 05/02/2013 10:51, Yekaterina Kantserova wrote:
On 02/04/2013 02:18 PM, Alan Bateman wrote:
On 04/02/2013 11:03, Yekaterina Kantserova wrote:
But JDKToolFinder.getJDKTool is used even for finding java, e.g. I
need to fork a java process - JDKToolFinder.getJDKTool("java") for
some JRE tests
On 02/04/2013 02:18 PM, Alan Bateman wrote:
On 04/02/2013 11:03, Yekaterina Kantserova wrote:
But JDKToolFinder.getJDKTool is used even for finding java, e.g. I
need to fork a java process - JDKToolFinder.getJDKTool("java") for
some JRE tests?
It might be better to rename JDKToolFinder to som
On 05/02/2013 08:57, Tom Schindl wrote:
Is this available in any Java8 build? I think the VerifyError is what I
see when running Eclipse on Java8 [1]
Tom
[1]https://bugs.eclipse.org/bugs/show_bug.cgi?id=399801
Not yet, Bharadwaj has the VM support in hotspot-rt/hotspot and I
believe plans to
On Feb 5, 2013, at 1:05 AM, Joseph Darcy wrote:
>
> On 2/4/2013 1:36 PM, Stephen Colebourne wrote:
>> On 4 February 2013 19:31, Joe Darcy wrote:
>>> The stripTrailingZeros method has acted in this surprising way since the
>>> IBM-led JSR 13 was integrated into the platform back in JDK 5, which s
Is this available in any Java8 build? I think the VerifyError is what I
see when running Eclipse on Java8 [1]
Tom
[1]https://bugs.eclipse.org/bugs/show_bug.cgi?id=399801
Am 18.01.13 18:45, schrieb Bharadwaj Yadavalli:
>
> Thanks for the review, Karen.
>
> On 1/18/2013 10:15 AM, Karen Kinnear w
26 matches
Mail list logo
