Changeset: 1f84c84f8e1a
Author:katleman
Date: 2013-02-14 11:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f84c84f8e1a
Added tag jdk8-b77 for changeset cdb46031e718
! .hgtags
Changeset: 1a0174612b49
Author:amurillo
Date: 2013-02-08 08:16 -0800
URL: ht
Changeset: 45d6d221
Author:katleman
Date: 2013-02-14 11:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/45d6d221
Added tag jdk8-b77 for changeset 3933eebc659d
! .hgtags
Changeset: bbb7548d45c7
Author:lana
Date: 2013-02-14 22:11 -0800
URL: http://hg.open
Changeset: bc24411bcc37
Author:katleman
Date: 2013-02-14 11:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc24411bcc37
Added tag jdk8-b77 for changeset 89c664151689
! .hgtags
Changeset: a3aa32fe4536
Author:lana
Date: 2013-02-14 22:11 -0800
URL: http
Changeset: 391de4c992d1
Author:katleman
Date: 2013-02-14 11:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/391de4c992d1
Added tag jdk8-b77 for changeset 64dfba1bad16
! .hgtags
Changeset: 00958c5a7070
Author:katleman
Date: 2013-02-14 11:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/00958c5a7070
Added tag jdk8-b77 for changeset 573e789c187a
! .hgtags
Changeset: 27d6368ae8ba
Author:katleman
Date: 2013-02-14 11:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/27d6368ae8ba
Added tag jdk8-b77 for changeset 35684a40c584
! .hgtags
Changeset: c528d8ce83f1
Author:lana
Date: 2013-02-19 20:48 -0800
URL: http://h
On Feb 19 2013, at 19:37 , David Holmes wrote:
> On 20/02/2013 6:22 AM, Mike Duigou wrote:
>> Thank you for the feedback David.
>
> So what got updated, if anything, before the push?
Everything. With the exception of the > which I mentioned in my response I
accepted all of your feedback sugges
On 20/02/2013 6:22 AM, Mike Duigou wrote:
Thank you for the feedback David.
So what got updated, if anything, before the push?
The biggest gripe I have with reviewing all this stuff is being able to
keep track of what comments have been made, what comments have been
acted upon and what is st
On 20/02/2013 12:39 AM, Chris Hegarty wrote:
On 02/19/2013 05:29 AM, David Holmes wrote:
...
Aside: it would be much easier to maintain consistent style if we used a
"template" to define the main outline of each family of interfaces and
generated the specializations from that (similar to how we
In my case, I am planning to do an expunge when there are more old
entries than new entries (or plus a constant), so the "head" and "tail"
are likely of the same size.
I'll think about creating my own LinkedList. It will be nice to just
"break" at one link.
Thanks
Max
On 2/19/13 8:36 PM, P
Changeset: 9345394ac8fe
Author:ksrini
Date: 2013-02-19 17:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9345394ac8fe
8006948: Update javac for MethodParameters format change
Reviewed-by: ksrini, forax
Contributed-by: eric.mccor...@oracle.com
! src/share/classes/com
Changeset: ec1a79c3a99c
Author:ksrini
Date: 2013-02-19 16:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec1a79c3a99c
8008262: pack200 should support MethodParameters - part 2
Reviewed-by: jrose
! src/share/classes/com/sun/java/util/jar/pack/Attribute.java
! src/share/cla
I couldn't find a 'jdk' repo relevant bug for this issue so I filed:
8008509: 6588413 changed JNIEXPORT visibility for GCC on HSX, jdk's
jni_md.h needs similar change
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008509
https://jbs.oracle.com/bugs/browse/JDK-8008509
On 02/19/2013 10:35 PM, Zhong Yu wrote:
I think it's really easy for users to write a SubSequence by
themselves if they need to solve the problem; there is no need for
String to do it, and definitely not at the expense of breaching
previous explicit contracts. We should solve this problem extern
Thanks Alan.
cc'ing build-dev as this is technically build related and going into
jdk8/build.
David
On 20/02/2013 7:04 AM, Alan Bateman wrote:
On 19/02/2013 20:37, David Holmes wrote:
:
+
+# JFR traces even in builds with JFR disabled
+com.oracle.jrockit.jfr.FlightRecorder:
com.sun.manageme
On 02/19/2013 07:40 PM, Joe Darcy wrote:
On 02/19/2013 07:14 AM, Chris Hegarty wrote:
On 02/19/2013 03:08 PM, Alan Bateman wrote:
On 19/02/2013 14:39, Chris Hegarty wrote:
:
Oh, please god no! I find the way the buffer classes are generated a
real pain. Yes, it is good for maintaining consist
On Tue, Feb 19, 2013 at 2:45 PM, Ben Evans
wrote:
> Hi,
>
> I've got my regex point lambdafication patch going against the current
> state of lambda, but now I have an API question I'd like some feedback
> on.
>
> (Btw, if this is more appropriate for core-libs just let me know, and
> I'll take my
I think it's really easy for users to write a SubSequence by
themselves if they need to solve the problem; there is no need for
String to do it, and definitely not at the expense of breaching
previous explicit contracts. We should solve this problem externally,
explicitly; not internally with some
On 19 Feb 2013, at 18:35, Alan Bateman wrote:
> On 19/02/2013 17:48, Martin Buchholz wrote:
>> :
>>
>> Taking a look at this, I don't see any reason why we can't simply do
>> (while maintaining serialization compatibility):
> Right, it's not needed and I think we had Chris persuaded on this a f
On 19/02/2013 20:37, David Holmes wrote:
:
+
+# JFR traces even in builds with JFR disabled
+com.oracle.jrockit.jfr.FlightRecorder:
com.sun.management.MissionControl, compact3
+com.oracle.jrockit.jfr.management.FlightRecorderMBean:
com.sun.management.MissionControl, compact3
+
This looks fine
The new jar dependency analyzer detects unsatisfied dependencies in a
profile build with JFR disabled:
Analyzing
/export/users/dh198349/jdk8-build/build/b77c/linux-i586-ea/images/j2re-compact3-image/lib/management-agent.jar
Analyzing
/export/users/dh198349/jdk8-build/build/b77c/linux-i586-ea/i
Changeset: 267bca6af07e
Author:jzavgren
Date: 2013-02-19 15:31 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/267bca6af07e
8008107: [parfait] Use after free of pointer in
jdk/src/share/native/sun/security/pkcs11/wrapper/p11_convert.c
Reviewed-by: mullan, chegar
! src/share/
Thank you for the feedback David.
On Feb 18 2013, at 21:29 , David Holmes wrote:
> package-info.java
>
> I've flagged this elsewhere but you may not have seen it:
>
> + * Predicate
>
> If we use < then we should also use >.
It's not required to use > in HTML 4.01 transitional or
Since the proposed change is user-visible (i.e., not just for building the
JDK, but also for building pretty much every JNI blob in existence),
wouldn't you want the correct check anyway? Does the JDK have rules about
which version of gcc you are allowed to use to build JNI?
Jeremy
On Mon, Feb
Changeset: 16efb7ba188f
Author:mduigou
Date: 2013-02-19 11:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16efb7ba188f
8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two
Am 19.02.2013 20:00, schrieb Mike Duigou:
If I update this patch I will add Ulf suggestion of adding AbstractStringBuilder as a third
instanceof case. Mike
Thanks!
I'm stil wondering, why HotSpot doesn't optimize
for (int i = start, j = count; i < end; i++, j++) {
v
On Feb 19 2013, at 10:50 , Alan Bateman wrote:
> On 19/02/2013 05:27, Mike Duigou wrote:
>> :
>>
>> http://cr.openjdk.java.net/~mduigou/JDK-7197183/0/
>>
>> From our current testing we found that applications currently using
>> subSequence() failed if the equals(), hashCode() and toString()
>
On 19/02/2013 05:27, Mike Duigou wrote:
:
http://cr.openjdk.java.net/~mduigou/JDK-7197183/0/
From our current testing we found that applications currently using subSequence() failed
if the equals(), hashCode() and toString() implementations did not exactly match String.
Additionally we had t
Woohoo -- 23 shell tests replaced with equivalent Java code: that's over
2/3 of the shell tests in langtools/test.
-- Jon
On 02/19/2013 09:54 AM, vicente.rom...@oracle.com wrote:
Changeset: dc8b7aa7cef3
Author:vromero
Date: 2013-02-19 17:53 +
URL: http://hg.openjdk.java.net/
On 02/19/2013 07:14 AM, Chris Hegarty wrote:
On 02/19/2013 03:08 PM, Alan Bateman wrote:
On 19/02/2013 14:39, Chris Hegarty wrote:
:
Oh, please god no! I find the way the buffer classes are generated a
real pain. Yes, it is good for maintaining consistency across similar
versions, but I don't
Changeset: af396ec087f4
Author:naoto
Date: 2013-02-19 10:34 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af396ec087f4
7092447: Clarify the default locale used in each locale sensitive operation
Reviewed-by: okutsu
! src/share/classes/java/text/DateFormat.java
! src/share/c
On 19/02/2013 17:48, Martin Buchholz wrote:
:
Taking a look at this, I don't see any reason why we can't simply do
(while maintaining serialization compatibility):
Right, it's not needed and I think we had Chris persuaded on this a few
weeks ago. It does change the serialized form but that it's
On Wed, Jan 16, 2013 at 7:01 AM, Chris Hegarty wrote:
> Thanks to all for the reviews and suggestions here. As you probably seen,
> I pushed these changes to jdk8/tl earlier today (sorry, I missed Alan as an
> official reviewer on the changeset.). Consider it an initial version,
> pending any outc
Changeset: e20c1c9197bf
Author:emc
Date: 2013-02-19 17:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e20c1c9197bf
8008312: Re-enable MethodParameter tests in JDK
Reviewed-by: darcy
! src/share/classes/java/lang/reflect/Parameter.java
! test/java/lang/reflect/Parameter/Wi
Changeset: 824187de1591
Author:jzavgren
Date: 2013-02-19 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/824187de1591
8007609: WinNTFileSystem_md.c should correctly check value returned from realloc
Reviewed-by: alanb, chegar, dholmes
! src/windows/native/java/io/WinNTF
On 13/02/2013 09:47, Yekaterina Kantserova wrote:
Hi everyone,
This small fixconcerns jdk.testlibrary.JdkFinder utility class. The
check below is too OS dependent and should be deleted.
...
binPath += File.separatorChar + "bin" + File.separatorChar +
executable;
File toolFile
Hi,
fyi. Let me know if you have any comments, the change is simple, the flag
is being changed from a u4 to a u2.
This has already been reviewed by jrose.
http://cr.openjdk.java.net/~ksrini/8008262/webrev.jdk.0/
Thanks
Kumar
On 19/02/2013 01:54, David Holmes wrote:
The implementation support for the Reference Implementation of the SE
Compact Profiles described by:
http://openjdk.java.net/jeps/161
has now been pushed to the jdk8/build forest ready for integration
with jdk8/jdk8 in time for b78.
This reference im
Mike,
Thanks for updating the j.u.c classes. David seems to have covered most
of the issues, otherwise looks fine to me.
On 02/19/2013 05:29 AM, David Holmes wrote:
...
package-info.java
I've flagged this elsewhere but you may not have seen it:
+ * Predicate
If we use < then we
On 02/19/2013 03:08 PM, Alan Bateman wrote:
On 19/02/2013 14:39, Chris Hegarty wrote:
:
Oh, please god no! I find the way the buffer classes are generated a
real pain. Yes, it is good for maintaining consistency across similar
versions, but I don't see that as a good justification to introduce
On 19/02/2013 14:39, Chris Hegarty wrote:
:
Oh, please god no! I find the way the buffer classes are generated a
real pain. Yes, it is good for maintaining consistency across similar
versions, but I don't see that as a good justification to introduce
this complexity. I was secretly hoping tha
Am 19.02.2013 06:27, schrieb Mike Duigou:
http://cr.openjdk.java.net/~mduigou/JDK-7197183/0/
I think, you should add
|| (s instanceof AbstractStringBuilder)
as third in
else if ((s instanceof StringBuilder) || (s instanceof StringBuffer)) {
, as someone could use his own subclass of Abs
On 02/19/2013 05:29 AM, David Holmes wrote:
...
Aside: it would be much easier to maintain consistent style if we used a
"template" to define the main outline of each family of interfaces and
generated the specializations from that (similar to how we generate the
various bytebuffer classes).
O
Hi Mike,
I agree with Peter,
a new method is better than changing subSequence to return a
CharSequence implementation that try to fake itself as a String.
And as a guys that have written several parsers (for HTTP servers or not),
ByteBuffer/CharBuffer was introduced in 1.4 to write effective pa
Changeset: 885bb24f6018
Author:coffeys
Date: 2013-02-19 14:07 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/885bb24f6018
7197187: Currency.isPastCutoverDate should be made more robust
Reviewed-by: alanb
! src/share/classes/java/util/Currency.java
Changeset: 01b6b0dd2006
Au
HI Joe,
These look fine.
I'd have been happy to fix these as ongoing ThreeTen work.
We'll need to be more careful merging now that changes will be coming
from other
than the Threeten project.
Thanks, Roger
On 2/19/13 1:58 AM, Joe Darcy wrote:
Hello,
Please review these two simple fixes fo
On 19 February 2013 10:27, Weijun Wang wrote:
> I'm using LinkedList to maintain a history
Don't use LinkedList. Multiple benchmarks down the years have shown it
is almost always worse than ArrayList.
Stephen
> and the elements are ordered by
> their timestamps. Every now and then I would "exp
On 02/19/2013 01:24 PM, Peter Levart wrote:
On 02/19/2013 11:38 AM, Daniel Fuchs wrote:
On 2/19/13 11:27 AM, Weijun Wang wrote:
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every now and then I would "expunge" the list,
that
is to say, i
On 02/19/2013 11:38 AM, Daniel Fuchs wrote:
On 2/19/13 11:27 AM, Weijun Wang wrote:
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every now and then I would "expunge" the list, that
is to say, iterating through the list and when an element i
Hey Kasper!
You're right that there are methods that throw exceptions as a part of
the normal program flow.
However, this number can be (and has been) used as a very high level
telemetry for an application. Depending on exactly how large this number
is, and how fast it is growing, something
On 19 February 2013 06:58, Joe Darcy wrote:
> diff -r bcde0486261e
> src/share/classes/java/time/format/DateTimeFormatterBuilder.java
> --- a/src/share/classes/java/time/format/DateTimeFormatterBuilder.java Mon
> Feb 18 08:14:18 2013 +
> +++ b/src/share/classes/java/time/format/DateTimeFormatt
On 2/19/13 11:27 AM, Weijun Wang wrote:
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every now and then I would "expunge" the list, that
is to say, iterating through the list and when an element is old enough
all elements after (and includin
Hi All
I'm using LinkedList to maintain a history and the elements are ordered
by their timestamps. Every now and then I would "expunge" the list, that
is to say, iterating through the list and when an element is old enough
all elements after (and including) it will be removed. Currently I'm
On 19/02/2013 06:58, Joe Darcy wrote:
Hello,
Please review these two simple fixes for javadoc warnings I noticed
during a build (I'll file a bug after getting a review):
Looks okay to me too, we seem to have picked up several javadoc warnings
recently.
-Alan
Hi Mike,
Regarding the implementation details: I think it would be better to
reference just the String's value[] array in the String.SubSequence
instead of the String instance itself. Two reasons come to mind:
- eliminate another indirection when accessing the array
- when referencing the Str
Changeset: ecc8fda8f187
Author:darcy
Date: 2013-02-19 00:24 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ecc8fda8f187
8008435: Fix new build to include jdk.Supported in ct.sym
Reviewed-by: erikj
! common/makefiles/javadoc/NON_CORE_PKGS.gmk
Changeset: 49b3d8efd30a
Author:darcy
Date: 2013-02-19 00:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49b3d8efd30a
8008434: Misc javadoc warning fixes in DateTimeFormatterBuilder and TimeZone
Reviewed-by: mduigou, okutsu
! src/share/classes/java/time/format/DateTimeForm
57 matches
Mail list logo