On 27/02/2013 12:31 PM, Dan Xu wrote:
Thank you, Mike.
The reason not to throw out an exception is for the backward
compatibility. Due to that, the constructorof File object with NUL
willnever fail.While in NIO, it is defined in the spec to throw out
exceptions when invalid NUL character is foun
Thank you, Mike.
The reason not to throw out an exception is for the backward
compatibility. Due to that, the constructorof File object with NUL
willnever fail.While in NIO, it is defined in the spec to throw out
exceptions when invalid NUL character is found.
-Dan
On 02/26/2013 04:33 PM,
Filenames are a lot like environment variables, and we already have code
that rejects NUL chars in environment variable names:
// Check that name is suitable for insertion into Environment map
private static void validateVariable(String name) {
if (name.indexOf('=') != -1 ||
Changeset: d623f520557b
Author:darcy
Date: 2013-02-26 17:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d623f520557b
8008279: Remove InvalidContainerAnnotationError.java
Reviewed-by: jfranck
- src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java
! s
Changeset: 543be9488e50
Author:darcy
Date: 2013-02-26 17:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/543be9488e50
8009102: Several docs warnings in Project Lambda APIs
Reviewed-by: mduigou
! src/share/classes/java/lang/invoke/LambdaMetafactory.java
! src/share/classes/
Hi Dan;
External link to the bug (will hopefully work soon):
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003992
I would like to better understand why silently removing the garbage null
characters is the right answer here.
If null is an invalid character for the underlying operating syst
Hi All,
Please help review the fix for JDK-8003992: File and other classes in
java.io do not handle embedded nulls properly.
Java IO, not like NIO, does not check NUL character in the given file
path name, which brings confusion to Java users. This fix is going to
address this issue by remov
The look fine to me. The same fixes ToDoubleBiFunction.java and
BinaryOperator.java have been applied in the lambda repository.
Mike
On Feb 26 2013, at 15:38 , Joe Darcy wrote:
> Hello,
>
> Please review the patch before the fix some docs build warnings. I'll file a
> bug once the review is c
Hello,
Please review the patch before the fix some docs build warnings. I'll
file a bug once the review is complete, etc.
Thanks,
-Joe
diff -r ecd33c6ab12f
src/share/classes/java/lang/invoke/LambdaMetafactory.java
--- a/src/share/classes/java/lang/invoke/LambdaMetafactory.java Tue Feb
26 2
Changeset: ecd33c6ab12f
Author:alanb
Date: 2013-02-26 22:39 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecd33c6ab12f
8009029: SunEC provider classes ending up in rt.jar after Nashorn build changes
Reviewed-by: mduigou
! makefiles/CreateJars.gmk
Changeset: 5ebc62421717
Author:rfield
Date: 2013-02-26 10:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ebc62421717
8008770: SerializedLambda incorrect class loader for lambda deserializing class
Summary: current thread's context ClassLoader was used to load class by nam
Changeset: 1654918e0612
Author:attila
Date: 2013-02-25 16:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1654918e0612
8006984: Introducing local into a function inside with statement confuses its
scope
Reviewed-by: jlaskey, lagergren, sundar
! src/jdk/nashorn/interna
On Feb 26, 2013, at 2:50 PM, Remi Forax wrote:
> On 02/25/2013 06:31 PM, Paul Sandoz wrote:
>> Hi Remi,
>>
>> Thanks for the feedback i have addressed some of this, mostly related to
>> inner classes, in following change set to the lambda repo:
>>
>> http://hg.openjdk.java.net/lambda/lambda/j
> Just to be clear, what I was trying to say that this review is just to
> add the counter, and the discussion on how and when to access it is
> something that I'd much rather have in context of a review of that code...
Then the counter name should not bind you to how it is counting. +1 for
'sun
Changeset: 022cd5adc0fa
Author:alanb
Date: 2013-02-26 14:16 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/022cd5adc0fa
8008977: profiles build broken by Nashorn build changes
Reviewed-by: chegar
! makefiles/profile-rtjar-includes.txt
Changeset: e065107437b9
Author:alanb
Date: 2013-02-26 14:08 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/e065107437b9
8008978: nashorn-rules.gmk missing
Reviewed-by: alanb
Contributed-by: erik.joels...@oracle.com, james.las...@oracle.com
+ make/nashorn-rules.gmk
On 02/25/2013 06:31 PM, Paul Sandoz wrote:
Hi Remi,
Thanks for the feedback i have addressed some of this, mostly related to inner
classes, in following change set to the lambda repo:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/3e50294c68ea
We can update the webrev next week.
There a
On 02/26/2013 02:11 PM, Paul Sandoz wrote:
On Feb 25, 2013, at 10:45 PM, David Holmes wrote:
On 26/02/2013 3:31 AM, Paul Sandoz wrote:
Hi Remi,
Thanks for the feedback i have addressed some of this, mostly related to
inner classes, in following change set to the lambda repo:
http://hg.openj
On Feb 25, 2013, at 10:45 PM, David Holmes wrote:
> On 26/02/2013 3:31 AM, Paul Sandoz wrote:
>> Hi Remi,
>>
>> Thanks for the feedback i have addressed some of this, mostly related to
>> inner classes, in following change set to the lambda repo:
>>
>> http://hg.openjdk.java.net/lambda/lambda/
Changeset: bc92e4b044e2
Author:kmo
Date: 2013-02-26 11:05 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc92e4b044e2
7087570: java.lang.invoke.MemberName information wrong for method handles
created with findConstructor
Summary: REF_invokeSpecial DMHs (which are unusual) ge
On 02/26/2013 12:18 AM, Mandy Chung wrote:
On 2/25/2013 8:30 AM, Nils Loodin wrote:
I changed it to
sun.throwables.numThrowables
in http://cr.openjdk.java.net/~nloodin/8007806/webrev.01/
Is this better? However, bear in mind that it's not exactly specified
where this is going to be incremente
21 matches
Mail list logo
