hg: jdk8/tl/jdk: 8006818: SunEC and SunPKCS11 providers should be in all profiles

2013-03-20 Thread david . holmes
Changeset: 3c1a4966d901 Author:dholmes Date: 2013-03-20 22:39 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1a4966d901 8006818: SunEC and SunPKCS11 providers should be in all profiles Reviewed-by: dholmes, alanb, valeriep Contributed-by: Jen Dority ! makefiles/profile-in

Re: Please review: surrogate fiddle

2013-03-20 Thread Martin Buchholz
On Mon, Mar 18, 2013 at 11:10 PM, Masayoshi Okutsu < masayoshi.oku...@oracle.com> wrote: > On 3/19/2013 3:04 PM, Martin Buchholz wrote: > > > On Mon, Mar 18, 2013 at 7:44 PM, Masayoshi Okutsu < > masayoshi.oku...@oracle.com> wrote: > >> As for duplicating code, I originally duplicated similar cod

hg: jdk8/tl/langtools: 8010364: Clarify javax.lang.model API for Type Annotations

2013-03-20 Thread joe . darcy
Changeset: 972474640b7d Author:darcy Date: 2013-03-20 17:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/972474640b7d 8010364: Clarify javax.lang.model API for Type Annotations Reviewed-by: jjg, abuckley ! src/share/classes/javax/lang/model/AnnotatedConstruct.java !

Re: RFR-8008118

2013-03-20 Thread Martin Buchholz
On Wed, Mar 20, 2013 at 4:23 PM, Chris Hegarty wrote: > Martin, > > I take your point about the other allocations, but as you say OOM is > better than SEGV. So possibly good enough? > > Ah, Thanks Chris, I had forgotten that NEW *does* throw OOME. > If NEW returns NULL, then there will be a pend

Re: RFR-8008118

2013-03-20 Thread Chris Hegarty
Martin, I take your point about the other allocations, but as you say OOM is better than SEGV. So possibly good enough? If NEW returns NULL, then there will be a pending OOM on the stack. -Chris On 20 Mar 2013, at 23:12, Martin Buchholz wrote: > Hi John, > > I wrote this code originally IIR

Re: Please review: surrogate fiddle

2013-03-20 Thread Martin Buchholz
On Wed, Mar 20, 2013 at 7:09 AM, Ulf Zibis wrote: > Hi Martin, > > nice to see you again on board. > > Hi Ulf! > Am 19.03.2013 20:18, schrieb Martin Buchholz: > >> Thanks! Webrev updated. >> > > Character: > Maybe I'm blind, is there any semantical difference between > char c1 = seq.ch

Re: RFR-8008118

2013-03-20 Thread Martin Buchholz
Hi John, I wrote this code originally IIRC. You are correct that the existing code does not check these allocations for failure. In practice, it will be very rare for the failure to be seen, since the allocations are likely to be small and only occur during program startup. I commend you for tr

Re: RFR (S) CR 8006627/8007398: Improve performance of Long.toUnsignedString0, Integer.toUnsignedString0, UUID(String) and UUID.toString

2013-03-20 Thread Mike Duigou
Hi Steven; I haven't forgotten and it's still in my queue for Java 8. I haven't had time to respond to Martin Buchholz's feedback. http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014528.html I suspect he is right about computing digits vs the table being a better choice but

Re: RFR (S) CR 8006627/8007398: Improve performance of Long.toUnsignedString0, Integer.toUnsignedString0, UUID(String) and UUID.toString

2013-03-20 Thread Steven Schlansker
On Feb 13, 2013, at 2:45 PM, Mike Duigou wrote: > I have updated the patch with some of Ulf's feedback and corrected one > cut-and-paste error that I made. > > The updated webrev is at: > > http://cr.openjdk.java.net/~mduigou/JDK-8006627/2/webrev/ > One last ping to make sure this doesn't s

Re: PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

2013-03-20 Thread Jim Gish
Hi Laurent, If you'd like to submit an improved patch, I'll take a look. The best way to do this is to post a webrev: http://openjdk.java.net/guide/webrevHelp.html Looking forward to your participation and contributions. Welcome! Thanks, Jim Gish On 03/20/2013 08:45 AM, Laurent Bourgès

Re: PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

2013-03-20 Thread Mandy Chung
Hi Laurent, Thank you for signing the OCA. Your contribution is very welcome. You can submit a patch for this bug (see [1]) to Core libraries group which owns logging. Jim Gish and I will sponsor it. Thanks Mandy [1] http://openjdk.java.net/contribute/ On 3/20/2013 5:45 AM, Laurent Bourgès

hg: jdk8/tl/jdk: 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration

2013-03-20 Thread mandy . chung
Changeset: ccd9f53377c4 Author:mchung Date: 2013-03-20 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccd9f53377c4 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration Reviewed-by: alanb ! test/java/util/logging/CustomLogManage

hg: jdk8/tl/jdk: 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe

2013-03-20 Thread chris . hegarty
Changeset: 3070b7363853 Author:chegar Date: 2013-03-20 14:39 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3070b7363853 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe Reviewed-by: khazra, alanb ! src/share/classes/sun/net/www/protocol

Re: RFR-8008118

2013-03-20 Thread Alan Bateman
On 20/03/2013 15:22, John Zavgren wrote: Greetings: Please consider the following fix for a minor memory issue that I found in the file: src/solaris/native/java/lang/UNIXProcess_md.c. http://cr.openjdk.java.net/~jzavgren/8008118/webrev.01/ Thanks! John Zavgren If there is a chance that we wil

RFR JDK-8003245

2013-03-20 Thread John Zavgren
Greetings: Please consider the following changes that eliminate the use of uninitialized memory. http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ Thanks! John

Re: RFR-8008118

2013-03-20 Thread Chris Hegarty
Looks good to me John. Minor style issue, should be a space after the if, 'if_()" -Chris. On 20/03/2013 15:22, John Zavgren wrote: Greetings: Please consider the following fix for a minor memory issue that I found in the file: src/solaris/native/java/lang/UNIXProcess_md.c. http://cr.ope

RFR-8008118

2013-03-20 Thread John Zavgren
Greetings: Please consider the following fix for a minor memory issue that I found in the file: src/solaris/native/java/lang/UNIXProcess_md.c. http://cr.openjdk.java.net/~jzavgren/8008118/webrev.01/ Thanks! John Zavgren

Re: Please review: surrogate fiddle

2013-03-20 Thread Alexander Zuev
Hi Ulf, please see my comments inline. On 3/20/13 18:09, Ulf Zibis wrote: Hi Martin, nice to see you again on board. Am 19.03.2013 20:18, schrieb Martin Buchholz: Thanks! Webrev updated. Character: Maybe I'm blind, is there any semantical difference between char c1 = seq.charAt(in

Re: Review request: 8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration

2013-03-20 Thread Alan Bateman
On 19/03/2013 21:51, Mandy Chung wrote: Simple update of a logging test to include test cases for the ".useParentHandlers" property set in the logging configuration. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8006104/webrev.00/ It's good to expand the test coverage, this loo

Re: Please review: surrogate fiddle

2013-03-20 Thread Ulf Zibis
Hi Martin, nice to see you again on board. Am 19.03.2013 20:18, schrieb Martin Buchholz: Thanks! Webrev updated. Character: Maybe I'm blind, is there any semantical difference between char c1 = seq.charAt(index++); if (isHighSurrogate(c1)) { if (index < seq.length

Re: PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

2013-03-20 Thread Laurent Bourgès
Hi mandy, Do you want me to propose an improved patch to remove the former Map and fix the getLevel() method ? or you prefer fix on your own ? Is it better to discuss the fix on the bug database (still not visible) ? Laurent 2013/3/19 Mandy Chung > Hi Laurent, > > Thanks for the contribution

Re: PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

2013-03-20 Thread Alan Bateman
On 19/03/2013 12:19, Laurent Bourgès wrote: Dear all, I run recently netbeans profiler on my swing application (Aspro2: http://www.jmmc.fr/aspro) under linux x64 platform and figured out a performance and waste issue related to PlatformLogger. Actually, the JavaLogger implementation uses a Map

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-20 Thread Peter Levart
Hi, If I understand correctly, sun.reflect.Reflection.getCallerClass(int) will not be usable by non-system code any more. I know it's not a public API, but it's useful in some situations (not security-related) and there's no public API for that functionality. Is there a reason to not "unoffi

hg: jdk8/tl/jdk: 8006193: (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public

2013-03-20 Thread alexey . utkin
Changeset: fb23896a01f5 Author:uta Date: 2013-03-20 13:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb23896a01f5 8006193: (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public Reviewed-by: alanb ! src/windows/classes/java/lang/ProcessImpl.java