Hi Eric,
Thanks for fixing the test failures. I recently reviewed your changes.
And I like your idea to add a base dir to restrict the test only
touching files/directories that are created by itself to avoid the
interferences from the OS or other test activities.
And in Line 341 of General.j
On 4/16/2013 7:18 AM, Peter Levart wrote:
Hi Mandy,
I prepared a preview variant of j.l.r.Proxy using WeakCache (turned
into an interface and a special FlattenedWeakCache implementation in
anticipation to create another variant using two-levels of
ConcurrentHashMaps for backing storage, but w
Changeset: 222a72df2f42
Author:mchung
Date: 2013-04-16 22:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/222a72df2f42
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti, sundar
! src/jdk/nashorn/api/scrip
"I know 7u6 was the first version of JDK to fully support OS X."
I think that's the key to the puzzle, David! It is definitely an OS X
issue. I didn't see this happen on any other platform.
Regards
Heinz
--
Dr Heinz M. Kabutz (PhD CompSci)
Author of "The Java(tm) Specialists' Newsletter"
Su
Changeset: da6addef956e
Author:mchung
Date: 2013-04-16 21:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da6addef956e
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
Reviewed-by: jrose, alanb, twisti
! make/java/java/FILES_c.gmk
! make/jav
On 4/16/2013 7:34 PM, David Holmes wrote:
A "simple" sanity test? ;-) This would involve finding all the
libjvm's in a JRE and extracting their names, then finding and reading
the jvm.cfg file in the JRE, then invoking the VM with all the
possible entries in jvm.cfg and using the version stri
On 17/04/2013 3:51 AM, Mandy Chung wrote:
On 4/15/2013 3:42 PM, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove
the extra
This change to the jvm.cfg file needs to be put through our internal CCC
process for approval. Given that, and that this is mostly about policy
(not mechanism) and there is no absolute right answer just a
not-unreasonable default, I thought I would solicit opinions on this.
what should be the
Changeset: a3cc4b8e217a
Author:weijun
Date: 2013-04-17 10:15 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3cc4b8e217a
8011124: Make KerberosTime immutable
Reviewed-by: xuelei
! src/share/classes/sun/security/krb5/KrbApReq.java
! src/share/classes/sun/security/krb5/KrbAppM
As I've pointed out to Heinz on the concurrency-interest list there are
a couple of flawed assumptions in his test:
a) when you start() a new thread the OS scheduler may switch to it
immediately (this depends on the scheduler semantics)
b) Thread.join only signifies logical termination of the
Am 16.04.2013 20:04, schrieb Mike Duigou:
On Apr 15 2013, at 16:13 , Ulf Zibis wrote:
HashTable line 972, 992, 1011, 1035, 1064, 1099, etc.
These don't seem to line up with anything in either rev 5 or 6 of Hashtable
source (or HashMap).
Oops again, these were numbers from rev. 2.
I see, you
On Apr 16 2013, at 08:50 , Alan Bateman wrote:
> On 16/04/2013 16:13, Jim Gish wrote:
>>
>> On 04/15/2013 02:02 PM, Martin Buchholz wrote:
>>> You are fiddling with the javadoc for getChars, which is an independent
>>> change. (I am also fiddling with getChars in another ongoing change). I
>
If I'm reading this correctly, your patch is faster even for a single
thread? That's great news.
One of the problems we've had with replacing Ductus is that it has been
faster in a single thread situation than the open source versions we've
created. One of its drawbacks is that it had been d
Changeset: c5ead5aa2e13
Author:bae
Date: 2013-02-07 19:15 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5ead5aa2e13
8007014: Improve image handling
Reviewed-by: prr, mschoene, jgodinez
! src/share/classes/sun/awt/image/ByteComponentRaster.java
! src/share/classes/sun/awt/i
Changeset: 10db50a26b39
Author:joehw
Date: 2013-02-18 11:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/10db50a26b39
6657673: Issues with JAXP
Reviewed-by: alanb, lancea, ahgross, mullan
! src/com/sun/org/apache/bcel/internal/classfile/JavaClass.java
! src/com/sun/org/ap
Changeset: 3d641132f83b
Author:twisti
Date: 2013-02-26 16:16 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3d641132f83b
8004336: Better handling of method handle intrinsic frames
Reviewed-by: kvn, jrose, ahgross
! src/share/vm/opto/library_call.cpp
Changeset: 124ca2243
On Apr 16 2013, at 03:10 , David Holmes wrote:
> Hi Mike,
>
> On 16/04/2013 9:30 AM, Mike Duigou wrote:
>> Hello all;
>>
>> Another integration review in the JSR-335 libraries series. These three
>> classes provide a utility for conveniently finding count, sum, min, max and
>> average of int
On Apr 16 2013, at 09:28 , Chris Hegarty wrote:
> Looks fine to me Mike,
>
> Just a few minor inconsistencies in the @param and @return phrases, where the
> first word starts with a capital letter. I guess this should be lowercase for
> all.
Corrected.
> -Chris.
>
> On 04/16/2013 12:30 AM,
Changeset: e4e9f6455f3c
Author:mduigou
Date: 2013-04-16 11:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4e9f6455f3c
8004518: Add in-place operations to Map
8010122: Add defaults for ConcurrentMap operations to Map
Reviewed-by: darcy, briangoetz, mduigou, dholmes, ulfzib
On Apr 15 2013, at 16:13 , Ulf Zibis wrote:
> Am 15.04.2013 23:06, schrieb Mike Duigou:
>> That's because I'm not the only author. I get to fix it though, the
>> glamourous life of a JDK janitor. :-)
>
> ;-)
>
>>> HashTable line 917, 938, 984 etc.
>>> HashMap line 588 etc.
>>> Collections line
On 4/15/2013 3:42 PM, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove
the extra space to align with the next line.
I'v
On Apr 15 2013, at 15:42 , David Holmes wrote:
> On 16/04/2013 2:25 AM, Mike Duigou wrote:
>> What's the difference between removing an entry completely and retaining it
>> with "ERROR"?
>
> Just the nature of the error message:
>
> > java -green
> Error: green VM not supported
> > java -blue
>
Forwarding to core-libs.
- Kurchi
Original Message
Subject:Latency in starting threads on Mac OS X
Date: Tue, 16 Apr 2013 15:57:06 +0300
From: Dr Heinz M. Kabutz
Organization: JavaSpecialists.eu
To: macosx-port-...@openjdk.java.net
Good day my fellow Mac O
On 04/16/2013 09:43 AM, Chris Hegarty wrote:
On 04/16/2013 05:35 PM, Joe Darcy wrote:
Sorry for any inconvenience this has caused, but I'm a bit perplexed
this changeset caused a problem for several reasons.
First, I did a clean images build on linux with this changeset it all
was well. Second,
On 16/04/2013 17:35, Joe Darcy wrote:
Sorry for any inconvenience this has caused, but I'm a bit perplexed
this changeset caused a problem for several reasons.
First, I did a clean images build on linux with this changeset it all
was well. Second, as I understand it, the Supplier type should b
On 04/16/2013 05:35 PM, Joe Darcy wrote:
Sorry for any inconvenience this has caused, but I'm a bit perplexed
this changeset caused a problem for several reasons.
First, I did a clean images build on linux with this changeset it all
was well. Second, as I understand it, the Supplier type should
Sorry for any inconvenience this has caused, but I'm a bit perplexed
this changeset caused a problem for several reasons.
First, I did a clean images build on linux with this changeset it all
was well. Second, as I understand it, the Supplier type should be in
compact1.
-Joe
On 04/16/2013 0
Looks fine to me Mike,
Just a few minor inconsistencies in the @param and @return phrases,
where the first word starts with a capital letter. I guess this should
be lowercase for all.
-Chris.
On 04/16/2013 12:30 AM, Mike Duigou wrote:
Hello all;
Another integration review in the JSR-335 li
On 16/04/2013 16:13, Jim Gish wrote:
On 04/15/2013 02:02 PM, Martin Buchholz wrote:
You are fiddling with the javadoc for getChars, which is an
independent change. (I am also fiddling with getChars in another
ongoing change). I don't think closing html tags for are
required in javadoc. If
On 04/15/2013 02:02 PM, Martin Buchholz wrote:
You are fiddling with the javadoc for getChars, which is an
independent change. (I am also fiddling with getChars in another
ongoing change). I don't think closing html tags for are
required in javadoc. If you are going to change the exception
On 04/14/2013 11:29 PM, David Holmes wrote:
On 15/04/2013 1:08 PM, David Holmes wrote:
Hi Coleen,
On 13/04/2013 3:45 AM, Coleen Phillimore wrote:
Summary: Add annotations to the tests to verify bug above
open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk/
bug link at http://bugs.
Hi Mandy,
I prepared a preview variant of j.l.r.Proxy using WeakCache (turned into
an interface and a special FlattenedWeakCache implementation in
anticipation to create another variant using two-levels of
ConcurrentHashMaps for backing storage, but with same API) just to
compare performance:
Changeset: 6135c60e77e5
Author:chegar
Date: 2013-04-16 13:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6135c60e77e5
8012244: java/net/Socket/asyncClose/Race.java fails intermittently on Windows
Reviewed-by: alanb, dsamersoff
! src/windows/classes/java/net/DualStackPlain
Changeset: e2a0e37b152c
Author:chegar
Date: 2013-04-16 12:51 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2a0e37b152c
8012237: CompletableFuture/Basic.java still fails intermittently
Reviewed-by: martin
! test/java/util/concurrent/CompletableFuture/Basic.java
Hi Mike,
Thanks for looking at this.
On Apr 16, 2013, at 5:39 AM, Mike Duigou wrote:
> I went back and started again with the 8010096 webrev.
>
> Spliterators::
>
> - some implementations are private and some are package private. All package
> private?
>
I don't think there is any need to
On 04/16/2013 12:02 PM, Alan Bateman wrote:
On 16/04/2013 11:47, Chris Hegarty wrote:
Here is a simple anti-delta patch, under 8012343:
"Objects.requireNonNull(Object,Supplier) breaks genstubs build"
http://cr.openjdk.java.net/~chegar/8012343/webrev.00/webrev/
Once reviewed, I will push it.
Changeset: 61cfbe08ce5d
Author:chegar
Date: 2013-04-16 12:23 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61cfbe08ce5d
8012343: Objects.requireNonNull(Object,Supplier) breaks genstubs build
Reviewed-by: alanb
! src/share/classes/java/util/Objects.java
! test/java/util/Obje
On 16/04/2013 11:47, Chris Hegarty wrote:
Here is a simple anti-delta patch, under 8012343:
"Objects.requireNonNull(Object,Supplier) breaks genstubs build"
http://cr.openjdk.java.net/~chegar/8012343/webrev.00/webrev/
Once reviewed, I will push it. We can leave it to Joe and Jon to work
ou
On 04/16/2013 11:25 AM, Alan Bateman wrote:
Joe - it turns out that this breaks genstubs as java.util.function is
not in the boot JDK. I think we may have to anti-delta this until a
solution for genstubs is worked out.
Here is a simple anti-delta patch, under 8012343:
"Objects.requireNonNull(
Joe - it turns out that this breaks genstubs as java.util.function is
not in the boot JDK. I think we may have to anti-delta this until a
solution for genstubs is worked out.
-Alan.
On 16/04/2013 02:32, joe.da...@oracle.com wrote:
Changeset: baaa706d7677
Author:darcy
Date: 2013-04-
Hi Mike,
On 16/04/2013 9:30 AM, Mike Duigou wrote:
Hello all;
Another integration review in the JSR-335 libraries series. These three classes
provide a utility for conveniently finding count, sum, min, max and average of
ints, longs or doubles. They can be used with existing code but will mo
41 matches
Mail list logo
