Re: Proxy.isProxyClass scalability

Hi Peter, On 4/17/13 7:18 AM, Peter Levart wrote: As expected, the Proxy.getProxyClass() is yet a little slower than with FlattenedWeakCache, but still much faster than original Proxy implementation. Another lookup in the ConcurrentHashMap and another indirection have a price, but we also get

hg: jdk8/tl/jdk: 8006935: Need to take care of long secret keys in HMAC/PRF compuation

Changeset: 7bdb3e186497 Author:xuelei Date: 2013-04-18 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bdb3e186497 8006935: Need to take care of long secret keys in HMAC/PRF compuation Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/TlsPrfGenerator.ja

Re: Incorrect arguments is passed to sun.misc.Perf#createLong

Hi Mandy, Thank you so much for your cooperation. FYI. While looking at the hotspot implementation, I found a bug that creates the long counter of incorrect type (it got V_Variable and V_Monotonic reverse). I have file a hotspot bug and suggested a patch: I didn't realize it :-) Please fix

Re: RFR JDK-8011426: java.util collection Spliterator implementations

I reversed this change : -final Collection c; - +final Collection c; in Collections.UnmodifiableCollection instead opting or casts in the forEach and spliterator Methods. - I wonder if it's worth it to have the NONNULL characteristic change in Collections::singletonSpliterator depend

Re: How to deal with a missing VM? (was Re: RFR 8010280: jvm.cfg needs updating for non-server builds)

Oops, "B" for anything commonly valid and "a" for everything long obsolete. Mike On Apr 16 2013, at 19:27 , David Holmes wrote: > This change to the jvm.cfg file needs to be put through our internal CCC > process for approval. Given that, and that this is mostly about policy (not > mechanism)

Re: How to deal with a missing VM? (was Re: RFR 8010280: jvm.cfg needs updating for non-server builds)

Okay no opinions. CCC request will go with aliasing for historical compatibility. David On 17/04/2013 12:27 PM, David Holmes wrote: This change to the jvm.cfg file needs to be put through our internal CCC process for approval. Given that, and that this is mostly about policy (not mechanism) an

hg: jdk8/tl/langtools: 8012656: cache frequently used name strings for DocImpl classes

Changeset: 95d29b99e5b3 Author:jjg Date: 2013-04-18 20:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/95d29b99e5b3 8012656: cache frequently used name strings for DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/sh

hg: jdk8/tl/langtools: 8012658: Change default langtools source level to 7

Changeset: 891b88acf47a Author:jjg Date: 2013-04-18 19:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891b88acf47a 8012658: Change default langtools source level to 7 Reviewed-by: darcy ! make/netbeans/langtools/nbproject/project.xml

Re: system reserved property names

On 19/04/2013 8:32 AM, huizhe wang wrote: On 4/18/2013 2:13 AM, Alan Bateman wrote: On 18/04/2013 07:28, huizhe wang wrote: System.getProperties [1] returns all of the "current" system properties. Is there a way to get a list of the system reserved properties such as "java.version" and etc.? W

Re: RFR: JDK-8011920 (Main implementation classes for java.util.stream)

Brian, Are you asking for people to review the code, just to get some warm fuzzy feedback, or are you asking for a formal review of the code with the direct goal of pushing 15K LOC into jdk8/tl with no corresponding tests. If you are looking to push bits soon, why can't you wait until you hav

RFR : 8008670 : Initial java.util.stream putback -- internal API classes

Hello all; This is a final review for a set of internal implementation classes in the lambda streams libraries. They have no public API. Brian originally put these out for review about a month ago and nobody immediately stepped up to look at them. Since that time David Holmes and myself as well

RFR: JDK-8011920 (Main implementation classes for java.util.stream)

This is a review request for the bulk of the java.util.stream implementation; webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8011920/webrev/ You might ask: with 15,000 lines of new code, why are there no tests? The simple answer is: we've got plenty of 'em, but they can't be put back

hg: jdk8/tl/jdk: 8012005: LogManager needs test to ensure stack trace is not being done to find bundle

Changeset: 3e4a0fddeb00 Author:jgish Date: 2013-04-18 16:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e4a0fddeb00 8012005: LogManager needs test to ensure stack trace is not being done to find bundle Reviewed-by: mchung + test/java/util/logging/bundlesearch/ClassPathT

hg: jdk8/tl/langtools: 8008174: DocTree API should provide start and end positions for tree nodes

Changeset: ed918a442b83 Author:jlahoda Date: 2013-04-17 15:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed918a442b83 8008174: DocTree API should provide start and end positions for tree nodes Summary: Adding DocSourcePositions to allow access to DocTree starting/en

Re: RFR: String.join(), StringJoiner additions

Am 18.04.2013 19:37, schrieb Jim Gish: On 04/18/2013 08:49 AM, Ulf Zibis wrote: Hi, I'm wondering, that StringJoiner has some logic for pre/suffix, but nothing to loop the elements themselves :-( To me, StringJoiner is a useless complicated box around StringBuilder, and imagine, someone nee

Re: RFR: 8004518 & 8010122 : Default methods on Map

Am 10.04.2013 20:24, schrieb Remi Forax: interface + default methods are conceptually what is known as traits(*), you can see them as interface + method with code or as abstract class without state, it's the same thing. Now, if you want traits in Java, you have 3 choices: add a new kind of type

Re: system reserved property names

On 4/18/2013 2:13 AM, Alan Bateman wrote: On 18/04/2013 07:28, huizhe wang wrote: System.getProperties [1] returns all of the "current" system properties. Is there a way to get a list of the system reserved properties such as "java.version" and etc.? Would anyone know? [1]http://docs.oracle

Re: RFR: 8012005: LogManager needs test to ensure stack trace is not being done to find bundle

Looks good. I'll sponsor it. Mandy On 4/18/2013 1:15 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8012005-BundleSearchTest/ This is a new test for LogManager to ensure that the changes made for 8002070 (removing the stack search when finding a resource bundle), ar

Re: RFR: String.join(), StringJoiner additions

Thanks for catching that. I thought I fixed it. (In fact, I'm sure I did in the latest rev). On 04/18/2013 05:03 PM, Martin Buchholz wrote: Garbled javadoc: 41 * method will, by default, return {@code prefix+{@code suffix}}. However, if -- Jim Gish | Consulting Member of Technical

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 18 2013, at 10:56 , roger riggs wrote: > Hi Mike, > > Another wrinkle... > > The "a" tag allows the tag to be used in any context package, method, > constructor, package, > field and type and overview. However, the predefined javadoc structure makes > it > unsuitable for use in the pa

Re: RFR: String.join(), StringJoiner additions

Garbled javadoc: 41 * method will, by default, return {@code prefix+{@code suffix}}. However, if

Re: RFR: String.join(), StringJoiner additions

On Thu, Apr 18, 2013 at 10:34 AM, Jim Gish wrote: > That was a nice idea, but you don't want to change the value when you do > toString(). Otherwise, if you subsequently add a new element, you're hosed > because you've already added on the suffix. > > You can cheaply save the current length, app

Re: Incorrect arguments is passed to sun.misc.Perf#createLong

I have pushed the changeset:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b81fac25d26 FYI. While looking at the hotspot implementation, I found a bug that creates the long counter of incorrect type (it got V_Variable and V_Monotonic reverse). I have file a hotspot bug and suggested a patch:

RFR: 8012005: LogManager needs test to ensure stack trace is not being done to find bundle

Please review http://cr.openjdk.java.net/~jgish/Bug8012005-BundleSearchTest/ This is a new test for LogManager to ensure that the changes made for 8002070 (removing the stack search when finding a resource bundle), are working

hg: jdk8/tl/jdk: 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters

Changeset: 3b81fac25d26 Author:mchung Date: 2013-04-18 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b81fac25d26 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters Reviewed-by: mchung Contributed-by: Yasumasa Suenaga ! src/share/classes/su

Re: RFR: 8001647: In-place methods on Collection/List

Hi Akhil; List.sort:: - @since tag is in a strange location. - The (optional) on IAE is in a strange position and not linked like the others. AbstractList:: - Should we consider adding overrides for default methods here even if our impls wouldn't use them? We could at least add modCount che

Re: RFR: 8001647: In-place methods on Collection/List

Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ Please review Thanks On 12/10/2012 09:31 PM, Akhil Arora wrote: http://cr.openjdk.java.net/~akhil/8001647.3/webrev/ - now with synchronized and unmod

hg: jdk8/tl/jdk: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

Changeset: 32c3a580812b Author:mchung Date: 2013-04-18 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32c3a580812b 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt Reviewed-by: lancea, alanb ! test/ProblemList.txt

Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

On 18/04/2013 19:07, Mandy Chung wrote: This fix adds GetSafepointSyncTime.java test in the ProblemList.txt until 8010897 is resolved. It has been failing intermittently on macosx-x64. diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.tx

Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

+1 On Apr 18, 2013, at 2:07 PM, Mandy Chung wrote: > This fix adds GetSafepointSyncTime.java test in the ProblemList.txt > until 8010897 is resolved. It has been failing intermittently on macosx-x64. > > diff --git a/test/ProblemList.txt b/test/ProblemList.txt > --- a/test/ProblemList.txt > +++ b

Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

This fix adds GetSafepointSyncTime.java test in the ProblemList.txt until 8010897 is resolved. It has been failing intermittently on macosx-x64. diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -144,6 +144,9 @@ # jdk_management +

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

Hi Mike, Another wrinkle... The "a" tag allows the tag to be used in any context package, method, constructor, package, field and type and overview. However, the predefined javadoc structure makes it unsuitable for use in the package and overview. Since javadoc groups the tags inside an ind

Re: RFR: JDK-8005954: JAXP Plugability Layer should use java.util.ServiceLoader

On 17/04/2013 17:49, Daniel Fuchs wrote: Most of the merge troubles were in the FactoryFinder.java and XxxxFactoryFinder.java files - the merge was a bit difficult because some lines had changes in both parent and child - like method signature where a had been added to the return type in the

Re: RFR: String.join(), StringJoiner additions

On 04/18/2013 08:49 AM, Ulf Zibis wrote: Hi, I'm wondering, that StringJoiner has some logic for pre/suffix, but nothing to loop the elements themselves :-( To me, StringJoiner is a useless complicated box around StringBuilder, and imagine, someone needs thread-safety. It also slows down pe

Re: RFR: String.join(), StringJoiner additions

That was a nice idea, but you don't want to change the value when you do toString(). Otherwise, if you subsequently add a new element, you're hosed because you've already added on the suffix. Jim On 04/17/2013 09:20 PM, Roger Riggs wrote: Hi, Can I suggest that the StringJoiner.toString() m

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 18 2013, at 08:44 , roger riggs wrote: > Hi Mike, > > On 4/18/2013 11:01 AM, Mike Duigou wrote: >>> Note that Oracle accessibility guidelines for html indicate that headers >>> should use header tags to be properly navigable by accessibility >>> tools. >> Understood. That would be a se

Re: Use of super in type parameters

On Apr 17, 2013, at 6:11 PM, Zhong Yu wrote: > On Wed, Apr 17, 2013 at 4:53 PM, Martin Buchholz wrote: >> With the coming of lambda, it is more likely that people will be creating >> APIs with "not quite correct" generic types, as we are doing in > > I believe that we can tweak generic signatur

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

Hi Mike, On 4/18/2013 11:01 AM, Mike Duigou wrote: Note that Oracle accessibility guidelines for html indicate that headers should use header tags to be properly navigable by accessibility tools. Understood. That would be a separate issue though as we have no control over the html generated

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 18 2013, at 05:07 , Alan Bateman wrote: > On 18/04/2013 00:51, Mike Duigou wrote: >> Hello All; >> >> Some of you have noticed that the lambda streams libraries patches currently >> going in to the TL repo make use of special javadoc tags. There are three >> tags being used: >> >> @api

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On Apr 18 2013, at 06:27 , roger riggs wrote: > Hi Mike, > > The new tags are useful. JSR 310 has a similar need and construct as > @implSpec and will adopt the common tags. > > Some more information would be useful about the changeset; > why are the pre-existing tags included in the change?

Re: RFR: JDK-8011917 (java.util.stream.Collectors)

Brian, this is low-hanging fruit, but all descriptions after @param and @return should start with lowercase per published JavaDoc conventions. On Wed, Apr 17, 2013 at 2:26 PM, Brian Goetz wrote: > Single new source file at: > > > http://hg.openjdk.java.net/lambda/lambda/jdk/file/76ac19e61df1/sr

Re: RFR: 7150256: Add back Diagnostic Command JMX API

Mandy, Thanks for the review New webrevs are available here: 7150256: http://cr.openjdk.java.net/~fparain/7150256/webrev.05/ 8004095: http://cr.openjdk.java.net/~fparain/8004095/webrev.05/ My answers to your questions are in-lined below. On 21/12/2012 00:40, Mandy Chung wrote: Hi Frederic,

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

Hi Mike, The new tags are useful. JSR 310 has a similar need and construct as @implSpec and will adopt the common tags. Some more information would be useful about the changeset; why are the pre-existing tags included in the change? Note that Oracle accessibility guidelines for html indicate t

Re: RFR: String.join(), StringJoiner additions

Hi, I'm wondering, that StringJoiner has some logic for pre/suffix, but nothing to loop the elements themselves :-( To me, StringJoiner is a useless complicated box around StringBuilder, and imagine, someone needs thread-safety. It also slows down performance, as it needs additional instances

Re: RFR : 8008632 : Additional JavaDoc tags @apiNote, @implSpec and @implNote for JDK API Docs

On 18/04/2013 00:51, Mike Duigou wrote: Hello All; Some of you have noticed that the lambda streams libraries patches currently going in to the TL repo make use of special javadoc tags. There are three tags being used: @apiNote : Non-normative notes about the API. Usually used for examples. @

Re: RFR: String.join(), StringJoiner additions

Hi, I don't think it's worth to add the braces at lines 2359..2360. Please swap lines 2740 <-> 2739. -Ulf Am 18.04.2013 03:20, schrieb Roger Riggs: Hi, Can I suggest that the StringJoiner.toString() method explicitly append the suffix to the existing StringBuilder. 152 return (val

hg: jdk8/tl/jdk: 8009648: Tests fail in -agentvm -concurrency mode

Changeset: 3c8724085cf7 Author:alanb Date: 2013-04-18 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c8724085cf7 8009648: Tests fail in -agentvm -concurrency mode Reviewed-by: alanb Contributed-by: roger.ri...@oracle.com ! test/Makefile ! test/java/time/TEST.propertie

Re: RFR: String.join(), StringJoiner additions

On 17/04/2013 22:49, Jim Gish wrote: Here's an update: http://cr.openjdk.java.net/~jgish/Bugs-5015163-7172553/ Jim StringJoiner looks much better now, good to see it reduced down to 2 simple constructors. One thing that I didn't br

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: aa8170c0dec9 Author:sundar Date: 2013-04-15 20:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa8170c0dec9 8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error Reviewed-by: lagergren, jlaskey ! src/jdk

hg: jdk8/tl/jdk: 8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac)

Changeset: 296c9ec816c6 Author:alanb Date: 2013-04-18 11:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/296c9ec816c6 8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac) Reviewed-by: chegar ! src/share/classes/java/nio/file/attribute/BasicFileAt

Re: JDK-8011653: Upgrade to JAXP 1.5

On 4/15/2013 2:22 AM, Alan Bateman wrote: On 15/04/2013 08:48, Joe Wang wrote: : For the new properties then it specifies that a "a runtime exception" will be thrown. Can this be more specific? They can't be in XMLConstants, but they are in the specific Factories. The properties may be s

Re: system reserved property names

On 18/04/2013 07:28, huizhe wang wrote: System.getProperties [1] returns all of the "current" system properties. Is there a way to get a list of the system reserved properties such as "java.version" and etc.? Would anyone know? [1]http://docs.oracle.com/javase/6/docs/api/java/lang/System.htm

Re: What is the Build Process for Codes inside jdk/src/macosx/native/jobjc

Hello Dan, These sources are indeed treated separately. I don't actually know why, but they were in the old build. (There the native was compiled as an XCode project and the java code with Ant). When converting to the new build, we strived to keep differences in build output to a minimum. This