hg: jdk8/tl/jdk: 8005527: [TEST_BUG] console.sh failed Automatically with exit code 1.

2013-04-21 Thread weijun . wang
Changeset: 22a27dfd0510 Author:weijun Date: 2013-04-22 11:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22a27dfd0510 8005527: [TEST_BUG] console.sh failed Automatically with exit code 1. Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh

Re: RFR: 8001647: In-place methods on Collection/List

2013-04-21 Thread Akhil Arora
On 04/21/2013 04:33 AM, Alan Bateman wrote: On 20/04/2013 02:39, Akhil Arora wrote: On 04/19/2013 04:15 AM, Alan Bateman wrote: On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-21 Thread Ulf Zibis
Minor nits: DriverManager line 349: I would break the line right after the opening parenthesis. DriverManager line 355: missing space after comma. -Ulf Am 21.04.2013 13:45, schrieb Lance Andersen - Oracle: Thank you for the feedback Alan, Please see below and the webrev http://cr.openjdk.jav

Re: Proxy.isProxyClass scalability

2013-04-21 Thread Peter Levart
On 04/21/2013 04:52 AM, Mandy Chung wrote: Hi Peter, I want to give it some more thought and discuss with you next week. As for the zero number of interface, I think it's a bug and it should throw IAE if the given interfaces array is empty. Thanks for finding it and I'll file a separate bug

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-21 Thread Lance Andersen - Oracle
Thank you for the feedback Alan, Please see below and the webrev http://cr.openjdk.java.net/~lancea/8010416/webrev.02/ On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote: > On 19/04/2013 18:34, Lance Andersen - Oracle wrote: >> Hi, >> >> We have been asked by a few JDBC driver vendors to allow a

Re: RFR: 8001647: In-place methods on Collection/List

2013-04-21 Thread Alan Bateman
On 20/04/2013 02:39, Akhil Arora wrote: On 04/19/2013 04:15 AM, Alan Bateman wrote: On 18/04/2013 19:49, Akhil Arora wrote: Looks like the stars are aligning on getting on this into TL... the refreshed webrev is - http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment on Collect

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

2013-04-21 Thread Alan Bateman
On 19/04/2013 18:34, Lance Andersen - Oracle wrote: Hi, We have been asked by a few JDBC driver vendors to allow a JDBC driver to be notified when/if it was deregistered via DriverManager.deregisterDriver if desired. The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/web