Re: (Preliminary) RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Alan Bateman
On 06/05/2013 22:44, Peter Levart wrote: : If anyone is stop()-ing ReferenceHandler thread then it should be stopped. Speaking of that, if ThreadDeath is thrown in the middle of Cleaner's thunk.run() processing, then the Cleaner will exit JVM. I think ThreadDeath should be separately caught

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-07 Thread huizhe wang
On 5/6/2013 11:46 PM, Alan Bateman wrote: On 06/05/2013 18:49, huizhe wang wrote: : True. I've added 176 new tests. JCK team is also testing using the current build of JAXP RI. I will also run regression tests. The new webrev included fixes to a couple of test failures in the last JPRT

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Thomas Schatzl
Hi all, On Tue, 2013-05-07 at 12:31 +1000, David Holmes wrote: Catching ThreadDeath is futile. If someone is invoking stop() then you can encounter the ThreadDeath anywhere and it is impossible to write completely robust code in the face of such an async exception. So please let's not even

Re: JDK-8011653: Upgrade to JAXP 1.5

2013-05-07 Thread Alan Bateman
On 07/05/2013 08:39, huizhe wang wrote: : : - DocumentBuilderFactory still says that SAXException is throw by DocumentBuilderFactory. Yes, that's what's in the jaxp1.3/1.4 spec unfortunately. Both DOM and SAX throws SAXException. It should have defined a DOMException for DOM operations.

Re: Review Request: BigInteger patch for efficient multiplication and division (#4837946)

2013-05-07 Thread Alan Eliasen
On May 4, 2013, at 5:13 AM, Alan Eliasen wrote: If you're feeling overwhelmed by the magnitude of the changes to BigInteger, I would very strongly suggest that you review it in stages. This e-mail proposes stages for the review of this patch. On 05/06/2013 02:47 PM, Brian Burkhalter wrote:

hg: jdk8/tl/jdk: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently

2013-05-07 Thread daniel . fuchs
Changeset: 2602eab5f086 Author:dfuchs Date: 2013-05-07 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2602eab5f086 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Peter Levart
On 05/07/2013 09:51 AM, Thomas Schatzl wrote: Hi all, On Tue, 2013-05-07 at 12:31 +1000, David Holmes wrote: Catching ThreadDeath is futile. If someone is invoking stop() then you can encounter the ThreadDeath anywhere and it is impossible to write completely robust code in the face of such an

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Thomas Schatzl
Hi, On Tue, 2013-05-07 at 15:12 +0200, Peter Levart wrote: On 05/07/2013 09:51 AM, Thomas Schatzl wrote: Hi all, On Tue, 2013-05-07 at 12:31 +1000, David Holmes wrote: Catching ThreadDeath is futile. If someone is invoking stop() then you can encounter the ThreadDeath anywhere and it

RE: RFR : 7129185 : Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}

2013-05-07 Thread Jason Mehrens
Mike, EmptyNavigableMap and EmptyNavigableSet should contain the static final references themselves and not the Collections class. That way they load on demand and not with the Collections class. Use default visibility inside the inner class so the compiler doesn't generate method to promote

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Peter Levart
On 05/07/2013 03:26 PM, Thomas Schatzl wrote: Hi, On Tue, 2013-05-07 at 15:12 +0200, Peter Levart wrote: On 05/07/2013 09:51 AM, Thomas Schatzl wrote: Hi all, On Tue, 2013-05-07 at 12:31 +1000, David Holmes wrote: Catching ThreadDeath is futile. If someone is invoking stop() then you can

Re: JEP 185: JAXP 1.5: Restrict Fetching of External Resources

2013-05-07 Thread Florian Weimer
On 05/01/2013 01:00 AM, mark.reinh...@oracle.com wrote: Posted: http://openjdk.java.net/jeps/185 Are other robustness improvements out of scope? The Schema Component Constraint: Unique Particle Attribution comes to my mind, which is currently not enforced by OpenJDK. -- Florian Weimer /

RFR 8014076: Arrays parallel and serial sorting improvements

2013-05-07 Thread Chris Hegarty
Doug has made some updates to the java.util.Arrays sorting code to provide stable sorting. There have also been some changes to the original Parallel Array Sorting ( MIN_ARRAY_SORT_GRAN is public again ). Right now a copy of this work is sitting in the lambda repo. This issue proposed to

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Jesper Wilhelmsson
Thomas Schatzl skrev 7/5/13 3:26 PM: Hi, On Tue, 2013-05-07 at 15:12 +0200, Peter Levart wrote: On 05/07/2013 09:51 AM, Thomas Schatzl wrote: Hi all, On Tue, 2013-05-07 at 12:31 +1000, David Holmes wrote: Catching ThreadDeath is futile. If someone is invoking stop() then you can encounter

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-07 Thread Thomas Schatzl
Hi, On Tue, 2013-05-07 at 16:10 +0200, Peter Levart wrote: On 05/07/2013 03:26 PM, Thomas Schatzl wrote: Hi, There is a message emitted by the VM reading java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread Reference Handler that is sufficient to detect the

Re: RFR : 7129185 : Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}

2013-05-07 Thread Mike Duigou
Good suggestion, thank you. Mike On May 7 2013, at 06:36 , Jason Mehrens wrote: Mike, EmptyNavigableMap and EmptyNavigableSet should contain the static final references themselves and not the Collections class. That way they load on demand and not with the Collections class. Use

hg: jdk8/tl/jdk: 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1; ...

2013-05-07 Thread staffan . larsen
Changeset: 7b40394ad944 Author:sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG:

hg: jdk8/tl/jdk: 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true

2013-05-07 Thread staffan . larsen
Changeset: 100027950b05 Author:sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh

Re: RFR: JDK-8013736: [launcher] cleanup code for correctness

2013-05-07 Thread Kumar Srinivasan
On 5/7/2013 7:15 AM, Kumar Srinivasan wrote: On 5/6/2013 7:38 PM, Martin Buchholz wrote: This looks good. There's one check I found confusing. 175 if (alen = 0 || alen INT_MAX / sizeof(char *)) { Not that it matters much, but I'm not sure exactly what you're trying to check here. If

hg: jdk8/tl/jdk: 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied

2013-05-07 Thread naoto . sato
Changeset: e30396e22c6f Author:naoto Date: 2013-05-07 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e30396e22c6f 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Reviewed-by: okutsu !

Re: JEP 185: JAXP 1.5: Restrict Fetching of External Resources

2013-05-07 Thread huizhe wang
On 5/7/2013 7:42 AM, Florian Weimer wrote: On 05/01/2013 01:00 AM, mark.reinh...@oracle.com wrote: Posted: http://openjdk.java.net/jeps/185 Are other robustness improvements out of scope? Yes, JAXP MR 1.5 is focused on external references. The Schema Component Constraint: Unique

Re: Review Request: BigInteger patch for efficient multiplication and division (#4837946)

2013-05-07 Thread Brian Burkhalter
Alan, On May 7, 2013, at 2:33 AM, Alan Eliasen wrote: My rationale for attempting a larger review was that if these new changes were not examined now, then they will likely miss the JDK 8 train altogether. On the other hand if time were to run out on a large review then there would be a risk

hg: jdk8/tl/jdk: 4802647: Throw required NPEs from removeAll()/retainAll()

2013-05-07 Thread mike . duigou
Changeset: fe4e9bc2186f Author:mduigou Date: 2013-05-07 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe4e9bc2186f 4802647: Throw required NPEs from removeAll()/retainAll() Reviewed-by: mduigou, chegar, dholmes Contributed-by: Brandon Passanisi

Re: RFR: JDK-8013736: [launcher] cleanup code for correctness

2013-05-07 Thread Martin Buchholz
On 5/7/13, Kumar Srinivasan kumar.x.sriniva...@oracle.com wrote: On 5/7/2013 7:15 AM, Kumar Srinivasan wrote: I think I will leave it as-is, jexec, it appears may not be needed, this was added for Solaris primarily, and I am not sure if this is required anymore (as Alan pointed out earlier),

hg: jdk8/tl/langtools: 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar

2013-05-07 Thread jonathan . gibbons
Changeset: 43c2f7cb9c76 Author:jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore !

hg: jdk8/tl/jdk: 8012664: Add tests for java.util.stream and lambda translation

2013-05-07 Thread mike . duigou
Changeset: 6feee75b0a8b Author:briangoetz Date: 2013-05-06 11:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6feee75b0a8b 8012664: Add tests for java.util.stream and lambda translation Reviewed-by: mduigou, briangoetz Contributed-by: Brian Goetz brian.go...@oracle.com,

Streams milestone

2013-05-07 Thread Brian Goetz
With changeset: 7058:6feee75b0a8b summary: 8012664: Add tests for java.util.stream and lambda translation we now have the lion's share of the java.util.stream code and tests put back into the JDK8 repositories (16+ KLoC of new code and 15+ KLoC of new tests, with nearly 100% coverage)*.

Re: Streams milestone

2013-05-07 Thread mark . reinhold
2013/5/7 9:46 -0700, brian.go...@oracle.com: With changeset: 7058:6feee75b0a8b summary: 8012664: Add tests for java.util.stream and lambda translation we now have the lion's share of the java.util.stream code and tests put back into the JDK8 repositories (16+ KLoC of new code and

Re: RFR 8014076: Arrays parallel and serial sorting improvements

2013-05-07 Thread David Holmes
Hi Chris, Didn't Doug's changes also remove the constraint: The algorithm requires a working space equal to the size of the original array. ? David On 8/05/2013 12:51 AM, Chris Hegarty wrote: Doug has made some updates to the java.util.Arrays sorting code to provide stable sorting. There