Re: RFR 8015895 Int/LongStream.range/rangeClosed

Looks good to me. Mike On Jun 5 2013, at 06:10 , Paul Sandoz wrote: > Hi, > > The following was decided by the JSR-335 EG: > > 1) Int/LongStream.range are restricted to a fixed step of 1. The map > operation can be used to adjust the step. > > 2) Int/LongStream.rangeClosed methods were added

Re: RFR 8009581: Xpathexception does not honor initcause()

On 05/06/2013 17:34, Aleksej Efimov wrote: New webrev: http://cr.openjdk.java.net/~dmeetry/8009581/webrev.7/ Thanks, you've addressed all the issues so I think we are good now. -Alan

Re: Sponsor needed: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

Will do. On Jun 5, 2013, at 11:54 AM, Martin Buchholz wrote: > You could add more contributors to the Contributed-by: line.

Re: Sponsor needed: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

I can sponsor it. I haven't got the cycle to review this change but Martin and Iris reviewed it and this changeset is good to go. Mandy On 6/5/2013 10:26 AM, Brian Burkhalter wrote: The webrev and patch are here http://cr.openjdk.java.net/~bpb/7032154/ And the pertinent recent review in thi

Sponsor needed: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

The webrev and patch are here http://cr.openjdk.java.net/~bpb/7032154/ And the pertinent recent review in this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/017317.html The changeset comment is: 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDec

Re: RFR 8009581: Xpathexception does not honor initcause()

Aleksej, When you're ready, after fixing the remaining things as Alan commented, please push the change to hg.openjdk.java.net/jdk8/tl-gate/jaxp. For 7u, send a request to jdk7u-dev and indicate that the changes are identical to that for jdk8. Thanks, Joe On 6/5/2013 3:09 AM, Alan Bateman

Re: RFR 8009581: Xpathexception does not honor initcause()

On 06/05/2013 02:09 PM, Alan Bateman wrote: On 04/06/2013 16:19, Aleksej Efimov wrote: Alan, Jason, Thanks for clarification. I have moved the serial data from binary files to test class: http://cr.openjdk.java.net/~dmeetry/8009581/webrev.5/

Re: Measuring performance changes from applying 4837946 patch

On Jun 5, 2013, at 8:26 AM, Aleksey Shipilev wrote: > Aleksey : Sorry: I had not finished my first coffee yet. > >>> b) the annotations you are using on each method, can flow up to >>> class-level annotation, and will be inherited by all the @GMB methods; >> >> I was not aware of this. > > Y

hg: jdk8/tl/nashorn: 6 new changesets

Changeset: 0feca8a93cb3 Author:attila Date: 2013-06-05 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0feca8a93cb3 8015955: ObjectNode.elements should be stronger typed Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/n

hg: jdk8/tl/jdk: 7150256: Add back Diagnostic Command JMX API

Changeset: e857b2a3ecee Author:fparain Date: 2013-06-05 08:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e857b2a3ecee 7150256: Add back Diagnostic Command JMX API Reviewed-by: mchung, jbachorik ! make/java/management/Exportedfiles.gmk ! make/java/management/FILES_c.gmk !

Re: Measuring performance changes from applying 4837946 patch

On 06/05/2013 07:13 PM, Brian Burkhalter wrote: > Hi Sergey, Aleksey :) >> b) the annotations you are using on each method, can flow up to >> class-level annotation, and will be inherited by all the @GMB methods; > > I was not aware of this. Yes, and with the daizy-fresh JMH, it is even possib

hg: jdk8/tl/jdk: 8015963: Add at since tags to new ConcurrentHashMap methods

Changeset: c1af6b5a979a Author:chegar Date: 2013-06-05 16:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1af6b5a979a 8015963: Add at since tags to new ConcurrentHashMap methods Reviewed-by: shade, martin ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

Re: Measuring performance changes from applying 4837946 patch

Hi Sergey, Thanks for the comments and suggestions. On Jun 5, 2013, at 2:20 AM, Aleksey Shipilev wrote: > Sergey will follow up on the benchmark itself, I'm just being > nit-picking below (not that it helps performance, but it does contribute > to cleaner benchmark code): > a) if you only have

hg: jdk8/tl/jdk: 8011719: Properties.loadFromXML fails with a chunked HTTP connection

Changeset: 5edcc8ca4146 Author:chegar Date: 2013-06-05 16:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5edcc8ca4146 8011719: Properties.loadFromXML fails with a chunked HTTP connection Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection

Re: 8015963: Add at since tags to new ConcurrentHashMap methods

On 05/06/2013 14:49, Martin Buchholz wrote: jsr166 CVS updated with this patch, except that the jsr166 style is not to introduce a blank line just for @since. Thanks Martin, Trivially, I think you are still missing a few: reduceEntriesToLong, reduceEntriesToInt, and class KeySetView. Than

hg: jdk8/tl/jdk: 8015604: JDP packets containing ideographic characters are broken

Changeset: df1b35c7901d Author:dsamersoff Date: 2013-06-05 18:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df1b35c7901d 8015604: JDP packets containing ideographic characters are broken Summary: Code uses string length rather than byte array length and non ascii entry b

Re: 8015963: Add at since tags to new ConcurrentHashMap methods

Looks good to me. -Aleksey. On 06/05/2013 02:42 PM, Chris Hegarty wrote: > Just some minor cleanup after the integration of CHMv8. Trivially, add > @since 1.8 tags to the 34 new methods and 1 new class in ConcurrentHashMap. > > http://cr.openjdk.java.net/~chegar/8015963/webrev.00/webrev/src/shar

RFR 8015895 Int/LongStream.range/rangeClosed

Hi, The following was decided by the JSR-335 EG: 1) Int/LongStream.range are restricted to a fixed step of 1. The map operation can be used to adjust the step. 2) Int/LongStream.rangeClosed methods were added for a closed range with a fixed step of 1, in addition to the half open range of 1).

hg: jdk8/tl/jdk: 8015880: GenerateBreakIteratorData build warning

Changeset: ae700bdb68b6 Author:alanb Date: 2013-06-05 13:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae700bdb68b6 8015880: GenerateBreakIteratorData build warning Reviewed-by: peytoia ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java

hg: jdk8/tl/langtools: 7186887: Test T6567415.java can fail on a slow machine

Changeset: 79fd9cfa55f2 Author:kizune Date: 2013-06-05 16:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79fd9cfa55f2 7186887: Test T6567415.java can fail on a slow machine Reviewed-by: jjg, ksrini ! test/tools/javac/6567415/T6567415.java

8015963: Add at since tags to new ConcurrentHashMap methods

Just some minor cleanup after the integration of CHMv8. Trivially, add @since 1.8 tags to the 34 new methods and 1 new class in ConcurrentHashMap. http://cr.openjdk.java.net/~chegar/8015963/webrev.00/webrev/src/share/classes/java/util/concurrent/ConcurrentHashMap.java.udiff.html Doug, Here is

hg: jdk8/tl/jdk: 8013649: HashMap spliterator tryAdvance() encounters remaining elements after forEachRemaining()

Changeset: de11b20f8c01 Author:psandoz Date: 2013-05-31 10:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de11b20f8c01 8013649: HashMap spliterator tryAdvance() encounters remaining elements after forEachRemaining() Reviewed-by: chegar ! src/share/classes/java/util/HashM

hg: jdk8/tl/jdk: 8003895: java/nio/channels/AsynchronousChannelGroup/Unbounded.java failing again [win64]

Changeset: 8a9f897a57d6 Author:alanb Date: 2013-06-05 11:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a9f897a57d6 8003895: java/nio/channels/AsynchronousChannelGroup/Unbounded.java failing again [win64] Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channe

Re: RFR 8009581: Xpathexception does not honor initcause()

On 04/06/2013 16:19, Aleksej Efimov wrote: Alan, Jason, Thanks for clarification. I have moved the serial data from binary files to test class: http://cr.openjdk.java.net/~dmeetry/8009581/webrev.5/ -Aleksej Thanks, this looks much be

hg: jdk8/tl/nashorn: 16 new changesets

Changeset: 66b2fde90c9d Author:jlaskey Date: 2013-05-29 16:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66b2fde90c9d 8015636: Add more typed arrays code coverage tests. Reviewed-by: sundar Contributed-by: james.las...@oracle.com + test/script/basic/typedarrays.js C

Re: RFR 8009581: Xpathexception does not honor initcause()

This seems fine to me. David On 5/06/2013 1:19 AM, Aleksej Efimov wrote: Alan, Jason, Thanks for clarification. I have moved the serial data from binary files to test class: http://cr.openjdk.java.net/~dmeetry/8009581/webrev.5/ -Aleksej

Re: RFR: 8000450: Restrict access to com/sun/corba/se/impl package

On 05/06/2013 07:20, Alan Bateman wrote: On 04/06/2013 23:57, Seán Coffey wrote: The com.sun.corba.se.impl package is a private package. The API is subject to change at any time and no 3rd party code should be using it. As a result, I'd like to add it to the package restricted list. I've run