hg: jdk8/tl/jdk: 8016209: TEST_BUG: non-compliant jmc in the bin directory hangs testing

2013-06-08 Thread kumar . x . srinivasan
Changeset: c351a48c091d Author:ksrini Date: 2013-06-08 09:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c351a48c091d 8016209: TEST_BUG: non-compliant jmc in the bin directory hangs testing Reviewed-by: alanb, darcy, chegar ! test/tools/launcher/VersionCheck.java

Proposal: Comparables.isCommutativelyComparable

2013-06-08 Thread Doug Lea
Suppose you have two objects, x and y, both of the same type (x.getClass() == y.getClass()) and both known to be instanceof Comparable. Can you compare them? That is, can you safely call (Comparable)x).compareTo(y); Almost always, the answer is yes, because almost all Comparable classes are o

Class.getGenericInterfaces performance improvement

2013-06-08 Thread Doug Lea
While tracking down performance issues in some reflective checks used inside ConcurrentHashMap, I noticed that method Class.getGenericInterfaces (as well as methods getGenericSuperclass and getTypeParameters) entail an expensive unnecessary recheck on each invocation. Each relies primarily on (i

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-08 Thread Aleksey Shipilev
(copying hotspot-dev@ back, the patch is theirs) Thanks Remi! On 06/08/2013 02:21 PM, Remi Forax wrote: > in add, the do/while does something a little weird, if putIfAbsent > returns null, interned is equals to elem, there is no need to do a > e.get() in that case, Oh yes, that a nice micro-opt

Re: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

2013-06-08 Thread Remi Forax
On 06/07/2013 12:01 PM, Aleksey Shipilev wrote: (posting this to hotspot-dev@ and cc-ing core-libs-dev@, as Christian T. suggested offline) Hi guys, Hi Aleksey, The fix for scalability problem is here: http://cr.openjdk.java.net/~shade/7177472/webrev.00/ in add, the do/while does somet

Re: RFR: JDK-8016209: TEST_BUG: non-compliant jmc in the bin directory hangs testing (XS)

2013-06-08 Thread Alan Bateman
On 08/06/2013 01:52, Kumar Srinivasan wrote: Hi, Can I get a quick review please, the fix excludes j2sdk-image/bin/jmc{.exe} from the test, which invokes the tool and verifies that -version and -Joptions work. As the subject says invoking this tool with any option puts up a window, hanging up

Re: RFR: JDK-8016209: TEST_BUG: non-compliant jmc in the bin directory hangs testing (XS)

2013-06-08 Thread Chris Hegarty
On 8 Jun 2013, at 02:59, Joe Darcy wrote: > Approved. +1 -Chris. > > -Joe > > On 6/7/2013 5:52 PM, Kumar Srinivasan wrote: >> Hi, >> >> Can I get a quick review please, the fix excludes j2sdk-image/bin/jmc{.exe} >> from the test, which invokes the tool and verifies that -version and >> -Jo

Re: RFR: 8016213 : (S) Convert j2se NetBeans project to new build infrastructure

2013-06-08 Thread Chris Hegarty
Looks ok to Mike. -Chris On 8 Jun 2013, at 02:20, Mike Duigou wrote: > Hello all; > > I took a look today at converting the existing J2SE NetBeans project to use > the new build infrastructure. It turned out to be easier than I thought! > > Below is the patch needed to invoke the top level m