On 06/19/2013 01:13 AM, Mike Duigou wrote:
On Jun 18 2013, at 05:19 , Doug Lea wrote:
On 06/17/13 19:30, Mike Duigou wrote:
I had to add the improved default for ConcurrentMap which was present in the
lambda repo in order to have correct behaviour. Since getOrDefault is already
in Concurren
Changeset: 21d9cbbb7bf3
Author:mfang
Date: 2013-06-18 22:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/21d9cbbb7bf3
8016824: jdk8 l10n resource file translation update 3 - jaxp
Reviewed-by: joehw
! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.propertie
Changeset: d406edd4f6fd
Author:mfang
Date: 2013-06-18 20:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d406edd4f6fd
8015657: jdk8 l10n resource file translation update 3
Reviewed-by: yhuang
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.propertie
Changeset: d82773b770ce
Author:mfang
Date: 2013-06-18 21:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d82773b770ce
8015657: jdk8 l10n resource file translation update 3
Reviewed-by: yhuang
! src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties
!
src/share/c
Changeset: 792c40d5185a
Author:mfang
Date: 2013-06-18 20:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/792c40d5185a
8015657: jdk8 l10n resource file translation update 3
Reviewed-by: yhuang
!
src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_
Hi Thomas,
On 19/06/2013 7:08 AM, Thomas Schatzl wrote:
Hi all,
can I have reviews for the following change?
It happens if multiple threads are enqueuing and dequeuing reference
objects into a reference queue, that Reference objects may be enqueued
at multiple times.
This is because when j
Changeset: 2d9da733014f
Author:xuelei
Date: 2013-06-18 18:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d9da733014f
8000456: Add programmatic deadlock detection in SSLEngineDeadlock
Reviewed-by: wetmore
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl
I have now updated MOAT to test the Collections wrappers. I hope that adding
additional classes doesn't take the already long runtime of this class over the
timeout threshold.
The revised webrev, which includes only changes to tests, is here:
http://cr.openjdk.java.net/~mduigou/JDK-7129185/6/we
On Jun 18, 2013, at 5:51 PM, Martin Buchholz wrote:
> As always, I hope that those folks who deeply understand math stuff can be
> empowered to submit/review.
> Looks good, except for some minor style issues:
> Probably want to leave debug print commented out in the final version?
> -
The updated comments have been propagated to the online webrev
http://cr.openjdk.java.net/~bpb/7131192/
On Jun 17, 2013, at 11:39 AM, Brian Burkhalter wrote:
> I'll update this but without reposting the webrev until I can upload the HTML
> version.
>
> On Jun 17, 2013, at 11:37 AM, Louis Wasse
On 06/19/2013 01:16 AM, Mike Duigou wrote:
On Jun 18 2013, at 11:54 , Remi Forax wrote:
On 06/18/2013 01:30 AM, Mike Duigou wrote:
The webrev looks fine for me.
Nitpicking a little bit, in IdentityHashMap (forEach and replaceAll),
t[index] is processed twice, by example in forEach, it would p
Changeset: b9587f41fd55
Author:smarks
Date: 2013-06-18 17:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55
8016780: README-builds.html misses crucial requirement on bootstrap JDK
Reviewed-by: dholmes, chegar
! README-builds.html
This RFR was initially posted last month:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016999.html
I hope that this is the final re-post. The issues in question are
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646
On Jun 18 2013, at 15:14 , Martin Buchholz wrote:
> Thanks for reusing the existing testing infrastructure I wrote many years ago.
Better than starting from scratch. One aspect which was a bit frustrating and
required some changes was the assumption that the result of
Navigable.subMap(low,high
Changeset: 1f7cbe4829fe
Author:mduigou
Date: 2013-06-18 16:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7cbe4829fe
8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable,
IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap
Reviewed-by: forax, mduigou, psando
On Jun 18 2013, at 11:54 , Remi Forax wrote:
> On 06/18/2013 01:30 AM, Mike Duigou wrote:
>
> The webrev looks fine for me.
>
> Nitpicking a little bit, in IdentityHashMap (forEach and replaceAll),
> t[index] is processed twice, by example in forEach, it would prefer this code:
>
>public v
On Jun 18 2013, at 05:19 , Doug Lea wrote:
> On 06/17/13 19:30, Mike Duigou wrote:
>
>>
>> I had to add the improved default for ConcurrentMap which was present in the
>> lambda repo in order to have correct behaviour. Since getOrDefault is
>> already in ConcurrentMap I will include this but
Hi Thomas,
Thanks for the detailed analysis.
http://cr.openjdk.java.net/~tschatzl/8014890/webrev/
The fix looks good. I was able to reproduce the failure with the
test case in the bug report running with jdk8 b94 fastdebug build.
But the new regression test doesn't fail (I tried solaris-i586)
Changeset: ba544aab1fcd
Author:bpb
Date: 2013-06-18 11:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba544aab1fcd
8015395: NumberFormatException during startup if JDK-internal property
java.lang.Integer.IntegerCache.high set to bad value
Summary: Fall back to default if
Hi all,
can I have reviews for the following change?
It happens if multiple threads are enqueuing and dequeuing reference
objects into a reference queue, that Reference objects may be enqueued
at multiple times.
This is because when java.lang.ref.ReferenceQueue.poll() returns and
inactivates a
Changeset: 4d4818b6df72
Author:chegar
Date: 2013-04-24 11:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d4818b6df72
Merge
Changeset: 27cda5134748
Author:chegar
Date: 2013-04-28 08:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27cda
Changeset: af8a98ea83d4
Author:chegar
Date: 2013-04-24 11:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af8a98ea83d4
Merge
Changeset: 2237e2ff3685
Author:chegar
Date: 2013-04-28 08:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2237e2ff3
Changeset: 39d15bbb5741
Author:coffeys
Date: 2013-04-08 23:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/39d15bbb5741
8001032: Restrict object access
Summary: Restrict object access; fix reviewed also by Alexander Fomin
Reviewed-by: alanb, ahgross
! make/com/sun/corba/
Changeset: f14f72174f00
Author:chegar
Date: 2013-04-24 10:18 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f14f72174f00
Merge
Changeset: b225607e056b
Author:chegar
Date: 2013-04-28 08:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b225607e056b
M
Changeset: f75faf51e8c4
Author:hseigel
Date: 2013-03-07 11:49 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f75faf51e8c4
7158805: Better rewriting of nested subroutine calls
Reviewed-by: mschoene, coleenp
! src/share/vm/memory/allocation.cpp
! src/share/vm/memory/alloca
On 06/18/2013 01:30 AM, Mike Duigou wrote:
The webrev looks fine for me.
Nitpicking a little bit, in IdentityHashMap (forEach and replaceAll),
t[index] is processed twice, by example in forEach, it would prefer this
code:
public void forEach(BiConsumer action) {
Objects.requireNon
Yes, I have that removed. Thanks for the review!
- Kurchi
On 6/18/2013 1:57 AM, Chris Hegarty wrote:
For the purposes of this issue, I think your changes to hashCode are
in line with the equals implementation. Trivially, you could also
remove the '(obj != null) && ' from equals ;-) Otherwise,
Changeset: e701af23a095
Author:vromero
Date: 2013-06-18 18:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e701af23a095
8016607: javac, avoid analyzing lambdas for source 7 compilation
Reviewed-by: jjg
Contributed-by: maurizio.cimadam...@oracle.com
! src/share/classe
Changeset: 9851071b551a
Author:vromero
Date: 2013-06-18 19:02 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9851071b551a
8016267: javac, TypeTag refactoring has provoked performance issues
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/s
FWIW, the HashMap/LinkedHashMap/Hashtable/WeakHashMap changes look good
to me.
-Brent
On 6/17/13 9:43 PM, Mike Duigou wrote:
Now updated again with additional tests and, as these things go, fixes. I was
able to use LockStep to exercise the checkedNavigable{Set/Map} and
synchronizedNavigable{
Hello!
I suggest to extend the test to cover the case with malformed input.
Would you please review the suggested change?
http://cr.openjdk.java.net/~igerasim/7021870/0/webrev/
I haven't created the bug id for the change yet.
Will create one if you agree that the change is reasonable.
The main
On 18/06/2013 11:19, Chris Hegarty wrote:
On 06/18/2013 11:17 AM, Alan Bateman wrote:
This looks okay but I think we have several more java.time tests failing
at the moment (I assume the javac changes to emit bridge methods but I
have not looked at it closely).
I have not seen these failures
Changeset: 956b00d7d4ea
Author:uta
Date: 2013-06-18 17:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/956b00d7d4ea
8016046: (process) Strict validation of input should be security manager case
only [win].
Reviewed-by: alanb, ahgross
! src/windows/classes/java/lang/Proces
On 06/17/13 19:30, Mike Duigou wrote:
I had to add the improved default for ConcurrentMap which was present in the
lambda repo in order to have correct behaviour. Since getOrDefault is already
in ConcurrentMap I will include this but we have to be careful when we do a jsr
166 syncup to make
Changeset: df5d7f34e35e
Author:hannesw
Date: 2013-06-11 17:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/df5d7f34e35e
8015379: PropertyMap.addProperty() is slow
Reviewed-by: attila, jlaskey
! src/jdk/nashorn/internal/runtime/PropertyMap.java
Changeset: aa16622193e1
On 06/18/2013 11:17 AM, Alan Bateman wrote:
This looks okay but I think we have several more java.time tests failing
at the moment (I assume the javac changes to emit bridge methods but I
have not looked at it closely).
I have not seen these failures recently. Do you have specific changes
you
This looks okay but I think we have several more java.time tests failing
at the moment (I assume the javac changes to emit bridge methods but I
have not looked at it closely).
-Alan.
On 18/06/2013 11:10, Chris Hegarty wrote:
I would like to propose to add
java/time/test/java/time/format/Te
I would like to propose to add
java/time/test/java/time/format/TestDateTimeTextProvider.java to the
ProblemList.txt until it can be resolved. 8016623 is filed against it,
and should remove it from the list along with whatever source changes
are appropriate.
diff --git a/test/ProblemList.txt b
For the purposes of this issue, I think your changes to hashCode are in
line with the equals implementation. Trivially, you could also remove
the '(obj != null) && ' from equals ;-) Otherwise, looks fine to me.
-Chris.
On 06/18/2013 12:01 AM, Kurchi Hazra wrote:
I spent some more time reviewi
39 matches
Mail list logo
