hg: jdk8/tl/jdk: 8014377: (dc) DatagramChannel should set IP_MULTICAST_ALL=0 (lnx)

Changeset: cd06fc069152 Author:alanb Date: 2013-06-20 19:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd06fc069152 8014377: (dc) DatagramChannel should set IP_MULTICAST_ALL=0 (lnx) Reviewed-by: chegar, jzavgren ! src/solaris/native/sun/nio/ch/Net.c + test/java/nio/chann

Re: RFR 7131192: BigInteger.doubleValue() is depressingly slow

On 2013-06-20, at 4:53 PM, Martin Buchholz wrote: > I am an openjdk Reviewer, and this change Looks Good To Me. > > Thanks Louis, David, Brian. > > Again I suggest we make it easier to give out reviewer bits. For example, > David may not have been making many direct contributions to openjdk,

Re: RFR 7192954+4396272: Fix Float.parseFloat to round correctly and preserve monotonicity

Hi Martin, On Jun 20, 2013, at 4:24 PM, Martin Buchholz wrote: > This change Looks Good To Me. Cool - thanks! > It would be good in future to cc the contributors. Good point. It probably is best not to assume that everyone is on core-libs-dev. > Just to show that I'm paying attention, add an

Re: RFR (2nd round) 8009736: Comparator API cleanup

On 06/20/2013 03:45 PM, Michael Hixson wrote: > + return new NullComparator(nullFirst, real == null ? null : > real.thenComparing(other)); > > Should that be "other" instead of the second "null", like this? > > + return new NullComparator(nullFirst, real == null ? other : > real.thenComparing(oth

hg: jdk8/tl/langtools: 8007546: ClassCastException on JSR308 tests; ...

Changeset: e9ebff1840e5 Author:emc Date: 2013-06-20 19:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9ebff1840e5 8007546: ClassCastException on JSR308 tests 8015993: jck-compiler tests are failed with java.lang.ClassCastException Summary: Fix ClassCastExceptions ar

Re: RFR (2nd round) 8009736: Comparator API cleanup

+ return new NullComparator(nullFirst, real == null ? null : real.thenComparing(other)); Should that be "other" instead of the second "null", like this? + return new NullComparator(nullFirst, real == null ? other : real.thenComparing(other)); Also, if Comparator.nullsFirst(null) and nullsLast(nu

Re: RFR (2nd round) 8009736: Comparator API cleanup

On 06/20/2013 09:50 AM, Ivan Gerasimov wrote: >>Returns a comparator compares {@link Comparable} type in natural order. > > Shouldn't be "Returns a comparator that compares"? > Fixed, I updated the webrev with this and a minor update for NullComparator. The difference from previous webrev is in

Re: RFR 7131192: BigInteger.doubleValue() is depressingly slow

Hi Martin, On Jun 20, 2013, at 1:53 PM, Martin Buchholz wrote: > I am an openjdk Reviewer, and this change Looks Good To Me. Thanks For Your Review. ;-) Unfortunately this cannot be integrated before http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017958.html or its regression

RFR: 8015666: test/tools/pack200/TimeStamp.java failing

Hi, The zip time related changes[1] I pushed back last month appears to have the compatibility risk of breaking existing code. The main idea in that changeset is to use the more accurate and timezone insensitive utc time stored in the extra field for the ZipEntry.set/getTime() if possible. Howeve

hg: jdk8/tl/jdk: 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx)

Changeset: bf2bacf934d1 Author:chegar Date: 2013-06-20 18:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2bacf934d1 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx) Reviewed-by: alanb, chegar Contributed-by: John Zavgren , Chris Hegarty ! src/solaris/nati

Re: RFR (2nd round) 8009736: Comparator API cleanup

Returns a comparator compares {@link Comparable} type in natural order. Shouldn't be "Returns a comparator that compares"? Sincerely, Ivan On 19.06.2013 21:29, Henry Jen wrote: A ping to wake up the thread, there is a minor update regard the use of @apiNote since last email. Thanks in advanc

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 49b78ec058fb Author:mduigou Date: 2013-06-20 07:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49b78ec058fb 8017088: Map/HashMap.compute() incorrect with key mapping to null value Reviewed-by: dl, dholmes, plevart ! src/share/classes/java/util/HashMap.java ! sr

Re: RFR 7131192: BigInteger.doubleValue() is depressingly slow

Not a reviewer, but depressingly much experience hacking Java FP. It all looks right to me (i.e., exponent extraction and rounding modes including the round-up carry to the next higher power of two) and I like the comments explaining the little hacks, and I trust the testing to smoke out fencep

Re: RFR : 7129185 : (L) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}

I'm not a reviewer, but I am happy to see that you always print the random seed, and not just in the case of graceful test failure -- because otherwise if the VM crashes, too bad for the poor fool who has to try to reproduce that. David On 2013-06-18, at 8:59 PM, Mike Duigou wrote: > I have n

hg: jdk8/tl/jdk: 8017157: catch more exception in test RejectClientRenego

Changeset: a44bd993ce93 Author:xuelei Date: 2013-06-20 07:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44bd993ce93 8017157: catch more exception in test RejectClientRenego Reviewed-by: vinnie ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectCli

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

Yes, a fine idea. Rémi On 06/20/2013 11:44 AM, Stephen Colebourne wrote: Like others, I would prefer isNotNull() to notNull(). Mainly for consistency, but also for dicoverability is IDE autocomplete (as the methods would then be next to one another) Stephen On 30 April 2013 23:45, Mike Duigou

Re: RFR: JDK-8014045 - test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently

On 6/20/13 12:50 PM, Daniel Fuchs wrote: > Right. I have changed the test to temporarily retrieve the named loggers > and keep them in an HashMap - this way they should not be gc'ed. Wrong URL, sorry: -- daniel

Re: RFR: JDK-8014045 - test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently

On 6/19/13 8:25 PM, Mandy Chung wrote: On 6/19/13 2:00 AM, Daniel Fuchs wrote: On 6/13/13 10:05 PM, Mandy Chung wrote: Daniel, I wonder what the list of logger names (loggers1 and loggers2) returned by LoggingMXBean contains and that may include loggers in the running VM other than the ones cr

hg: jdk8/tl/jdk: 8016139: PrimitiveIterator.forEachRemaining

Changeset: 562f5cf13a9c Author:psandoz Date: 2013-06-20 11:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/562f5cf13a9c 8016139: PrimitiveIterator.forEachRemaining Reviewed-by: alanb ! src/share/classes/java/util/PrimitiveIterator.java

Re: RFR: JDK-7184195 - java.util.logging.Logger.getGlobal().info() doesn't log without configuration

Hi, Here is a second revision. I have added a TestGetGlobalConcurrent.java test which is somewhat similar to the other TestGetGlobal and TestGetGlobal2 tests - excepts that it creates multiple concurrent threads which will race to init

Re: RFR : 8013712 : (XS) Add Objects.nonNull and Objects.isNull

Like others, I would prefer isNotNull() to notNull(). Mainly for consistency, but also for dicoverability is IDE autocomplete (as the methods would then be next to one another) Stephen On 30 April 2013 23:45, Mike Duigou wrote: > Hello all; > > Another changeset coming from the lambda libraries

hg: jdk8/tl/jdk: 8016455: Sync stream tests from lambda to tl

Changeset: f758d7c24396 Author:psandoz Date: 2013-06-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f758d7c24396 8016455: Sync stream tests from lambda to tl Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! test/java/util/stream/bootlib/java/util/s

hg: jdk8/tl/jdk: 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink

Changeset: 85524d9839dc Author:psandoz Date: 2013-06-20 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85524d9839dc 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink Reviewed-by: chegar, mduigou Contributed-by: Brian Goetz ! src/s

hg: jdk8/tl/jdk: 8016308: Updates to j.u.stream.Node/Nodes

Changeset: 656ea2349aa5 Author:psandoz Date: 2013-06-20 10:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/656ea2349aa5 8016308: Updates to j.u.stream.Node/Nodes Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/Node.java

hg: jdk8/tl/langtools: 8016613: javac should avoid source 8 only analysis when compiling for source 7

Changeset: 6debfa63a4a1 Author:vromero Date: 2013-06-20 08:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6debfa63a4a1 8016613: javac should avoid source 8 only analysis when compiling for source 7 Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com ! sr

Re: RFR: 8017088 : (s) Map/HashMap.compute() incorrect with key mapping to null value

On 06/20/2013 02:22 AM, Mike Duigou wrote: Hello all; This is a fix to the Map.compute() default method and HashMap.compute() implementation to correct the handling of keys mapped to null values when the function returns null. This situation should result in the key being removed but it was n

Re: RFR (2nd round) 8009736: Comparator API cleanup

On Jun 19, 2013, at 7:29 PM, Henry Jen wrote: > A ping to wake up the thread, there is a minor update regard the use of > @apiNote since last email. > > Thanks in advance for reviewing. > Looks good. Paul. > Cheers, > Henry > > > On 06/15/2013 04:28 PM, Henry Jen wrote: >> Reflecting fee

Re: RFR 4641897: Faster string conversion of large integers

Hi Brain, I believe that you can reuse "zeros" array which is declared in the class to improve: // Pad with internal zeros if necessary. // Don't pad if we're at the beginning of the string. if ((s.length() < digits) && (sb.length() > 0)) for (int i=s.length(); i 0) f