Hi,
This version seems correct. Maybe just replace double volatile read at
length re-check with a single one:
private static BigInteger getRadixConversionCache(int radix, int
exponent) {
BigInteger[] cacheLine = powerCache[radix]; // volatile read
if (exponent < cacheLin
On 27/06/2013 05:37, Brad Wetmore wrote:
Brent/Alan/Mike,
Hashing.java was removed from the JDK workspace, but was not removed
from the old java/java/FILES_java.gmk. Things that still depend on
the old build (JCE/deploy) are currently broken.
http://cr.openjdk.java.net/~wetmore/8019227/webr
>> Specifically, I was referred to how C handles "%0.4f\n".
No width, decimal truncated (rounded? floored? I forgot which it is) to four
digits.
-DrD-
>>printf("%0.4f\n", 56789.456789F);
...
>> 56789.4570
> ^ ^ ^ ^ ^ ^ ^ ^
...
> "A leading zero in the width value is interpreted as the z
Changeset: ac65905883a7
Author:darcy
Date: 2013-06-26 22:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac65905883a7
8019228: Fix doclint issues in java.util.zip
Reviewed-by: sherman, mchung
! src/share/classes/java/util/zip/Deflater.java
! src/share/classes/java/util/zip
Changeset: c674b396827c
Author:emc
Date: 2013-06-27 00:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c674b396827c
8014230: Compilation incorrectly succeeds with inner class constructor with 254
parameters
Summary: The compiler does not account fr extra parameters d
Looks fine to me.
Mandy
On 6/26/2013 6:23 PM, Joe Darcy wrote:
Hello,
The java.util.zip package has a few remaining doctlint warnings; the
patch below removes them.
Thanks,
-Joe
diff -r 1fda8fa7ae97 src/share/classes/java/util/zip/Deflater.java
--- a/src/share/classes/java/util/zip/Deflat
looks fine. thanks for taking care of this.
-Sherman
On 6/26/13 6:23 PM, Joe Darcy wrote:
Hello,
The java.util.zip package has a few remaining doctlint warnings; the
patch below removes them.
Thanks,
-Joe
diff -r 1fda8fa7ae97 src/share/classes/java/util/zip/Deflater.java
--- a/src/share/c
Brent/Alan/Mike,
Hashing.java was removed from the JDK workspace, but was not removed
from the old java/java/FILES_java.gmk. Things that still depend on the
old build (JCE/deploy) are currently broken.
http://cr.openjdk.java.net/~wetmore/8019227/webrev.00/
Brad
P.S. I'm very aware that we
Changeset: 4fe5aab73bb2
Author:bpatel
Date: 2013-06-26 20:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fe5aab73bb2
8007338: Method grouping tab line-folding
Reviewed-by: jjg
!
src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css
! te
Changeset: 36e8bc1907a2
Author:bpatel
Date: 2013-06-26 20:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/36e8bc1907a2
8013738: Two javadoc tests have bug 000
Reviewed-by: jjg
! test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java
! test/com/sun/java
Changeset: 27bd6a2302f6
Author:bpatel
Date: 2013-06-26 20:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27bd6a2302f6
8014017: extra space in javadoc class heading
Reviewed-by: jjg
!
src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.jav
Changeset: a5aa57eb85b6
Author:darcy
Date: 2013-06-26 19:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5aa57eb85b6
8019223: Fix doclint warnings in java.rmi.server
Reviewed-by: smarks
! src/share/classes/java/rmi/server/RMIClassLoader.java
Hello,
The java.util.zip package has a few remaining doctlint warnings; the
patch below removes them.
Thanks,
-Joe
diff -r 1fda8fa7ae97 src/share/classes/java/util/zip/Deflater.java
--- a/src/share/classes/java/util/zip/Deflater.javaWed Jun 26
13:24:13 2013 -0700
+++ b/src/share/classes
Changeset: 3b2e10524627
Author:jjg
Date: 2013-06-26 18:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627
8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases
with min/max values
Reviewed-by: jjg, darcy
Contributed-by: matherey.nu..
Changeset: 1fda8fa7ae97
Author:darcy
Date: 2013-06-26 13:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fda8fa7ae97
7018139: Fix HTML accessibility and doclint issues in java.math
Reviewed-by: lancea, bpb
! src/share/classes/java/math/BigDecimal.java
! src/share/classes/
Hi Joe,
Looks fine
Best
Lance
On Jun 26, 2013, at 3:21 PM, Joe Darcy wrote:
> Hello,
>
> Please review the changes in the patch below; these change address the
> doclint and HTML accessibility issues in java.math.
>
> I'll find an existing bug or if one is not present, file a new bug to cove
Hi Joe,
On Jun 26, 2013, at 12:21 PM, Joe Darcy wrote:
> Please review the changes in the patch below; these change address the
> doclint and HTML accessibility issues in java.math.
Looks good to me but I am not a Reviewer.
> I'll find an existing bug or if one is not present, file a new bug t
Hello,
Please review the changes in the patch below; these change address the
doclint and HTML accessibility issues in java.math.
I'll find an existing bug or if one is not present, file a new bug to
cover this work.
Thanks,
-Joe
diff -r 336e5a862013 src/share/classes/java/math/BigDecimal
Changeset: c2d9303c3477
Author:ksrini
Date: 2013-06-26 09:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2d9303c3477
8016908: TEST_BUG: removing non-ascii characters causes tests to fail
Reviewed-by: jjg, vromero
! test/tools/javac/api/6437999/T6437999.java
- test/
Can I get a capital-R review on this so I can put it through?
On 06/24/13 17:28, Aleksey Shipilev wrote:
> Forgot to reply: I'm ok with webrev.01.
>
> -Aleksey
> (rural r reviewer)
>
> On 06/24/2013 11:20 PM, Eric McCorkle wrote:
>> Pinging this RFR. It still needs a capital R reviewer.
>> http
Changeset: 336e5a862013
Author:naoto
Date: 2013-06-26 11:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336e5a862013
8017322: java/util/Currency/PropertiesTest.sh should run exclusively
Reviewed-by: alanb
! test/TEST.ROOT
So do we have consensus on this version?
Thanks for the lively "conversation."
Brian
On Jun 26, 2013, at 12:05 AM, Aleksey Shipilev wrote:
> Yes, like that.
>
> -Aleksey
>
> On 26.06.2013, at 10:53, Dmitry Nadezhin wrote:
>
>>> We could check for the existing cacheLine.length right before i
For further comparison, the man page for PRINTF(1) on Mac OS 10.7.5 states
Field Width:
An optional digit string specifying a field width; if the output
string has fewer characters than the field width it will be
blank-padded on the left (or right, if th
On Jun 26, 2013, at 9:37 AM, Joe Darcy wrote:
> Specifically, I was referred to how C handles "%0.4f\n".
On 6/24/2013 12:56 PM, Brian Burkhalter wrote:
>
> By way of comparison, this C code
>
> printf("%1.4f\n", 56789.456789F);
> printf("%0.4f\n", 56789.456789F);
>
> prints this outpu
Sending this on to core-libs-dev to try to get a response ;-)
Stephen
On 24 June 2013 16:14, Stephen Colebourne wrote:
> One point lambdaification that I haven't seen mentioned is addition
> static factory methods for the main collection interfaces. (Strictly,
> this proposal is not point lambdai
On 6/25/2013 9:07 AM, Brian Burkhalter wrote:
On Jun 24, 2013, at 9:25 PM, Joe Darcy wrote:
"Requires the output to be padded with leading zeros to the minimum field width
following any sign or radix indicator except when converting NaN or infinity. If the
width is not provided, then a Missi
Changeset: 71059bca036a
Author:rfield
Date: 2013-06-26 07:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71059bca036a
8016761: Lambda metafactory - incorrect type conversion of constructor method
handle
Reviewed-by: jrose
! src/share/classes/java/lang/invoke/InnerClassLa
Changeset: e83cdd58f1cf
Author:chegar
Date: 2013-06-26 15:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83cdd58f1cf
8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum)
Reviewed-by: chegar, alanb, psandoz
Contributed-by: Doug Lea , Tristan Yan
, Chris H
I will add this into ProblemList.txt when I come in.
On 6/26/13 7:26 AM, Eric McCorkle wrote:
That would be preferable to modifying the test, I think.
At this point, consider my proposed fix withdrawn, and someone should
push a change to add this test to ProblemList.txt in the immediate term.
That would be preferable to modifying the test, I think.
At this point, consider my proposed fix withdrawn, and someone should
push a change to add this test to ProblemList.txt in the immediate term.
On 06/25/13 15:56, Chris Hegarty wrote:
> On 06/25/2013 08:45 PM, Xueming Shen wrote:
>> The prop
Changeset: 0822bcddbd4f
Author:xuelei
Date: 2013-06-26 06:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0822bcddbd4f
8017049: rename property jdk.tls.rejectClientInitializedRenego
Reviewed-by: vinnie, wetmore, mullan
! src/share/classes/sun/security/ssl/Handshaker.java
!
The streams package recently added tests for exercising package-private
implementation.
Top level dir contain the TEST.properties to add to the bootclasspath:
http://hg.openjdk.java.net/jdk8/tl/jdk/file/510035b7/test/java/util/stream/boottest/
Example, individual test, whose test is in th
Remi Forax wrote:
On 06/26/2013 03:10 AM, Dr Heinz M. Kabutz wrote:
Hi Peter,
here is another use case, where someone might want to use this:
3 - in a static context, find out what the class is that you are in.
For example, if you want to create a logger, instead of doing this:
private sta
On 06/26/2013 03:10 AM, Dr Heinz M. Kabutz wrote:
Hi Peter,
here is another use case, where someone might want to use this:
3 - in a static context, find out what the class is that you are in.
For example, if you want to create a logger, instead of doing this:
private static final Logger log
HI Henry,
I think this is good to push, and we can tweak other stuff as required with
further commits.
I can push for you if you like.
Paul.
On Jun 26, 2013, at 9:55 AM, Henry Jen wrote:
> Hi,
>
> Thanks for all the reviewing, hopefully this would be the last round as
> we addressed feedbac
Hi,
Thanks for all the reviewing, hopefully this would be the last round as
we addressed feedbacks.
Mostly the difference from last round is javadoc[1], the only code
change[2] is that we override the default method of
Comparator.reversed() for natural/reverse order comparator in
Collections and
Yes, like that.
-Aleksey
On 26.06.2013, at 10:53, Dmitry Nadezhin wrote:
>> We could check for the existing cacheLine.length right before installing
> the new one
>
> Do you mean something like this ?
>
> BigInteger getRadixConversionCache(int radix, int exponent) {
> BigInteger[] cacheLine
37 matches
Mail list logo
