hg: jdk8/tl/jdk: 8009736: Comparator API cleanup

2013-06-28 Thread paul . sandoz
Changeset: c1df54fd19b2 Author:henryjen Date: 2013-06-11 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1df54fd19b2 8009736: Comparator API cleanup Reviewed-by: psandoz, briangoetz, mduigou, plevart ! src/share/classes/java/util/Collections.java ! src/share/classes/ja

hg: jdk8/tl/jdk: 8012987: Optimizations for Stream.limit/substream

2013-06-28 Thread paul . sandoz
Changeset: 28b71c97a72d Author:psandoz Date: 2013-06-28 10:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28b71c97a72d 8012987: Optimizations for Stream.limit/substream Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/A

hg: jdk8/tl/langtools: 8016760: Failure of regression test langtools/tools/javac/T6725036.java

2013-06-28 Thread eric . mccorkle
Changeset: 6101e52ce9e3 Author:emc Date: 2013-06-28 06:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6101e52ce9e3 8016760: Failure of regression test langtools/tools/javac/T6725036.java Summary: Marking the failing test @ignore; the proposed change for 8015666 addr

hg: jdk8/tl/langtools: 6473148: TreePath.iterator() should document the iteration order

2013-06-28 Thread vicente . romero
Changeset: bb06c412d079 Author:vromero Date: 2013-06-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079 6473148: TreePath.iterator() should document the iteration order Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/TreePath.java

RFR 8019370: Sync j.u.c Fork/Join from 166 to tl

2013-06-28 Thread Paul Sandoz
Hi, This webrev contains updates of java.util.concurrent Fork/Join, executors, and related classes from 166: http://cr.openjdk.java.net/~psandoz/tl/JDK-8019370-fork-join/webrev/ There are also various doc updates/fixes included. Most of this code has been in the lambda repo for quite a while

Re: Question on HashMap change in 8011200

2013-06-28 Thread Alan Bateman
On 27/06/2013 22:13, Remi Forax wrote: On 06/27/2013 10:02 AM, Shi Jun Zhang wrote: Hi, There are some isEmpty() check added into get/remove methods since 8011200 to return directly if HashMap is empty. However isEmpty is a non-final public method which can be overridden by subclass. If the

hg: jdk8/tl/langtools: 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string

2013-06-28 Thread vicente . romero
Changeset: bdd699d7378d Author:vromero Date: 2013-06-28 14:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string Reviewed-by: mcimadamore ! src/share/classes/com/sun/t

hg: jdk8/tl/jdk: 8019155: Update makefiles with correct jfr packages

2013-06-28 Thread staffan . larsen
Changeset: 19a6d2d701d9 Author:sla Date: 2013-06-26 19:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19a6d2d701d9 8019155: Update makefiles with correct jfr packages Reviewed-by: mgronlun, erikj ! make/common/Release.gmk ! makefiles/CreateJars.gmk

Re: RFR: 8015666: test/tools/pack200/TimeStamp.java failing

2013-06-28 Thread Kumar Srinivasan
Some nits while reading the changes: 1. ZipEntry.java a. typo: + * Sets the laste access time of the entry. b. extra space +case EXTID_ZIP64 : 2. ZipOutputStream.java I think it would be nice to have the flags 0x1, 0x2 and 0x4 defined as constants, this will also hel

hg: jdk8/tl/jdk: 8019380: doclint warnings in java.nio, java.nio.file.**, java.nio.channels.**

2013-06-28 Thread alan . bateman
Changeset: 04378a645944 Author:alanb Date: 2013-06-28 16:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04378a645944 8019380: doclint warnings in java.nio, java.nio.file.**, java.nio.channels.** Reviewed-by: chegar ! src/share/classes/java/nio/Buffer.java ! src/share/clas

Re: RFR 8019370: Sync j.u.c Fork/Join from 166 to tl

2013-06-28 Thread Chris Hegarty
Thanks for doing this Paul. I don't see anything objectionable, after a cursory look. We can have added confidence, since the changes against lambda are much smaller. -Chris. On 06/28/2013 01:22 PM, Paul Sandoz wrote: Hi, This webrev contains updates of java.util.concurrent Fork/Join, exec

Re: Question on HashMap change in 8011200

2013-06-28 Thread Shi Jun Zhang
On 6/28/2013 9:02 PM, Alan Bateman wrote: On 27/06/2013 22:13, Remi Forax wrote: On 06/27/2013 10:02 AM, Shi Jun Zhang wrote: Hi, There are some isEmpty() check added into get/remove methods since 8011200 to return directly if HashMap is empty. However isEmpty is a non-final public method wh

hg: jdk8/tl/jdk: 4 new changesets

2013-06-28 Thread chris . hegarty
Changeset: 1919c226b427 Author:dl Date: 2013-06-28 12:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1919c226b427 8017739: ReentrantReadWriteLock is confused by the Threads with reused IDs Reviewed-by: chegar ! src/share/classes/java/util/concurrent/locks/ReentrantReadWri

Re: RFR 8019370: Sync j.u.c Fork/Join from 166 to tl

2013-06-28 Thread Paul Sandoz
On Jun 28, 2013, at 6:01 PM, Chris Hegarty wrote: > Thanks for doing this Paul. I don't see anything objectionable, after a > cursory look. > Thanks. > We can have added confidence, since the changes against lambda are much > smaller. > Plus i ran a jprt job (for this and the previous rela

RFR: 8017174 - NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

2013-06-28 Thread Daniel Fuchs
Hi, Please find below a patch for jdk8 for: 8017174 - NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger The issue was that the lazy initialization of LoggerContext was not working correctly - lead

Re: RFR: JDK-8014045 - test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently

2013-06-28 Thread Mandy Chung
Hi Daniel, On 6/20/2013 3:50 AM, Daniel Fuchs wrote: Right. I have changed the test to temporarily retrieve the named loggers and keep them in an HashMap - this way they should not be gc'ed. This looks good. This is a better approac

hg: jdk8/tl/jdk: 8019360: Cleanup of the javadoc tag in java.security.*

2013-06-28 Thread jason . uh
Changeset: 389f59e6288f Author:juh Date: 2013-06-28 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/389f59e6288f 8019360: Cleanup of the javadoc tag in java.security.* Summary: Convert to {@code ...} tags. convert package.html to package-info.java. Reviewed-by: darcy !

JDK 8 code review request for doclint cleanup of javax.naming.*

2013-06-28 Thread Joe Darcy
Hello, Still more doclint fixes for review below; this time to javax.naming.*. Thanks, -Joe --- a/src/share/classes/javax/naming/CompositeName.javaFri Jun 28 16:39:15 2013 +0100 +++ b/src/share/classes/javax/naming/CompositeName.javaFri Jun 28 10:54:12 2013 -0700 @@ -1,5 +1,5 @@ /*

Re: JDK 8 code review request for doclint cleanup of javax.naming.*

2013-06-28 Thread Lance Andersen - Oracle
Hi Joe, Looks good. fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy. Not sure if it matters below but thought I would point it out if you want a smaller heading Best Lance On Jun 28, 2013, at 1:54 PM, Joe Darcy wrote: > Hello, > > Still more doclint fixes for re

Refresh - Java 8 RFR 8017540: Improve multi-threaded contention behavior of BigInteger.toString() radix conversion cache

2013-06-28 Thread Brian Burkhalter
This Request for Review is a refresh of this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018337.html pertaining to this issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017540 The webrev has been updated in the same location http://cr.openjdk.java.net/~bpb/80

Re: JDK 8 code review request for doclint cleanup of javax.naming.*

2013-06-28 Thread Joe Darcy
Hi Lance, Thanks for review; I'll leave the tags in for now. Cheers, -Joe On 06/28/2013 11:13 AM, Lance Andersen - Oracle wrote: Hi Joe, Looks good. fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy. Not sure if it matters below but thought I would point it out

hg: jdk8/tl/jdk: 8019384: jps and jcmd tests fail when there is a process started with a .war file

2013-06-28 Thread alan . bateman
Changeset: 389b8739a74e Author:alanb Date: 2013-06-28 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/389b8739a74e 8019384: jps and jcmd tests fail when there is a process started with a .war file Reviewed-by: dcubed, sla, mchung ! test/sun/tools/jcmd/jcmd_Output1.awk

Java 8 RFR: 6178739 - Formatter - Zero padding flag with zero width

2013-06-28 Thread Brian Burkhalter
Continuing this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018326.html with respect to this issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178739 this Request for Review proposes the following change to the Formatter javadoc specification: diff -r 8d577b3

Re: RFR: JDK-7184195 - java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2013-06-28 Thread Mandy Chung
Hi Daniel, On 6/19/2013 8:31 AM, Daniel Fuchs wrote: The fix proposed is simple. In getGlobal() we check whether the 'manager' variable is null - and if it is, we initialize it by calling LogManager.getLogManager(). This is a pattern which is already present at other places in the Logger.java cl

hg: jdk8/tl/jdk: 8019407: Fix doclint issues in javax.naming.*

2013-06-28 Thread joe . darcy
Changeset: 9d175c6cb527 Author:darcy Date: 2013-06-28 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d175c6cb527 8019407: Fix doclint issues in javax.naming.* Reviewed-by: lancea ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/Comp

Review needed for ResultSet.next typo bug 8019286

2013-06-28 Thread Lance Andersen - Oracle
Hi, Looking for a reviewer for this minor typo in ResultSet.next() $ hg diff diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10:21:22 2013 +0100 +++ b/src/share/classes/java/sql/ResultSet.java Fri Jun 28 18:09:36 2013 -0400

Re: RFR: 8017174 - NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

2013-06-28 Thread Mandy Chung
On 6/28/2013 9:32 AM, Daniel Fuchs wrote: Hi, Please find below a patch for jdk8 for: 8017174 - NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger The issue was that the lazy initialization of Log

Re: Review needed for ResultSet.next typo bug 8019286

2013-06-28 Thread Mandy Chung
Thumbs up. s/froward/forward :) Mandy On 6/28/2013 3:21 PM, Lance Andersen - Oracle wrote: Hi, Looking for a reviewer for this minor typo in ResultSet.next() $ hg diff diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10

Re: Review needed for ResultSet.next typo bug 8019286

2013-06-28 Thread Joe Darcy
Looks fine Lance; approved. Cheers, -Joe On 06/28/2013 03:21 PM, Lance Andersen - Oracle wrote: Hi, Looking for a reviewer for this minor typo in ResultSet.next() $ hg diff diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Thu Jun

RFR: 8015315: Stream.concat methods

2013-06-28 Thread Henry Jen
Hi, Please review the webrev that add concat static method to Stream and primitive Streams. http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/ Cheers, Henry

hg: jdk8/tl/corba: 3 new changesets

2013-06-28 Thread lana . steuck
Changeset: c68c35f50413 Author:katleman Date: 2013-06-20 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c68c35f50413 Added tag jdk8-b95 for changeset 2cf36f43df36 ! .hgtags Changeset: 3357c2776431 Author:lana Date: 2013-06-24 14:26 -0700 URL: http://h

hg: jdk8/tl: 11 new changesets

2013-06-28 Thread lana . steuck
Changeset: c961c8972485 Author:erikj Date: 2013-06-13 14:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c961c8972485 8014231: --with-alsa configuration options don't add include or lib directories to proper flags Reviewed-by: tbell ! common/autoconf/spec.gmk.in Changeset: 0

hg: jdk8/tl/nashorn: 4 new changesets

2013-06-28 Thread lana . steuck
Changeset: b031efa535ad Author:katleman Date: 2013-06-20 10:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b031efa535ad Added tag jdk8-b95 for changeset cbc9926f5b40 ! .hgtags Changeset: d6bd440ac5b9 Author:lana Date: 2013-06-24 14:26 -0700 URL: http:/

hg: jdk8/tl/jaxws: 3 new changesets

2013-06-28 Thread lana . steuck
Changeset: 7de08fa7cb34 Author:katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7de08fa7cb34 Added tag jdk8-b95 for changeset 1468c94135f9 ! .hgtags Changeset: 690d34b326bc Author:lana Date: 2013-06-24 14:27 -0700 URL: http://h

hg: jdk8/tl/jaxp: 3 new changesets

2013-06-28 Thread lana . steuck
Changeset: e68a5d2efcae Author:katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e68a5d2efcae Added tag jdk8-b95 for changeset b8c5f4b6f0ff ! .hgtags Changeset: 6121efd29923 Author:lana Date: 2013-06-24 14:27 -0700 URL: http://hg

hg: jdk8/tl/hotspot: 46 new changesets

2013-06-28 Thread lana . steuck
Changeset: aaa45012be98 Author:katleman Date: 2013-06-20 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aaa45012be98 Added tag jdk8-b95 for changeset 5d65c078cd0a ! .hgtags Changeset: 38e483cb1bcd Author:lana Date: 2013-06-24 14:27 -0700 URL: http:/

hg: jdk8/tl/langtools: 5 new changesets

2013-06-28 Thread lana . steuck
Changeset: 3478b1e81baf Author:katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3478b1e81baf Added tag jdk8-b95 for changeset 4cb113623127 ! .hgtags Changeset: b3458329d060 Author:lana Date: 2013-06-24 14:27 -0700 URL: http

hg: jdk8/tl/jdk: 34 new changesets

2013-06-28 Thread lana . steuck
Changeset: 3531945431aa Author:erikj Date: 2013-06-13 14:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3531945431aa 8014231: --with-alsa configuration options don't add include or lib directories to proper flags Reviewed-by: tbell ! makefiles/CompileNativeLibraries.gmk