Changeset: c1df54fd19b2
Author:henryjen
Date: 2013-06-11 13:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1df54fd19b2
8009736: Comparator API cleanup
Reviewed-by: psandoz, briangoetz, mduigou, plevart
! src/share/classes/java/util/Collections.java
!
Changeset: 28b71c97a72d
Author:psandoz
Date: 2013-06-28 10:29 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28b71c97a72d
8012987: Optimizations for Stream.limit/substream
Reviewed-by: mduigou
Contributed-by: Brian Goetz brian.go...@oracle.com, Paul Sandoz
Changeset: 6101e52ce9e3
Author:emc
Date: 2013-06-28 06:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6101e52ce9e3
8016760: Failure of regression test langtools/tools/javac/T6725036.java
Summary: Marking the failing test @ignore; the proposed change for 8015666
Changeset: bb06c412d079
Author:vromero
Date: 2013-06-28 13:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079
6473148: TreePath.iterator() should document the iteration order
Reviewed-by: mcimadamore
! src/share/classes/com/sun/source/util/TreePath.java
Hi,
This webrev contains updates of java.util.concurrent Fork/Join, executors, and
related classes from 166:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8019370-fork-join/webrev/
There are also various doc updates/fixes included.
Most of this code has been in the lambda repo for quite a
On 27/06/2013 22:13, Remi Forax wrote:
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
Hi,
There are some isEmpty() check added into get/remove methods since
8011200 to return directly if HashMap is empty. However isEmpty is a
non-final public method which can be overridden by subclass. If the
Changeset: bdd699d7378d
Author:vromero
Date: 2013-06-28 14:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d
8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect
format string
Reviewed-by: mcimadamore
!
Changeset: 19a6d2d701d9
Author:sla
Date: 2013-06-26 19:15 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19a6d2d701d9
8019155: Update makefiles with correct jfr packages
Reviewed-by: mgronlun, erikj
! make/common/Release.gmk
! makefiles/CreateJars.gmk
Some nits while reading the changes:
1. ZipEntry.java
a. typo:
+ * Sets the laste access time of the entry.
b. extra space
+case EXTID_ZIP64 :
2. ZipOutputStream.java
I think it would be nice to have the flags 0x1, 0x2 and 0x4 defined
as constants, this will also
Changeset: 04378a645944
Author:alanb
Date: 2013-06-28 16:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04378a645944
8019380: doclint warnings in java.nio, java.nio.file.**, java.nio.channels.**
Reviewed-by: chegar
! src/share/classes/java/nio/Buffer.java
!
Thanks for doing this Paul. I don't see anything objectionable, after a
cursory look.
We can have added confidence, since the changes against lambda are much
smaller.
-Chris.
On 06/28/2013 01:22 PM, Paul Sandoz wrote:
Hi,
This webrev contains updates of java.util.concurrent Fork/Join,
On 6/28/2013 9:02 PM, Alan Bateman wrote:
On 27/06/2013 22:13, Remi Forax wrote:
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
Hi,
There are some isEmpty() check added into get/remove methods since
8011200 to return directly if HashMap is empty. However isEmpty is a
non-final public method
Changeset: 1919c226b427
Author:dl
Date: 2013-06-28 12:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1919c226b427
8017739: ReentrantReadWriteLock is confused by the Threads with reused IDs
Reviewed-by: chegar
!
On Jun 28, 2013, at 6:01 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Thanks for doing this Paul. I don't see anything objectionable, after a
cursory look.
Thanks.
We can have added confidence, since the changes against lambda are much
smaller.
Plus i ran a jprt job (for this
Hi,
Please find below a patch for jdk8 for:
8017174 - NPE when using Logger.getAnonymousLogger or
LogManager.getLogManager().getLogger
http://cr.openjdk.java.net/~dfuchs/JDK-8017174/webrev-jdk8.00/
The issue was that the lazy initialization of LoggerContext was
not working correctly -
Hi Daniel,
On 6/20/2013 3:50 AM, Daniel Fuchs wrote:
Right. I have changed the test to temporarily retrieve the named loggers
and keep them in an HashMap - this way they should not be gc'ed.
http://cr.openjdk.java.net/~dfuchs/JDK-8014045/webrev.01/
This looks good. This is a better approach
Changeset: 389f59e6288f
Author:juh
Date: 2013-06-28 10:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/389f59e6288f
8019360: Cleanup of the javadoc code tag in java.security.*
Summary: Convert to {@code ...} tags. convert package.html to package-info.java.
Reviewed-by:
Hello,
Still more doclint fixes for review below; this time to javax.naming.*.
Thanks,
-Joe
--- a/src/share/classes/javax/naming/CompositeName.javaFri Jun 28
16:39:15 2013 +0100
+++ b/src/share/classes/javax/naming/CompositeName.javaFri Jun 28
10:54:12 2013 -0700
@@ -1,5 +1,5 @@
Hi Joe,
Looks good.
fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy.
Not sure if it matters below but thought I would point it out if you want a
smaller heading
Best
Lance
On Jun 28, 2013, at 1:54 PM, Joe Darcy wrote:
Hello,
Still more doclint fixes for
This Request for Review is a refresh of this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018337.html
pertaining to this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017540
The webrev has been updated in the same location
Hi Lance,
Thanks for review; I'll leave the H1 tags in for now.
Cheers,
-Joe
On 06/28/2013 11:13 AM, Lance Andersen - Oracle wrote:
Hi Joe,
Looks good.
fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy.
Not sure if it matters below but thought I would point it
Changeset: 389b8739a74e
Author:alanb
Date: 2013-06-28 19:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/389b8739a74e
8019384: jps and jcmd tests fail when there is a process started with a .war
file
Reviewed-by: dcubed, sla, mchung
! test/sun/tools/jcmd/jcmd_Output1.awk
Continuing this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018326.html
with respect to this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178739
this Request for Review proposes the following change to the Formatter javadoc
specification:
diff -r
Hi Daniel,
On 6/19/2013 8:31 AM, Daniel Fuchs wrote:
The fix proposed is simple. In getGlobal() we check whether
the 'manager' variable is null - and if it is, we initialize it
by calling LogManager.getLogManager().
This is a pattern which is already present at other places in
the Logger.java
Changeset: 9d175c6cb527
Author:darcy
Date: 2013-06-28 11:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d175c6cb527
8019407: Fix doclint issues in javax.naming.*
Reviewed-by: lancea
! src/share/classes/javax/naming/CompositeName.java
!
Hi,
Looking for a reviewer for this minor typo in ResultSet.next()
$ hg diff
diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10:21:22 2013 +0100
+++ b/src/share/classes/java/sql/ResultSet.java Fri Jun 28 18:09:36 2013
On 6/28/2013 9:32 AM, Daniel Fuchs wrote:
Hi,
Please find below a patch for jdk8 for:
8017174 - NPE when using Logger.getAnonymousLogger or
LogManager.getLogManager().getLogger
http://cr.openjdk.java.net/~dfuchs/JDK-8017174/webrev-jdk8.00/
The issue was that the lazy initialization of
Thumbs up. s/froward/forward :)
Mandy
On 6/28/2013 3:21 PM, Lance Andersen - Oracle wrote:
Hi,
Looking for a reviewer for this minor typo in ResultSet.next()
$ hg diff
diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27
Looks fine Lance; approved.
Cheers,
-Joe
On 06/28/2013 03:21 PM, Lance Andersen - Oracle wrote:
Hi,
Looking for a reviewer for this minor typo in ResultSet.next()
$ hg diff
diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Thu Jun
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
30 matches
Mail list logo
