Hi,
Please review a simple addition of StringJoiner.merge method. This is
useful to combine StringJoiners used in parallel doing joining works.
The webrev can be found at
http://cr.openjdk.java.net/~henryjen/ccc/8017231.0/webrev/
Also included is a little clean up for StringJoinerTest.
Cheers,
Hi Henry,
I think that ConcatSpliterator.characteristics() method is not honoring
the spec which says:
* Returns a set of characteristics of this Spliterator and its
* elements. The result is represented as ORed values from {@link
* #ORDERED}, {@link #DISTINCT}, {@link #SORTED},
On Jul 3, 2013, at 10:03 AM, Henry Jen wrote:
> Hi,
>
> Please review a simple addition of StringJoiner.merge method. This is
> useful to combine StringJoiners used in parallel doing joining works.
>
> The webrev can be found at
> http://cr.openjdk.java.net/~henryjen/ccc/8017231.0/webrev/
>
On Jul 3, 2013, at 11:18 AM, Peter Levart wrote:
> Hi Henry,
>
> I think that ConcatSpliterator.characteristics() method is not honoring
> the spec which says:
>
> * Returns a set of characteristics of this Spliterator and its
> * elements. The result is represented as ORed values f
Changeset: dfd7fb0ce54b
Author:psandoz
Date: 2013-07-03 11:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfd7fb0ce54b
8011427: java.util.concurrent collection Spliterator implementations
Reviewed-by: martin
Contributed-by: Doug Lea
! src/share/classes/java/util/concurre
On 24/06/2013 19:23, Peter Levart wrote:
Hi Alan,
I have prepared the 2nd revision of the patch:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.02/
There is a little change in AnnotationParser's alternative parsing
method. This time the parser does not assume anything abou
Hello,
The patch here
http://cr.openjdk.java.net/~bpb/6480539/
is proposed to resolve this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6480539
which was most recently discussed in this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014252.html
The prop
On 03/07/2013 09:03, Henry Jen wrote:
Hi,
Please review a simple addition of StringJoiner.merge method. This is
useful to combine StringJoiners used in parallel doing joining works.
The webrev can be found at
http://cr.openjdk.java.net/~henryjen/ccc/8017231.0/webrev/
Also included is a little
When running with a security manager, ServiceLoader isn't currently very
predictable when created and used in different contexts. For the
ServiceLoader usages in the JDK then isn't a problem because all (bar
one or two uninteresting cases) involve creating the ServiceLoader and
immediately it
On 07/03/2013 06:15 PM, Alan Bateman wrote:
When running with a security manager, ServiceLoader isn't currently
very predictable when created and used in different contexts. For the
ServiceLoader usages in the JDK then isn't a problem because all (bar
one or two uninteresting cases) involve c
On Jul 3, 2013, at 9:09 AM, Alan Bateman wrote:
> On 03/07/2013 09:03, Henry Jen wrote:
>> Hi,
>>
>> Please review a simple addition of StringJoiner.merge method. This is
>> useful to combine StringJoiners used in parallel doing joining works.
>>
>> The webrev can be found at
>> http://cr.open
On 03/07/2013 17:24, Remi Forax wrote:
Hi Alan,
you can use a method reference instead a lambda here,
so
PrivilegedAction action = () -> hasNextService();
return AccessController.doPrivileged(action, acc);
can be written
return AccessController.doPrivileged(this::hasNextService, acc);
(me cr
Hi Peter,
As Alan said, a big thanks for looking into this.
I have been toying with a slightly different approach to breaking the infinite
recursion by pre-construct AnnotationType instances for Retention and
Inherited. While cleaner in some places others became uglier. I'm fine with
this appr
Hello everybody!
We have a request to improve jtreg test.
The test had been written to verify fix for memory leak during class
redefinition.
The problem is that it always is reported as PASSED even in the presence
of the leak.
The proposed change is platform specific.
It allows memory leak de
On Jul 3, 2013, at 9:57 AM, Henry Jen wrote:
>
> On Jul 3, 2013, at 9:09 AM, Alan Bateman wrote:
>
>> On 03/07/2013 09:03, Henry Jen wrote:
>>> Hi,
>>>
>>> Please review a simple addition of StringJoiner.merge method. This is
>>> useful to combine StringJoiners used in parallel doing joining
On 7/3/13 9:15 AM, Alan Bateman wrote:
When running with a security manager, ServiceLoader isn't currently
very predictable when created and used in different contexts. For the
ServiceLoader usages in the JDK then isn't a problem because all (bar
one or two uninteresting cases) involve creati
Hi Brian,
I have some concerns with this patch.
First, I think the stripTrailingZeros specification should explicitly
call out what happens with a numerically zero value.
Second, I would have expected the code change to be limited to the
stripTrailingZeros method. The private createAndStripZ
Hi Joe,
Thanks for pointing out the problems with modifying the private methods. I'll
update this only to change the one public method and to modify its
specification.
Thanks,
Brian
On Jul 3, 2013, at 10:35 AM, Joe Darcy wrote:
> I have some concerns with this patch.
>
> First, I think the
On 07/03/2013 07:01 PM, Alan Bateman wrote:
On 03/07/2013 17:24, Remi Forax wrote:
Hi Alan,
you can use a method reference instead a lambda here,
so
PrivilegedAction action = () -> hasNextService();
return AccessController.doPrivileged(action, acc);
can be written
return AccessController.do
On Jul 3, 2013, at 10:47 AM, Brian Burkhalter wrote:
> I'll update this only to change the one public method and to modify its
> specification.
I've updated the webrev
http://cr.openjdk.java.net/~bpb/6480539/
and rerun JTREG as well as modifying and resubmitting the CCC request (it had
been f
On 07/03/2013 11:09 AM, Brian Burkhalter wrote:
On Jul 3, 2013, at 10:47 AM, Brian Burkhalter wrote:
I'll update this only to change the one public method and to modify its
specification.
I've updated the webrev
http://cr.openjdk.java.net/~bpb/6480539/
and rerun JTREG as well as modifying a
On 27/06/2013 10:38, Paul Sandoz wrote:
Hi,
Please review a fix for a regression with using Stream.substream for an ORDERED
but not SUBSIZED spliterator that does not split.
This is based off:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8012987-slice/webrev/
which is blocked waiting for th
Changeset: bd6949f9dbb2
Author:twisti
Date: 2013-07-03 11:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6949f9dbb2
8019184: MethodHandles.catchException() fails when methods have 8 args + varargs
Reviewed-by: jrose
! src/share/classes/java/lang/invoke/MethodHandleImpl.
On 03/07/2013 18:56, Remi Forax wrote:
Interesting !
it's related to the way the compiler desugar lambda vs method reference.
I've not taken a look to the generated code but I think I know why the
behaviour is different.
If the code uses a lambda:
PrivilegedAction action = () -> hasNextServ
Hi,
Adapted comments from Alan and Paul, thanks for reviewing.
http://cr.openjdk.java.net/~henryjen/ccc/8017231.1/webrev/
Cheers,
Henry
Changeset: 7532bb2d6476
Author:psandoz
Date: 2013-07-03 21:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7532bb2d6476
8017329: 8b92-lambda regression: TreeSet("a",
"b").stream().substream(1).parallel().iterator() is empty
Reviewed-by: alanb
! src/share/classes/java/util
Changeset: d5de500c99a3
Author:juh
Date: 2013-07-03 12:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5de500c99a3
8019772: Fix doclint issues in javax.crypto and javax.security subpackages
Reviewed-by: darcy
! src/share/classes/javax/crypto/Cipher.java
! src/share/classe
Reviewers:
For this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019857 (should be public
"soon").
here is the proposed update
http://cr.openjdk.java.net/~bpb/8019857/
Note that the diff starting at line 2593 is to correct a warning, not an error,
and would require a CCC request
Hi Brian,
Looks good; approved to go back. The enum BigDecimalLayoutForm seems to
have escaped notice previously; since the comments being added are
"obvious", I don't think a ccc request is necessary.
Thanks for fixing these,
-Joe
On 07/03/2013 01:01 PM, Brian Burkhalter wrote:
Reviewers:
On 03/07/2013 20:46, Henry Jen wrote:
Hi,
Adapted comments from Alan and Paul, thanks for reviewing.
http://cr.openjdk.java.net/~henryjen/ccc/8017231.1/webrev/
This looks good to me.
(I see you took the suggestion to s/supplied/given. There's another one
in the add(CharSequence) method that
Yes, when I looked at it, there are other places as well. But I decided to
leave those alone as for delimiter/prefix/suffix, 'supplied' seems to be fine
and consistent.
add() is perhaps a good change. I updated the webrev with this simple change,
then I'll need a sponsor to push for me.
Cheers
These changes address bug 8014135 which adds support for statically
linked agents in the VM. This is a followup to the recent JNI spec
changes that addressed statically linked JNI libraries( 8005716).
The JEP for this change is the same JEP as the JNI changes:
http://openjdk.java.net/jeps/178
W
On 07/01/2013 02:52 AM, Remi Forax wrote:
> On 06/29/2013 02:58 AM, Henry Jen wrote:
>> Hi,
>>
>> Please review the webrev that add concat static method to Stream and
>> primitive Streams.
>>
>> http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
>>
>> Cheers,
>> Henry
>
> Hi Henry,
> I fin
Changeset: e594ee7a7c2f
Author:vinnie
Date: 2013-07-02 16:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e594ee7a7c2f
7165807: Non optimized initialization of NSS crypto library leads to
scalability issues
Reviewed-by: mullan, valeriep
! make/sun/security/pkcs11/mapfile-
Changeset: a49208237599
Author:bpb
Date: 2013-07-03 13:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a49208237599
8019857: Fix doclint errors in java.util.Format*
Summary: Fix doclint errors in java.util.Format*.
Reviewed-by: darcy
Contributed-by: Brian Burkhalter
! src
Reviewers:
For this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019862 (should be public
"soon").
here is the proposed update
http://cr.openjdk.java.net/~bpb/8019862/
Thanks,
Brian
Oops - hold off on this one pending a correction.
Thanks,
Brian
On Jul 3, 2013, at 3:21 PM, Brian Burkhalter wrote:
> Reviewers:
>
> For this issue
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019862 (should be public
> "soon").
>
> here is the proposed update
>
> http://cr.open
A few weeks ago, in the course of doing a (hopefully-last) reworking of
JDK8 ConcurrentHashMap (CHM) internals based on experience with
preview versions, I noticed that the balanced tree scheme now in place
as a fallback in the case of usages with many keys all with the same
hashCode could also b
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/
Cheers,
Henry
OK, this is ready to go now.
This error
src/share/classes/java/lang/ThreadLocal.java:139: warning: no @param for
public static ThreadLocal withInitial(Supplier
supplier) {
^
Note: src/share/classes/java/lang/Boolean.java uses unchecked or unsafe
operat
Changeset: a8f51c3341a5
Author:emc
Date: 2013-07-03 19:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8f51c3341a5
8016285: Add java.lang.reflect.Parameter.isNamePresent()
Summary: Add isNamePresent method to parameter reflection library, which
indicates whether or real p
On 07/03/2013 04:40 PM, Brian Burkhalter wrote:
OK, this is ready to go now.
This error
src/share/classes/java/lang/ThreadLocal.java:139: warning: no @param for
public static ThreadLocal withInitial(Supplier
supplier) {
^
Note: src/share/classes/jav
All right, I update the patch at the same location with the first of the
proposed corrections.
Thanks,
Brian
On Jul 3, 2013, at 4:59 PM, Joe Darcy wrote:
> However, I would recommend the first of these.
>
> Otherwise, the change looks good to go back.
>
> -Joe
>
>>
>> Brian
>>
>> On Jul 3
Changeset: 043b2eb76b0e
Author:bpb
Date: 2013-07-03 17:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/043b2eb76b0e
8019862: Fix doclint errors in java.lang.*.
Summary: Fix doclint errors in java.lang.*
Reviewed-by: darcy
Contributed-by: Brian Burkhalter
! src/share/class
Looks good to me.
iris
-Original Message-
From: Brian Burkhalter
Sent: Wednesday, July 03, 2013 1:02 PM
To: Java Core Libs
Subject: Java 8 RFR 8019857: Fix doclint errors in java.util.Format*
Reviewers:
For this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019857 (should
45 matches
Mail list logo
