This looks fine to me.
Thanks,
David
On 1/07/2013 9:51 PM, Thomas Schatzl wrote:
Hi all,
On Mon, 2013-07-01 at 15:44 +0400, Aleksey Shipilev wrote:
On 07/01/2013 03:37 PM, David Holmes wrote:
On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
The same thou shalt not do multiple volatile reads
On 1/07/2013 9:44 PM, Aleksey Shipilev wrote:
On 07/01/2013 03:37 PM, David Holmes wrote:
On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
The same thou shalt not do multiple volatile reads applies to
(r.queue == NULL) || (r.queue == ENQUEUED) now.
Doesn't that just reduce to r.queue != this ?
Build changes are looking pretty good. Just one thing that I would like
to add. Since the executable jspawnhelper is linking in an object file
from libjava, it would be good to declare that dependency. See unpack200
for a similar situation.
$(BUILD_JSPAWNHELPER): $(LINK_JSPAWNHELPER_OBJECTS)
On 07/04/2013 07:34 PM, Joel Borggrén-Franck wrote:
Also, can you please explain to me why the update race is safe. I have done
the/some research myself but I would like to know which angles you have covered.
Well, one thing is that AnnotationType class is now effectively final, meaning that
On 04/07/2013 21:25, huizhe wang wrote:
Reverted back to the original code:
http://cr.openjdk.java.net/~joehw/jdk8/8016648/webrev/
The code split the version number and look at the 1st or 2nd element,
it thus works for both the current format and the proposed one, e.g.
for 1.7.0, it compares
A few bugs where found in CHM and fixed. I updated the webrev.
The diff can be viewed here:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/291a872e1763
Paul.
On Jul 1, 2013, at 2:44 PM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
The following is the final j.u.c patch that syncs CMH
I played with these in the lambda repo.
I needed to make the following additional change for things to compile:
--- a/src/share/classes/java/io/ExpiringCache.java Fri Jul 05 10:04:00
2013 +0200
+++ b/src/share/classes/java/io/ExpiringCache.java Fri Jul 05 10:45:10
2013 +0200
@@
Hi Again,
Sorry, the 4th revision I posted is not rebased to the current tip of
jdk8-tl so it contained some diffs that reverted some things.
Here's the correct patch:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/
Regards, Peter
On 07/05/2013 10:32 AM, Peter
Changeset: 7b756b307e12
Author:mcimadamore
Date: 2013-07-05 11:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7b756b307e12
8017618: NullPointerException in RichDiagnosticFormatter for bad input program
Summary: RDF crashes when diagnostic contains type 'void'
I'm looking at the log of the job you've run:
http://prt-web.us.oracle.com//archive/2013/07/2013-07-05-045326.ddaugher.8016838_exp/logs/linux_x64-product-c2-jdk_lang.log.FAILED.log
And it looks like both tests failed, not only the first one:
FAIL: Virtual memory usage increased by 1411072Kb
On 05.07.2013 8:35, Daniel D. Daugherty wrote:
Ivan,
The changes look fine, I can sponsor your commit, looks like your
OpenJDK user name is 'igerasim', but I need to know a little bit
more about your testing of these fixes. Did you do a test JPRT
job to run the JLI tests (or just the two tests
Nice work indeed Ivan. Good to have a reliable testcase to catch leaks
in this area.
I'd also suggest that this test goes on the ProblemList until the new
leak is sorted out for jdk8. The goal of JPRT runs is to have clean
runs. If it's on the problemList, then it's a known issue and is
Hello,
I would like propose a patch for bug #6646588
OutputStream.write() IndexOutOfBoundsException condition could be simplified
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6646588
1. Range check logic is moved from various streams/readers/writers to
IndexOutOfBoundsException.
I.e. I
Hi Peter,
Thanks for the quick update!
While I have looked over the changes to j.l.Class and the cas in AnnotationType
I don't think I'm qualified to review that. (FWIW it looked fine to me but my
jmm isn't swapped in at the moment so I won't pretend to know the interactions
between volatile
Hi all,
still looking for a review for this testfix. Looping in
hotspot-gc-...@openjdk.java.net as well.
Thanks,
Erik
On 2013-07-01, Erik Helin wrote:
Hi all,
this change updates MemoryTest.java to take the newly added Metaspace
and Compressed Class Space MemoryMXBeans into account, as
On 05/07/2013 15:08, Erik Helin wrote:
Hi all,
still looking for a review for this testfix. Looping in
hotspot-gc-...@openjdk.java.net as well.
It looks like okay to me and the comments make it clear the memory pools
that it expects.
-Alan
Hi,
Please review a patch that fixes traversal of unmodifiable map entry set where
entries could be set:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8017447-unmod-map/webrev/jdk.patch
This covers forEach, spliterator (splitting, tryAdvance, forEachRemaining),
iterator forEachRemaining,
Changeset: 028ef97797c1
Author:mullan
Date: 2013-07-05 15:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/028ef97797c1
8011547: Update XML Signature implementation to Apache Santuario 1.5.4
Reviewed-by: xuelei
!
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015317.0/webrev/
Which adds following method to Optional,
public static T OptionalT ofNullable(T value) {}
public OptionalT filter(Predicate? super T predicate) {}
publicU OptionalU map(Function? super T, ? extends U
Changeset: da63a99481da
Author:cl
Date: 2013-07-04 01:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/da63a99481da
Added tag jdk8-b97 for changeset 1bf1d6ce3042
! .hgtags
Changeset: 542b7803f038
Author:lana
Date: 2013-07-05 11:05 -0700
URL:
Changeset: 2364e94ae67b
Author:cl
Date: 2013-07-04 01:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2364e94ae67b
Added tag jdk8-b97 for changeset 6a11a81a8824
! .hgtags
Changeset: ce5a90df517b
Author:lana
Date: 2013-07-05 11:06 -0700
URL:
Changeset: c96691d84a7c
Author:katleman
Date: 2013-06-28 16:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c96691d84a7c
8019347: JDK8 b96 source with GPL header errors
Reviewed-by: iris, alanb, lancea
!
Changeset: b1fb4612a2ca
Author:cl
Date: 2013-07-04 01:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b1fb4612a2ca
Added tag jdk8-b97 for changeset dcde7f049111
! .hgtags
Changeset: 3370fb6146e4
Author:cl
Date: 2013-07-04 01:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3370fb6146e4
Added tag jdk8-b97 for changeset 469995a8e974
! .hgtags
Changeset: fc8a1a5de78e
Author:amurillo
Date: 2013-06-21 00:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fc8a1a5de78e
8017253: new hotspot build - hs25-b39
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 91acb82a8b7a
Author:dholmes
Date: 2013-06-19
Changeset: f5eb23490e6a
Author:erikj
Date: 2013-06-27 09:27 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/f5eb23490e6a
8017047: Can't use --with-java-devtools and --with-devkit at the same time
Reviewed-by: tbell
! common/autoconf/basics.m4
!
Changeset: 8339c83b16c6
Author:ehelin
Date: 2013-07-02 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8339c83b16c6
8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration
Reviewed-by: erikj, alanb
! test/ProblemList.txt
Changeset: 87cab043cb5e
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015318.0/webrev/
This webrev refactor java.util.Collector interface to allow an
intermediate type used for accumulation and then produce final result
type with a 'finished' function.
Collectors are updated to reflect the
Forgot to mention this patch depends on fix of bug 8012238[1], to enable
compile without fix, attached patch will help.
[1] http://bugs.sun.com/view_bug.do?bug_id=8012238
Cheers,
Henry
On 07/05/2013 05:11 PM, Henry Jen wrote:
Hi,
Please review the webrev at
On 7/5/2013 1:32 AM, Alan Bateman wrote:
On 04/07/2013 21:25, huizhe wang wrote:
Reverted back to the original code:
http://cr.openjdk.java.net/~joehw/jdk8/8016648/webrev/
The code split the version number and look at the 1st or 2nd element,
it thus works for both the current format and the
30 matches
Mail list logo
