hg: jdk8/tl/jdk: 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-09 Thread david . holmes
Changeset: 7bb17aa9a09f Author:dholmes Date: 2013-07-09 22:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bb17aa9a09f 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently Summary: Ensure WeakRef object can't be prematurely gc'd Reviewed-by: chegar, pl

RFR: 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces

2013-07-09 Thread Henry Jen
Hi, Please review the webrev at http://cr.openjdk.java.net/~henryjen/ccc/8020062/0/webrev/index.html This webrev does as the bug suggested, is a refactoring that moves StreamBuilder interfaces implementations into relevant Stream interfaces. The patch is created against the version after applyi

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-09 Thread Eamonn McManus
While you are at it, ... is a lot simpler than Éamonn 2013/7/8 Joe Darcy > > PS Updated webrev so that the ... structure don't have an > empty "..." portion. > > http://cr.openjdk.java.net/~darcy/8020095.1/ > > -Joe > > > On 07/08/2013 07:10 PM, Joe Darcy wrote: >> >> Hello, >> >> Ple

hg: jdk8/tl/jaxp: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

2013-07-09 Thread huizhe . wang
Changeset: 3b071f506ab9 Author:joehw Date: 2013-07-09 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/3b071f506ab9 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown Summary: jaxp 1.5 feature update Reviewed-by: alanb, dfuchs,

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0")

2013-07-09 Thread Joseph Darcy
On 7/9/2013 12:46 PM, Brian Burkhalter wrote: On Jul 9, 2013, at 12:17 PM, Joe Darcy wrote: If the specification change [...] If 2596 * {@code compareMagnitude(BigDecimal.ZERO) == 0}, then 2597 * {@code BigDecimal.ZERO} is returned. is modified to something like "If

RFR: 8015320: Pull spliterator() up from Collection to Iterable

2013-07-09 Thread Henry Jen
Hi, Please review the webrev at http://cr.openjdk.java.net/~henryjen/ccc/8015320.0/webrev/ This allows turning an Iterable into a stream with spliterator() methods if the implementation provides one(like many Collection implementations) rather than be forced to use less-efficient iterator(). Tw

hg: jdk8/tl/langtools: 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken

2013-07-09 Thread kumar . x . srinivasan
Changeset: aedb3bb327d5 Author:ksrini Date: 2013-07-09 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aedb3bb327d5 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken Reviewed-by: jjg ! test/tools/javap/8007907/JavapReturn

RFR (2nd): 8015318: Extend Collector with 'finish' operation

2013-07-09 Thread Henry Jen
Hi, An update from earlier request based on some feedbacks. The webrev is at http://cr.openjdk.java.net/~henryjen/ccc/8015318.1/webrev This webrev depends on fix of bug 8012238[1]. Before that bug is fixed, applies this patch[2] to add needed type information. See the summary of API changes, s

Re: RFR JDK-8017212 - File.createTempFile requires unnecessary "read" permission

2013-07-09 Thread Dan Xu
On 06/25/2013 05:25 AM, Alan Bateman wrote: On 25/06/2013 01:17, Dan Xu wrote: HiAll, The fix of JDK-8013827 added an unnecessary "read" permission requirement in File.createTempFile methods. This change is going to fix this issue. Please help review it. Thanks! webrev: http://cr.openjdk.

RFR: 8019799: api/java_util/jar/Pack200 test failed with compactX profiles. (EZ)

2013-07-09 Thread Kumar Srinivasan
Hi, We had earlier added a fail over to the java implementation, for reference: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1432a6247ac9 The first time the unpacker is called an UnsatisfiedLinkError will be thrown, but subsequent invocations in the same JDK/VM instance, a NoClassDefFoundErro

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0")

2013-07-09 Thread Brian Burkhalter
On Jul 9, 2013, at 12:17 PM, Joe Darcy wrote: > If the specification change > > [...] If > 2596 * {@code compareMagnitude(BigDecimal.ZERO) == 0}, then > 2597 * {@code BigDecimal.ZERO} is returned. > > is modified to something like "If this BigDecimal is numerically equ

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0")

2013-07-09 Thread Joe Darcy
On 07/09/2013 11:46 AM, Brian Burkhalter wrote: I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ with all suggested changes. The javadoc change (CCC request) was approved. Thanks, Brian If the specification change [...] If 2596 * {@code compareMagnitud

Re: Final patch for 8014319: Faster division of large integers

2013-07-09 Thread Brian Burkhalter
On Jul 8, 2013, at 3:28 PM, Tim Buktu wrote: > I hope everyone had a good July 4 weekend. Most definitely - thanks! > I updated the patch for 8014319 (i.e. phase 3 of the BigInteger work). > The patch still consists of three files; they can be found at > > https://gist.github.com/tbuktu/1576025

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0")

2013-07-09 Thread Brian Burkhalter
I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ with all suggested changes. The javadoc change (CCC request) was approved. Thanks, Brian

Re: RFR: JAXP 1.5 for JDK8/7u40: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

2013-07-09 Thread Lance Andersen - Oracle
Hi Joe Looks good Best Lance On Jul 8, 2013, at 9:07 PM, huizhe wang wrote: > Hi, > > I've updated webrev with improved property management, and quality backed by > 320 test cases. Thanks Daniel for the help expanding the test suite! > > Here's the webrev: > http://cr.openjdk.java.net/~joehw/

hg: jdk8/tl/jdk: 8019979: Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread sean . coffey
Changeset: 83c2976ef8ee Author:coffeys Date: 2013-07-09 16:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee 8019979: Replace CheckPackageAccess test with better one from closed repo Reviewed-by: mullan ! test/java/lang/SecurityManager/CheckPackageAccess.java

hg: jdk8/tl/jdk: 8019370: Sync j.u.c Fork/Join from 166 to tl

2013-07-09 Thread paul . sandoz
Changeset: 43134e79c0bb Author:psandoz Date: 2013-07-09 16:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43134e79c0bb 8019370: Sync j.u.c Fork/Join from 166 to tl Reviewed-by: chegar, martin Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/AbstractExecu

Re: RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread Sean Mullan
Looks good to me. --Sean On 07/09/2013 09:28 AM, Seán Coffey wrote: I'd like to move this testcase from our internal test repo and replace the current "test/java/lang/SecurityManager/CheckPackageAccess.java" testcase . It's a straightforward test to ensure that the package restrictions enforced

RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread Seán Coffey
I'd like to move this testcase from our internal test repo and replace the current "test/java/lang/SecurityManager/CheckPackageAccess.java" testcase . It's a straightforward test to ensure that the package restrictions enforced via the java.security file are those expected. The testcase should

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-09 Thread Ivan Gerasimov
Please have a chance to review an updated webrev. It now includes a change to ProblemList.txt, so both modified tests are ignored for linux-x64. Sincerely yours, Ivan Gersimov On 08.07.2013 21:27, Seán Coffey wrote: On 08/07/13 17:55, Ivan Gerasimov wrote: Thanks, Seán! I located the build

Re: hg: jdk8/tl/langtools: 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion

2013-07-09 Thread Florian Weimer
On 06/27/2013 10:58 PM, Remi Forax wrote: On 06/27/2013 08:49 PM, joe.da...@oracle.com wrote: Changeset: 065f8cb7bd89 Author:darcy Date: 2013-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/065f8cb7bd89 8019308: Add descriptions of Java SE 7 and 8 language

Re: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Helio Frota
Hi Yasu, Can you try to build class library? Yes i will try. Thanks, 2013/7/9 Yasu > Hi Helio, > > I've read your article. > Can you try to build class library? > I encountered this issue on building SCTP module. > > > Thanks, > > Yasumasa > -- Helio Frota JUG Leader - CEJUG http://ww

Re: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Andrew Haley
On 07/09/2013 12:11 PM, Yasu wrote: > Hi Erik, > > I posted email as following: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018790.html > --- > Hi, > > I tried to build JDK8 with GCC4.8 on Fedora19. > However, build process has been failed as following: > > -- > /usr/src

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-09 Thread Lance Andersen - Oracle
Looks fine Joe including Mandy's feedback Best Lance On Jul 8, 2013, at 10:10 PM, Joe Darcy wrote: > Hello, > > Please review my changes to resolve (almost all of): > >JDK-8020095 Fix doclint warnings in java.util.regex >http://cr.openjdk.java.net/~darcy/8020095.0/ > > Full text of the

RE: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Yasu
Hi Helio, I've read your article. Can you try to build class library? I encountered this issue on building SCTP module. Thanks, Yasumasa

RE: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Yasu
Hi Erik, I posted email as following: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018790.html --- Hi, I tried to build JDK8 with GCC4.8 on Fedora19. However, build process has been failed as following: -- /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDisp

Re: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Helio Frota
Hi great all, This is my first mail here, i'm Jug Leader of CEJUG and OpenJDK Adoptor. I did the build of OpenJDK with GCC 4.8.1 Please look: http://www.heliofrota.com/blog/2013/06/25/building-openjdk8-plus-gcc-4-dot-8-1-plus-manjaro-gnu-linux-x86/ And here all discussion on Adopt OpenJDK maili

hg: jdk8/tl/jdk: 8019551: Make BaseStream public

2013-07-09 Thread paul . sandoz
Changeset: 44a634c1edc4 Author:psandoz Date: 2013-07-09 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44a634c1edc4 8019551: Make BaseStream public Reviewed-by: chegar, psandoz Contributed-by: brian goetz ! src/share/classes/java/util/stream/AbstractPipeline.java ! sr

Re: RFR: 8019551: Make BaseStream public

2013-07-09 Thread Chris Hegarty
On 9 Jul 2013, at 08:37, Paul Sandoz wrote: > On Jul 9, 2013, at 12:56 AM, Henry Jen wrote: >> Hi, >> >> Please review webrev at >> >> http://cr.openjdk.java.net/~henryjen/ccc/8019551/0/webrev/ >> >> This webrev makes BaseStream interface public and has AbstractPipeline >> implements BaseStr

Re: Build error with GCC4.8 on Fedora19

2013-07-09 Thread Erik Joelsson
I would like to see a comment explaining why the option was needed. Is this a bug in gcc or has the checking just become better? /Erik On 2013-07-09 07:46, Dan Xu wrote: > Adding build-dev mailing list. > > > On 07/08/2013 09:54 PM, Yasu wrote: >> Sorry, I forgot to attach a patch: >> >> -- >

hg: jdk8/tl/jdk: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-09 Thread paul . sandoz
Changeset: 628432ee4d68 Author:henryjen Date: 2013-07-09 09:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/628432ee4d68 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Reviewed-by: mchung Contributed-by: paul.san...@oracle.com ! src/s