Re: RFR: 8019799: api/java_util/jar/Pack200 test failed with compactX profiles. (EZ)

2013-07-10 Thread David Holmes
On 10/07/2013 6:25 AM, Kumar Srinivasan wrote: Hi, We had earlier added a fail over to the java implementation, for reference: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1432a6247ac9 The first time the unpacker is called an UnsatisfiedLinkError will be thrown, but subsequent invocations in t

8016036: RMI specification needs to be updated to allow Activation on remote hosts

2013-07-10 Thread Stephen Flores
Bob, Sean, Please review this webrev http://cr.openjdk.java.net/~sflores/8016036/webrev.00/ for RFE/CCC: 8016036 RMI specification needs to be updated to allow Activation on remote hosts A DESCRIPTION OF THE PROBLEM: A compact2 (client profile) JRE includes java.rmi.activation.Activat

hg: jdk8/tl/jdk: 8020318: Fix doclint issues in java.net

2013-07-10 Thread jason . uh
Changeset: 702556f7977e Author:juh Date: 2013-07-10 18:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/702556f7977e 8020318: Fix doclint issues in java.net Reviewed-by: darcy, khazra ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/HttpURLPermissi

Re: class SplittableRandom

2013-07-10 Thread Doug Lea
On 07/10/13 16:49, Aleksey Shipilev wrote: (juggling an Occam's razor) Thanks keep it sharp; the more skepticism the better. D'oh, of course it is ludicrously faster than j.u.Random. I am not convinced it beats TLR though, given TLR is super-optimized now in JDK 8. Are you really implying yo

Re: RFR: 8017513: Support for closeable streams

2013-07-10 Thread Zhong Yu
A few things that require clarification: If we have interface A extends B, C interface B extends MayHoldCloseableResource interface C extends AutoCloseable is A considered definitely holding resource? If @HoldsResource is applied to a subtype of MayHoldCloseableResource @HoldsR

RFR: 8017513: Support for closeable streams

2013-07-10 Thread Henry Jen
Hi, Please review webrev at http://cr.openjdk.java.net/~henryjen/ccc/8017513/0/webrev/index.html This webrev improve resource release experience on Streams by eliminating CloseableStream, instead, fold close capability into Stream. A new interface, java.util.MayHoldCloseableResource, indicates a

hg: jdk8/tl/jdk: 8020308: Fix doclint issues in java.lang.management

2013-07-10 Thread joe . darcy
Changeset: 69d9fe8175a0 Author:sspitsyn Date: 2013-07-10 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d9fe8175a0 8020308: Fix doclint issues in java.lang.management Reviewed-by: darcy Contributed-by: serguei.spit...@oracle.com ! src/share/classes/java/lang/manageme

Re: class SplittableRandom

2013-07-10 Thread Aleksey Shipilev
(juggling an Occam's razor) Hi Doug, On 10.07.2013, at 23:13, Doug Lea wrote: > This post serves as a request for comment, with shorter than usual > turnaround (a couple of days) before considering a request to > integrate into OpenJDK 8. So, please take a look. I've glanced over the paper this

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

2013-07-10 Thread BILL PITTORE
On 7/3/2013 6:32 PM, Jeremy Manson wrote: I know that this is mentioned in the JEP, but does it really make sense to have -agentpath work here, rather than just -agentlib? I would think that specifying a full pathname and getting the library loaded out of the launcher would be a little surpris

hg: jdk8/tl/jdk: 2 new changesets

2013-07-10 Thread rob . mckenna
Changeset: 607fa1ff3de2 Author:bpb Date: 2013-07-09 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2 6178739: (fmt) Formatter.format("%0.4f\n", 56789.456789) generates MissingFormatWidthException Summary: Change the field width specification to require a pos

class SplittableRandom

2013-07-10 Thread Doug Lea
[Note: I'm also posting this on the concurrency-interest list.] We expect that using random numbers in parallel Stream computations will be common. (We know it is common in parallel computing in general.) But we had left support for it in an unsatisfactory state. If you want to create a stream o

Re: Build error with GCC4.8 on Fedora19

2013-07-10 Thread Omair Majid
On 07/09/2013 03:40 AM, Erik Joelsson wrote: > I would like to see a comment explaining why the option was needed. Is > this a bug in gcc or has the checking just become better? -Werror is not a great default. It means "all warnings are errors". The set of warnings that a compiler emits changes al

hg: jdk8/tl/jdk: 8020294: Fix doclint issues in java.util.Spliterator

2013-07-10 Thread joe . darcy
Changeset: 7c44ea602cc8 Author:darcy Date: 2013-07-10 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c44ea602cc8 8020294: Fix doclint issues in java.util.Spliterator Reviewed-by: psandoz ! src/share/classes/java/util/Spliterator.java

Re: Code Review Request: More tests for 7184826: (reflect) Add support for Project Lambda concepts in core reflection

2013-07-10 Thread Joel Borggren-Franck
Hi Amy, Tristan, I'm not a Reviewer kind of reviewer, but I've started to look at the code and can sponsor this. Some comments on test/java/lang/reflect/Method/invoke/DefaultStaticTest.java: As there are a lot of non-public top-level classes perhaps this test should be in it own directory. It i

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-10 Thread Seán Coffey
On 10/07/13 11:38, Ivan Gerasimov wrote: Yes, I forgot to include the most important thing - a link to webrev! Your link is correct. http://cr.openjdk.java.net/~igerasim/8016838/3/webrev/ The tests fail on linux-x64 only, linux-i586 is fine. Here's the link to the logs of the tests run by Danie

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-10 Thread Ivan Gerasimov
Yes, I forgot to include the most important thing - a link to webrev! Your link is correct. http://cr.openjdk.java.net/~igerasim/8016838/3/webrev/ The tests fail on linux-x64 only, linux-i586 is fine. Here's the link to the logs of the tests run by Daniel Daugherty: http://prt-web.us.oracle.com//

Re: RFR [8016838] java/lang/instrument/RedefineBigClass.sh needs modification

2013-07-10 Thread Seán Coffey
Ivan, I'll assume this is the latest webrev : http://cr.openjdk.java.net/~igerasim/8016838/3/webrev/ One comment - should the test be excluded for all linux variants (i.e. linux-all) ? regards, Sean. On 09/07/2013 14:09, Ivan Gera

Re: RFR: 8015320: Pull spliterator() up from Collection to Iterable

2013-07-10 Thread Paul Sandoz
On Jul 10, 2013, at 10:33 AM, Paul Sandoz wrote: > > On Jul 10, 2013, at 12:52 AM, Henry Jen wrote: > >> Hi, >> >> Please review the webrev at >> >> http://cr.openjdk.java.net/~henryjen/ccc/8015320.0/webrev/ >> >> This allows turning an Iterable into a stream with spliterator() methods >> if

Re: RFR: 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces

2013-07-10 Thread Paul Sandoz
On Jul 10, 2013, at 2:14 AM, Henry Jen wrote: > Hi, > > Please review the webrev at > > http://cr.openjdk.java.net/~henryjen/ccc/8020062/0/webrev/index.html > > This webrev does as the bug suggested, is a refactoring that moves > StreamBuilder interfaces implementations into relevant Stream i

Re: RFR: 8015320: Pull spliterator() up from Collection to Iterable

2013-07-10 Thread Paul Sandoz
On Jul 10, 2013, at 12:52 AM, Henry Jen wrote: > Hi, > > Please review the webrev at > > http://cr.openjdk.java.net/~henryjen/ccc/8015320.0/webrev/ > > This allows turning an Iterable into a stream with spliterator() methods > if the implementation provides one(like many Collection implementa

hg: jdk8/tl/jdk: 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees

2013-07-10 Thread paul . sandoz
Changeset: 882baa1e0a38 Author:psandoz Date: 2013-07-10 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/882baa1e0a38 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Reviewed-by: briangoetz Contributed-by: doug lea , paul sandoz !

hg: jdk8/tl/jdk: 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries

2013-07-10 Thread paul . sandoz
Changeset: ff5df05222d1 Author:psandoz Date: 2013-07-10 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5df05222d1 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Reviewed-by: briangoetz ! src/share/classes/java/util/Collectio

hg: jdk8/tl/jdk: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-10 Thread weijun . wang
Changeset: 780a64979c8d Author:weijun Date: 2013-07-10 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780a64979c8d 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 Reviewed-by: mullan ! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.jav