Re: Dismal performance of String.intern()

2013-08-04 Thread Steven Schlansker
On Tue, 11 Jun 2013 10:28:14 +0100 Alan Bateman wrote: > On 10/06/2013 19:06, Steven Schlansker wrote: > > Hi core-libs-dev, > > > > While doing performance profiling of my application, I discovered > > that nearly 50% of the time deserializing JSON was spent within > > String.intern(). I unders

Re: RFR: 6614237: missing codepage Cp290 at java runtime

2013-08-04 Thread Masayoshi Okutsu
Hi Sherman, IANA seems to define the following aliases for IBM290. cp290 EBCDIC-JP-kana csIBM290 The alias table should include EBCDIC-JP-kana and csIBM290 as well? Otherwise, the changes look good to me. Thanks, Masayoshi On 8/3/2013 5:53 AM, Xueming Shen wrote: Masayoshi, Would you pleas

Re: RFR JDK 8: 8022190 Fix varargs lint warnings in the JDK

2013-08-04 Thread Alan Bateman
On 04/08/2013 18:04, Joe Darcy wrote: Hello, Please review this fix for 8022190: Fix varargs lint warnings in the JDK http://cr.openjdk.java.net/~darcy/8022190.0/ Full patch below. While the @SafeVarargs annotation generally suppresses compiler warnings about methods, when the vararg

Code review request: 8021788: JarInputStream doesn't provide certificates for some file under META-INF

2013-08-04 Thread Weijun Wang
Please take a look at http://cr.openjdk.java.net/~weijun/8021788/webrev.00/ The problem is that the method treats no META-INF entry as normal. If we can be sure that MANIFEST.MF and signature-related files are always at the beginning, we can safely treat an entry normal when we have done w

RFR JDK 8: 8022190 Fix varargs lint warnings in the JDK

2013-08-04 Thread Joe Darcy
Hello, Please review this fix for 8022190: Fix varargs lint warnings in the JDK http://cr.openjdk.java.net/~darcy/8022190.0/ Full patch below. While the @SafeVarargs annotation generally suppresses compiler warnings about methods, when the varargs lint option is enabled, javac does so