Hi,
The root cause of this issue is that SPECJVM2008 uses a 3rd party parser
XOM 1.1 to convert the output to its canonical form. The XOM parser
directly references to the JDK parser implementation "SAXParser" with a
different configuration than the default JDK parser, in this case, the
DTD-o
Hi,
Please help review the proposed change to update the tz data
in JDK8 from 2013c to 2013d.
http://cr.openjdk.java.net/~sherman/8020054/webrev
http://cr.openjdk.java.net/~sherman/8020054/closed
Tests list below have been run and passed
(except java/time/tck/java/time/chrono/TCKChronology.java
Sorry I messed this up. The JNI book says GetStringUTFChars will return
NULL and post OOME but the JNI spec (latest version 6.0) does not - it
only says it will return NULL on failure.
So your previous version was the more correct. Given we just failed to
allocate C-heap I think we are on thin
Thumbs up!
Thanks,
David
On 9/08/2013 8:19 AM, Ivan Gerasimov wrote:
Thanks David!
On 09.08.2013 1:15, David Holmes wrote:
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Yes, it's a good point.
Since there may be a memory leak in the te
Looks good.
Masayoshi
On 8/9/2013 4:19 AM, Xueming Shen wrote:
Thanks Masayoshi, good catch, yes, those two aliases should be included.
Webrev has been updated according.
webrev:
http://cr.openjdk.java.net/~sherman/6614237/webrev/
-Sherman
On 08/04/2013 10:17 PM, Masayoshi Okutsu wrote:
Hi
Changeset: 758e3117899c
Author:weijun
Date: 2013-08-09 11:41 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758e3117899c
8021788: JarInputStream doesn't provide certificates for some file under
META-INF
Reviewed-by: chegar, sherman
! src/share/classes/java/util/jar/JarVerif
On 08/08/2013 16:26, Dan Xu wrote:
Hi All,
Please review a simple bug fix for JDK8021977. For the backward
compatibility, I have to remove the code that might throw out
IOExceptionin the native side. The issue has never been reported.But
it exists in a possible code path. And it is not easy t
Hi Vicente,
Looks fine; approved to go back.
Thanks,
-Joe
On 8/6/2013 6:59 AM, Vicente-Arturo Romero-Zaldivar wrote:
Hello,
Please review this patch, which updates test
jdk/test/java/lang/reflect/Method/GenericStringTest.java for it to
pass after changes introduced to generation of bridge
Changeset: 67edbf7e6b26
Author:juh
Date: 2013-08-08 17:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67edbf7e6b26
8022461: Fix lint warnings in sun.security.{provider,rsa,x509}
Reviewed-by: darcy, weijun, xuelei, mullan
! src/share/classes/sun/security/provider/DSAPublic
Hi All,
Please review a simple bug fix for JDK8021977. For the backward
compatibility, I have to remove the code that might throw out
IOExceptionin the native side. The issue has never been reported.But it
exists in a possible code path. And it is not easy to write a testcase
for this obvious
On 8/8/13 1:54 AM, Chris Hegarty wrote:
On 08/08/2013 03:11 AM, Jonathan Gibbons wrote:
On 08/07/2013 07:10 PM, Stuart Marks wrote:
I'd suggest putting a comment at the top of the test class saying that
this test *must* be run in othervm mode, to ensure that files are
closed properly. That way,
Thank you Michael!
On 09.08.2013 2:19, Michael McMahon wrote:
Ivan,
Right, it's not worth trying to do the equivalent, whatever it is, for
Windows.
The test is fine with me.
Thanks
Michael
On 08/08/13 23:15, Ivan Gerasimov wrote:
Michael,
The test uses /proc/self/stat file to detect chang
Thanks David!
On 09.08.2013 1:15, David Holmes wrote:
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Yes, it's a good point.
Since there may be a memory leak in the test, it'd better not interfere
with other tests in jtreg.
Also this:
Ivan,
Right, it's not worth trying to do the equivalent, whatever it is, for
Windows.
The test is fine with me.
Thanks
Michael
On 08/08/13 23:15, Ivan Gerasimov wrote:
Michael,
The test uses /proc/self/stat file to detect changes in virtual memory
usage.
This approach is specific for Linu
Michael,
The test uses /proc/self/stat file to detect changes in virtual memory
usage.
This approach is specific for Linux.
That's why I included the check of OS in the test.
Sincerely yours,
Ivan
On 09.08.2013 1:38, Michael McMahon wrote:
Yes, definitely "othervm" would be required for the t
Looks fine.
-Sherman
On 08/04/2013 06:28 PM, Weijun Wang wrote:
Please take a look at
http://cr.openjdk.java.net/~weijun/8021788/webrev.00/
The problem is that the method treats no META-INF entry as normal. If we can be
sure that MANIFEST.MF and signature-related files are always at the b
Main fix looks good to me.
Regression test may need some tweaking eg I think othervm will be needed.
Also this:
System.out.println("WARNING: Cannot perform memory leak detection on
this OS");
should probably just say something like "Test skipped on this OS" -
there are other tests that do
Hi All,
Windows platforms have reserved a few names for device usages, and "nul"
is one of them. And Windows API, such as _wfullpath() and
GetFullPathNameW, returns its full path with the prefix "\\.\", which
represents win32 device namespaces.
For example, "nul", whose full path name is "\\
Thanks Masayoshi, good catch, yes, those two aliases should be included.
Webrev has been updated according.
webrev:
http://cr.openjdk.java.net/~sherman/6614237/webrev/
-Sherman
On 08/04/2013 10:17 PM, Masayoshi Okutsu wrote:
Hi Sherman,
IANA seems to define the following aliases for IBM290.
Changeset: a388263a7287
Author:sherman
Date: 2013-08-08 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a388263a7287
8015666: test/tools/pack200/TimeStamp.java failing
Summary: to keep the default behavior of ZOS unchanged, if ze extra time not
explicitly set
Reviewed-b
Hello,
On 8/1/2013 5:28 AM, Jean-Baptiste Bugeaud wrote:
Hello,
As a follow-up from Joe Darcy's proposal (2013-02-06) to add
@FunctionalInterface to some interfaces matching the requirements of
FI.
I propose that this improvement is applied to all the VM Java libs.
Doing a quick search, I've
Chris, if it's not too late, I'd like to include a regtest in the fix.
Here's webrev that includes the test:
http://cr.openjdk.java.net/~igerasim/8022584/3/webrev/
The test gets past with the fixed jdk8 and fails with jdk8-b101 and jdk7
as expected.
Sincerely yours,
Ivan
On 08.08.2013 17:50,
Thank you Michael!
I'm working on the test.
Chris, if it's not too late, I would like to include a regtest into the
change.
It will be ready in a few minutes and I'll send an updated webrev.
Thanks,
Ivan
On 08.08.2013 17:51, Michael McMahon wrote:
The patch looks good to me. I guess a regre
On 2013-08-08, at 9:22, Jonathan Gibbons wrote:
> On 08/08/2013 09:13 AM, Chris Hegarty wrote:
>>
>> So we need a b07 of jtreg before we can proceed with this?
>>
>> -Chris.
>
> General question to all:
>
> How much will fall over if we call it 4.2?
Some of the build scripts and makefies us
On 08/08/2013 09:13 AM, Chris Hegarty wrote:
So we need a b07 of jtreg before we can proceed with this?
-Chris.
General question to all:
How much will fall over if we call it 4.2?
-- Jon
On 08/08/2013 01:54 AM, Chris Hegarty wrote:
On 08/08/2013 03:11 AM, Jonathan Gibbons wrote:
On 08/07/2013 07:10 PM, Stuart Marks wrote:
I'd suggest putting a comment at the top of the test class saying that
this test *must* be run in othervm mode, to ensure that files are
closed properly. That
On 08/08/2013 06:39, Ivan Gerasimov wrote:
Thanks, David
I've updated the webrev
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/.
Thanks for fixing the other GetStringUTFChars usages too. This version
looks good to me.
-Alan.
Changeset: 9a3e3bb30db3
Author:attila
Date: 2013-08-07 16:38 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a3e3bb30db3
8022509: Various Dynalink security enhancements
Reviewed-by: jlaskey, hannesw
! src/jdk/internal/dynalink/ChainedCallSite.java
! src/jdk/internal/dyna
Looks good to me. Thanks Ivan.
-Chris.
On 08/08/2013 02:33 PM, Ivan Gerasimov wrote:
Hello Chris!
Here's the update:
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/
Thanks for offering the sponsorship!
Here's the hg-export
http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memle
Thanks, David
I've updated the webrev
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/.
On 08.08.2013 9:01, David Holmes wrote:
Ivan,
On 8/08/2013 2:05 PM, Ivan Gerasimov wrote:
David, Alan,
I added checking for NULL results and throwing OOMException if
necessary.
You don't need
Hello Chris!
Here's the update:
http://cr.openjdk.java.net/~igerasim/8022584/2/webrev/
Thanks for offering the sponsorship!
Here's the hg-export
http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memleak-in-NetworkInterface.patch
Sincerely yours,
Ivan
On 08.08.2013 12:43, Chris Hegarty
Changeset: b7d594716f86
Author:weijun
Date: 2013-08-08 21:13 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7d594716f86
8016594: Native Windows ccache still reads DES tickets
Reviewed-by: dsamersoff, xuelei
! src/share/classes/sun/security/krb5/Credentials.java
! src/share/
Changeset: b8610a65fbf9
Author:vromero
Date: 2013-08-08 11:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9
8019486: javac, generates erroneous LVT for a test case with lambda code
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Lamb
Hi Paul,
Shouldn't Spliterators.EmptySpliterator also be IMMUTABLE, DISTINCT and
ORDERED? Like Collections.singletonSpliterator...
Although a mutable Collection implementation or immutable with size()>1
can never be Set and List at the same time, A singleton immutable
Collection I think coul
On 08/08/2013 09:10 AM, Paul Sandoz wrote:
On Aug 7, 2013, at 4:56 PM, Martin Buchholz wrote:
Doug is also working on HashMap, with experimental version in jsr166 CVS.
I think here:
http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/dl/java/util/HashMap.java?view=co
Right.
IMHO i think
On Aug 8, 2013, at 11:59 AM, Chris Hegarty wrote:
> On 08/08/2013 10:00 AM, Paul Sandoz wrote:
>> Hi,
>>
>> The following patch updates documentation for various spliterators:
>>
>> http://cr.openjdk.java.net/~psandoz/tl/JDK-8014824-split-docs/webrev/
>>
>> Mostly this is just clarifying st
On 08/08/2013 10:00 AM, Paul Sandoz wrote:
Hi,
The following patch updates documentation for various spliterators:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8014824-split-docs/webrev/
Mostly this is just clarifying stuff that was missing, but there are a few
cases of a spec change to Coll
Looks ok to me Paul.
-Chris.
On 08/08/2013 10:03 AM, Paul Sandoz wrote:
Hi,
The following patch fixes issues with the spliterators of ConcurrentSkipListMap:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8022326-CSLM-split/webrev/
Similar changes have already been made to TreeMap, which is al
Hi,
The following patch fixes issues with the spliterators of ConcurrentSkipListMap:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8022326-CSLM-split/webrev/
Similar changes have already been made to TreeMap, which is also updated here
to keep comments in sync. The changes to CSLM were taken dir
Hi,
The following patch updates documentation for various spliterators:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8014824-split-docs/webrev/
Mostly this is just clarifying stuff that was missing, but there are a few
cases of a spec change to Collections (CCC will be created):
http://cr.o
On 08/08/2013 03:11 AM, Jonathan Gibbons wrote:
On 08/07/2013 07:10 PM, Stuart Marks wrote:
I'd suggest putting a comment at the top of the test class saying that
this test *must* be run in othervm mode, to ensure that files are
closed properly. That way, you can take out the cleanupFiles() meth
Thanks for taking this Ivan.
Can you please make the changes suggested by both David and Alan (
simply return NULL/-1/JNI_FALSE, as appropriate, if GetStringUTFChars
fails ( returns NULL ), then I will sponsor this change into jdk8 for you.
Please post an update webrev to cr.openjdk.java.net.
Hello,
are you planning backport to 7u40? I suppose that final version will have
minimal impact to code with low probability of introducing regression.
This leak is critical for my application because it is periodically scanning
network interfaces and should run 24/7.
Thank you
Martin
On Aug 7, 2013, at 4:56 PM, Martin Buchholz wrote:
> Doug is also working on HashMap, with experimental version in jsr166 CVS.
> I think here:
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/dl/java/util/HashMap.java?view=co
>
Right.
IMHO i think we should quickly commit this warni
44 matches
Mail list logo
