Re: RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

2013-08-11 Thread David Holmes
Hi Harold, On 8/08/2013 5:51 AM, harold seigel wrote: Hi, Please review this small fix for bug 8022259. This change fixes a bug in the MakeClasslist tool and updates its README.txt file. Is there something significant about the "preorder" listing that makes it preferable to the list produce

A 8021788 regression? 8022761: SQE test regression on wrongly signed indexed jar file

2013-08-11 Thread Weijun Wang
Hi Sherman SQE observes a regression in their test suite and the reason is my recent fix for 8021788 at http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758e3117899c The jar file mentioned contains 66 Mon Jun 04 15:42:18 CST 2007 META-INF/INDEX.LIST 323 Sat Apr 01 15:47:28 CST 2000 META-INF

hg: jdk8/tl/jdk: 8022487: DEREncodedKeyValue.supportedKeyTypes should be private

2013-08-11 Thread xuelei . fan
Changeset: ea4f4164422e Author:xuelei Date: 2013-08-11 18:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea4f4164422e 8022487: DEREncodedKeyValue.supportedKeyTypes should be private Reviewed-by: mullan ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/con

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

2013-08-11 Thread Aleksey Shipilev
On 08/11/2013 03:39 PM, Peter Levart wrote: > http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.02/ Thanks Peter, this looks good to me (not a capital Reviewer). -Aleksey.

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

2013-08-11 Thread Peter Levart
On 08/07/2013 06:42 PM, Aleksey Shipilev wrote: Hi Peter, On 08/07/2013 08:18 PM, Peter Levart wrote: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.01/ Yeah, looks familiar. The install loop is very complicated though, can we simplify it? It seems profitable to move the re