Re: RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

On 12/08/2013 11:26 PM, harold seigel wrote: Hi David and Alan, Thank you for your comments. The change to the MakeClasslist tool to use TraceClassLoadingPreorder was made prior to my changes. The following code has been in MakeClasslist.java for a long time. I was unable to determine who had

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Thanks Ivan. David On 12/08/2013 10:33 PM, Ivan Gerasimov wrote: David, Chris, I reverted back NULL-checking. Now the change consists of one line removal and a regression test. Webrev: http://cr.openjdk.java.net/~igerasim/8022584/6/webrev/ Hg export: http://cr.openjdk.java.net/~igerasim/2comm

RFR: 8019401: Collectors.collectingAndThen

Hi, Please review the webrev[1] adds an API to help compose a Collector with an additional "finish" function. Cheers, Henry [1] http://cr.openjdk.java.net/~henryjen/ccc/8019401/0/webrev/

Re: RFR 8022797 Clarify spliterator characteristics for collections containing no elements

Looks fine to me. On Aug 12 2013, at 11:25 , Alan Bateman wrote: > On 12/08/2013 16:24, Paul Sandoz wrote: >> Hi, >> >> Here is another go at characteristics reported for spliterators of empty >> collections: >> >> diff -r f8d92ce66886 src/share/classes/java/util/Collection.java >> --- a/src/s

Re: Java 8 RFR 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero

On Aug 12, 2013, at 2:08 PM, Brian Burkhalter wrote: >>> Webrev http://cr.openjdk.java.net/~bpb/8022180/ >>> >>> The update is to clear the quotient if the divisor is larger than the >>> dividend in divideAndRemainderBurnikelZiegler(). >>> >>> Thanks, >>> >>> Brian >> Could the quotient b

Re: Java 8 RFR 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero

On Aug 12, 2013, at 2:05 PM, Alan Bateman wrote: > On 10/08/2013 01:39, Brian Burkhalter wrote: >> Please review at your convenience: >> >> Issuehttp://bugs.sun.com/view_bug.do?bug_id=8022180 >> Webrev http://cr.openjdk.java.net/~bpb/8022180/ >> >> The update is to clear the quoti

Re: Java 8 RFR 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero

On 10/08/2013 01:39, Brian Burkhalter wrote: Please review at your convenience: Issue http://bugs.sun.com/view_bug.do?bug_id=8022180 Webrev http://cr.openjdk.java.net/~bpb/8022180/ The update is to clear the quotient if the divisor is larger than the dividend in divideAndRemainderBurnikelZi

Re: Request for review, two java.time test bugs

On 12/08/2013 19:03, roger riggs wrote: Please review test fixes related to changes of Hijrah localization data. [1] 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing [2] 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed Webrev: http://cr.ope

Re: Possible HashMap update

Hi Doug; Several minor recent cleanups and proposed cleanups in HashMap made me wonder how things are progressing on this work. Do you feel it's nearly ready to integrate into the jdk8 repos? What additional work remains? Are you tracking changes going in to the jdk8 repos? Mike On Jul 8 2013

hg: jdk8/tl/jdk: 8022753: SQLXML javadoc example typo

Changeset: cc64a05836a7 Author:lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java

hg: jdk8/tl/jdk: 8022749: Convert junit tests to testng in test/java/lang/invoke

Changeset: 7758bcf0ab6b Author:henryjen Date: 2013-08-12 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7758bcf0ab6b 8022749: Convert junit tests to testng in test/java/lang/invoke Reviewed-by: mduigou, alanb Contributed-by: Mani Sarkar ! test/java/lang/invoke/AccessC

Re: RFR 8022797 Clarify spliterator characteristics for collections containing no elements

On 12/08/2013 16:24, Paul Sandoz wrote: Hi, Here is another go at characteristics reported for spliterators of empty collections: diff -r f8d92ce66886 src/share/classes/java/util/Collection.java --- a/src/share/classes/java/util/Collection.java Mon Aug 12 13:59:01 2013 +0200 +++ b/src/s

Re: Reviewer needed for 8022753: SQLXML example typo in the SQLXML javadoc

Looks fine. Mandy On 8/12/2013 11:05 AM, Lance Andersen - Oracle wrote: Hi all, Need a reviewer for the following trivial javadoc typo. Bug is 8022753 Best Lance hg diff SQLXML.java diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java --- a/src/share/classes/java/sql/SQLXML.java

Re: Request for review, two java.time test bugs

Looks fine to me Stephen On 12 August 2013 19:03, roger riggs wrote: > Please review test fixes related to changes of Hijrah localization data. > > [1] 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing > [2] 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.j

Re: Reviewer needed for 8022753: SQLXML example typo in the SQLXML javadoc

On 12/08/2013 19:05, Lance Andersen - Oracle wrote: Hi all, Need a reviewer for the following trivial javadoc typo. Bug is 8022753 Best Lance This looks fine to me. -Alan hg diff SQLXML.java diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java --- a/src/share/classes/java/sql/SQL

Reviewer needed for 8022753: SQLXML example typo in the SQLXML javadoc

Hi all, Need a reviewer for the following trivial javadoc typo. Bug is 8022753 Best Lance hg diff SQLXML.java diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java --- a/src/share/classes/java/sql/SQLXML.javaSat Jun 29 06:12:28 2013 -0400 +++ b/src/share/classes/java/sql/SQLXML.java

Request for review, two java.time test bugs

Please review test fixes related to changes of Hijrah localization data. [1] 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing [2] 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed Webrev: http://cr.openjdk.java.net/~rriggs/webrev-JDK-8022766/

Re: RFR [6883354] File.mkdirs() method doesn't behave well when given /../

Forgot the link to the bug record http://bugs.sun.com/view_bug.do?bug_id=6883354 Sincerely, Ivan On 12.08.2013 20:02, Ivan Gerasimov wrote: Hello everybody! Would you please help review a small change to File.mkdirs() method? The current implementation of the method, when past an argument "d

hg: jdk8/tl/jdk: 8015780: java/lang/reflect/Method/GenericStringTest.java failing

Changeset: 70c8f4a4b8d6 Author:vromero Date: 2013-08-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6 8015780: java/lang/reflect/Method/GenericStringTest.java failing Reviewed-by: darcy, jfranck ! test/ProblemList.txt ! test/java/lang/reflect/Method/Gener

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

On 8/12/2013 2:10 AM, Alan Bateman wrote: On 10/08/2013 00:55, huizhe wang wrote: : It's not using a standard interface. It goes straight to the implementation, here's how it's done: class JDK15XML1_0Parser extends SAXParser { JDK15XML1_0Parser() throws org.xml.sax.SAXException

Re: RFR [8022584] Memory leak in some NetworkInterface methods

On 09/08/2013 13:18, David Holmes wrote: I agree. I'm sure when Alan suggested to check the return he didn't expect it to unravel like this :) As we know hotspot will never actually return NULL there is no urgency to add this in. Sorry about this, I wasn't aware of the issue in the JNI spec, w

hg: jdk8/tl/langtools: 2 new changesets

Changeset: f7f271bd74a2 Author:mcimadamore Date: 2013-08-12 17:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f7f271bd74a2 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods) Summary: Hiding check does not

RFR [6883354] File.mkdirs() method doesn't behave well when given /../

Hello everybody! Would you please help review a small change to File.mkdirs() method? The current implementation of the method, when past an argument "dir1/../dir2" only tries to create dir2. mkdir -p 'dir1/../dir2' command on Linux creates both dir1 and dir2. java.nio.file.Files.createDirecto

Re: RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

On 12/08/2013 14:26, harold seigel wrote: Hi David and Alan, Thank you for your comments. The change to the MakeClasslist tool to use TraceClassLoadingPreorder was made prior to my changes. The following code has been in MakeClasslist.java for a long time. I was unable to determine who had

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

On 08/12/2013 03:19 PM, Paul Sandoz wrote: >- inherited annotations. They are combined with declared annotations in a Map that is cached in the AnnotationData. If superclass is redefined, the inherited annotations are not invalidated. Unless the VM increments classRedefinedCount for the redefi

RFR 8022797 Clarify spliterator characteristics for collections containing no elements

Hi, Here is another go at characteristics reported for spliterators of empty collections: diff -r f8d92ce66886 src/share/classes/java/util/Collection.java --- a/src/share/classes/java/util/Collection.java Mon Aug 12 13:59:01 2013 +0200 +++ b/src/share/classes/java/util/Collection.java

hg: jdk8/tl/nashorn: 9 new changesets

Changeset: 14ea21d58f83 Author:jlaskey Date: 2013-08-08 11:20 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/14ea21d58f83 Merge - src/jdk/internal/dynalink/support/Backport.java Changeset: 47e2b609fe31 Author:sundar Date: 2013-08-09 20:48 +0530 URL: http:

hg: jdk8/tl/jdk: 2 new changesets

Changeset: ffacf3e7a130 Author:mullan Date: 2013-08-12 09:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffacf3e7a130 8016848: javax_security/auth/login tests fail in compact 1 and 2 profiles Summary: Change the default value of the "login.configuration.provider" security

Re: RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

Hi David and Alan, Thank you for your comments. The change to the MakeClasslist tool to use TraceClassLoadingPreorder was made prior to my changes. The following code has been in MakeClasslist.java for a long time. I was unable to determine who had made this change or why. //

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

On Aug 12, 2013, at 2:40 PM, Peter Levart wrote: > Hi Joel, > > Thanks for review. Comments inline... > > On 08/12/2013 12:54 PM, Joel Borggren-Franck wrote: >> Hi Peter, >> >> Thank you for looking in to this! >> >> On 2013-08-11, Peter Levart wrote: >>> On 08/07/2013 06:42 PM, Aleksey Ship

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Thank you Chris! On 12.08.2013 16:43, Chris Hegarty wrote: Thank you Ivan. This looks good to me. -Chris. P.S. I will give others a chance to comment. If no objections, I will push this tomorrow for you. On 12/08/2013 13:33, Ivan Gerasimov wrote: David, Chris, I reverted back NULL-checkin

Re: RFR [8022584] Memory leak in some NetworkInterface methods

David, Chris, I reverted back NULL-checking. Now the change consists of one line removal and a regression test. Webrev: http://cr.openjdk.java.net/~igerasim/8022584/6/webrev/ Hg export: http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memleak-in-NetworkInterface.patch Sincerely yours

Re: RFR [8022584] Memory leak in some NetworkInterface methods

Thank you Ivan. This looks good to me. -Chris. P.S. I will give others a chance to comment. If no objections, I will push this tomorrow for you. On 12/08/2013 13:33, Ivan Gerasimov wrote: David, Chris, I reverted back NULL-checking. Now the change consists of one line removal and a regressi

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

Hi Joel, Thanks for review. Comments inline... On 08/12/2013 12:54 PM, Joel Borggren-Franck wrote: Hi Peter, Thank you for looking in to this! On 2013-08-11, Peter Levart wrote: On 08/07/2013 06:42 PM, Aleksey Shipilev wrote: Hi Peter, On 08/07/2013 08:18 PM, Peter Levart wrote: http://cr

RFR 8022318: Document Spliterator characteristics and binding policy of java util concurrent collection impls

Hi, The following patch updates documentation for various spliterators in the j.u.concurrent package: http://cr.openjdk.java.net/~psandoz/tl/JDK-8022318-concurrent-split-docs/webrev/ This syncs from the 166 repo and the documentation is just clarifying stuff that was missing. Many thanks t

Take 2 Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

Hi, I have updated this webrev to remove documenting empty/singleton collections (that will be tackled as a separate issue): http://cr.openjdk.java.net/~psandoz/tl/JDK-8014824-split-docs/webrev/ Paul. On Aug 8, 2013, at 11:00 AM, Paul Sandoz wrote: > Hi, > > The following patch updates do

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

On 10/08/2013 17:16, Rob McKenna wrote: Thanks for the build review Erik, Hi Alan, Thanks for the review. I'm hoping this webrev has dealt with your comments. http://cr.openjdk.java.net/~robm/5049299/webrev.06/ A couple of notes: -

Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

On Aug 12, 2013, at 1:00 PM, Peter Levart wrote: >> To be clear: computation may be altered (that is the why the characteristics >> are useful) but the results should be consistent. The characteristics allow >> for "wiggle room" to optimize. >> >> This email thread promoted to me think a little

Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

On 08/12/2013 11:17 AM, Paul Sandoz wrote: On Aug 9, 2013, at 9:01 PM, Mike Duigou wrote: On Aug 9 2013, at 06:04 , Paul Sandoz wrote: Hi Peter, On Aug 8, 2013, at 12:44 PM, Peter Levart wrote: Hi Paul, Shouldn't Spliterators.EmptySpliterator also be IMMUTABLE, DISTINCT and ORDERED? Lik

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

Hi Peter, Thank you for looking in to this! On 2013-08-11, Peter Levart wrote: > > On 08/07/2013 06:42 PM, Aleksey Shipilev wrote: > >Hi Peter, > > > >On 08/07/2013 08:18 PM, Peter Levart wrote: > >>http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.01/ > >Yeah, looks familiar. Th

Re: Code review request 8022779: ProblemList.txt updates (8/2013)

On 12/08/2013 10:50, Chris Hegarty wrote: Thanks Alan, To clarify, I there are no objections, I'll push the following change along with Amy's updates for the ProblemList diff -r ce1c874903cb test/java/util/Collection/MOAT.java --- a/test/java/util/Collection/MOAT.java Fri Aug 09 17:56:3

Re: Code review request 8022779: ProblemList.txt updates (8/2013)

Thanks Alan, To clarify, I there are no objections, I'll push the following change along with Amy's updates for the ProblemList diff -r ce1c874903cb test/java/util/Collection/MOAT.java --- a/test/java/util/Collection/MOAT.java Fri Aug 09 17:56:38 2013 +0100 +++ b/test/java/util/Collecti

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

Looks good to me too. -Chris. On 12/08/2013 09:20, Paul Sandoz wrote: On Aug 11, 2013, at 8:12 PM, Aleksey Shipilev wrote: On 08/11/2013 03:39 PM, Peter Levart wrote: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.02/ Thanks Peter, this looks good to me (not a capital

Re: RFR 8014824: Document Spliterator characteristics and binding policy of java util collection impls

On Aug 9, 2013, at 9:01 PM, Mike Duigou wrote: > > On Aug 9 2013, at 06:04 , Paul Sandoz wrote: > >> Hi Peter, >> >> On Aug 8, 2013, at 12:44 PM, Peter Levart wrote: >> >>> Hi Paul, >>> >>> Shouldn't Spliterators.EmptySpliterator also be IMMUTABLE, DISTINCT and >>> ORDERED? Like Collections

Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke

On 10/08/2013 01:25, Henry Jen wrote: Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry This looks good to me (but cc'ing mlvm-dev so that John/Christian/ot

Re: Code review request 8022779: ProblemList.txt updates (8/2013)

On 12/08/2013 09:57, Chris Hegarty wrote: Thanks for doing this Amy. The changes look fine to me. I wonder if there would be any opposition to adding java/util/Collection/MOAT.java, until 8020536 can be addressed. -Chris. P.S. I can sponsor this change for you, if you need a sponsor. Amy's

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

On 10/08/2013 00:55, huizhe wang wrote: : It's not using a standard interface. It goes straight to the implementation, here's how it's done: class JDK15XML1_0Parser extends SAXParser { JDK15XML1_0Parser() throws org.xml.sax.SAXException { super(new DTDConfiguration()

Re: Code review request 8022779: ProblemList.txt updates (8/2013)

Thanks for doing this Amy. The changes look fine to me. I wonder if there would be any opposition to adding java/util/Collection/MOAT.java, until 8020536 can be addressed. -Chris. P.S. I can sponsor this change for you, if you need a sponsor. On 12/08/2013 09:36, Amy Lu wrote: ProblemList u

Re: RFR 8022259 MakeClasslist tool is buggy and its README is out of date.

On 07/08/2013 20:51, harold seigel wrote: Hi, Please review this small fix for bug 8022259. This change fixes a bug in the MakeClasslist tool and updates its README.txt file. webrev: http://cr.openjdk.java.net/~hseigel/bug_8022259/ bug:

Code review request 8022779: ProblemList.txt updates (8/2013)

ProblemList updates to remove three tests, the related issues have been fixed. Please review: https://dl.dropboxusercontent.com/u/5812451/yl153753/8022779/webrev/index.html Thanks,

Re: RFR JDK-8011940 : java.lang.Class.getAnnotations() always enters synchronized method

On Aug 11, 2013, at 8:12 PM, Aleksey Shipilev wrote: > On 08/11/2013 03:39 PM, Peter Levart wrote: >> http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.02/ > > Thanks Peter, this looks good to me (not a capital Reviewer). > +1 (with no reviewer mojo). Paul.