Re: RFR 8022761: SQE test regression on wrongly signed indexed jar file

2013-08-26 Thread Weijun Wang
Ping again. On 8/19/13 9:11 PM, Weijun Wang wrote: Hi Sherman I try out jar i after signing and it puts INDEX.LIST at the very beginning of the file. Does this mean INDEX.LIST was actually an exception? Or it just jari bug? Anyway, I think I should update the fix for 8021788 and here is the

Re: Additional source to guess the local timezone ID on linux

2013-08-26 Thread Alan Bateman
Including i18n-dev on this discussion because that is where this code is maintained. On 23/08/2013 22:09, Omair Majid wrote: Hi, The algorithm that OpenJDK uses to guess the local timezone ID on Linux goes like this: 1. If TZ environment variable is set, use that 2. If /etc/timezone is

hg: jdk8/tl/jdk: 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8)

2013-08-26 Thread alan . bateman
Changeset: 0ee3b995d63b Author:alanb Date: 2013-08-26 10:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee3b995d63b 8023139: java/nio/file/WatchService/SensitivityModifier.java failing intermittently (win8) Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com !

Re: Please review fix for 8011944 : Sort fails with ArrayIndexOutOfBoundsException

2013-08-26 Thread Alan Bateman
On 23/08/2013 16:24, roger riggs wrote: Hi, I reviewed the algorithm of the test case and it seems to me that it produces the smallest number of total items to sort for a given stack depth. I ran it with other stack depths and confirmed that the implementation did not exceed the new limit.

Re: RFR [7129312] BufferedInputStream calculates negative array size with large streams and mark

2013-08-26 Thread Alan Bateman
On 25/08/2013 20:28, Ivan Gerasimov wrote: I couldn't come up with any idea on how to test the overflow without actually allocating that much memory.: I simplified the test a bit once again. Instead of invoking the same class twice, I created a designated class for the child. Here's the new

hg: jdk8/tl/jdk: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases

2013-08-26 Thread joel . franck
Changeset: 6917c114b197 Author:jfranck Date: 2013-08-26 13:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6917c114b197 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases Reviewed-by: darcy, vromero, psandoz !

Re: Java 8 RFC 7189139: BigInteger's staticRandom field can be a source of bottlenecks

2013-08-26 Thread Aleksey Shipilev
Hi Brian, On 08/24/2013 03:39 AM, Brian Burkhalter wrote: file:///Users/bpb/Work/JSL/jdk/jdk8/tl8/jdk/7189139/index.html would be appreciated. I'm puzzled over this fix. Isn't the scalability bottleneck being inherent to SecureRandom, because it piggybacks on the system entropy pool, which

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
Reminder :) -Aleksey. On 08/23/2013 02:38 PM, Aleksey Shipilev wrote: Hm, I think I still need the second reviewer. Anyone? http://cr.openjdk.java.net/~shade/8023234/webrev.01/ -Aleksey. On 08/21/2013 11:05 PM, Aleksey Shipilev wrote: Thanks Martin! I need a sponsor to push this.

RFR: 5047859 : (reflect) Class.getField can't find String[].length

2013-08-26 Thread Joel Borggren-Franck
Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec change to update the spec to match the long-standing implementation. There is also a clarification of getFields() javadoc without

Re: JDK 8 RFC 6470700: Math.random() / Math.initRNG() uses double checked locking

2013-08-26 Thread Aleksey Shipilev
On 08/22/2013 03:37 AM, Brian Burkhalter wrote: With respect to this issue http://bugs.sun.com/view_bug.do?bug_id=6470700 the code of concern from java.lang.Math is 701private static Random randomNumberGenerator; 702 703private static synchronized Random initRNG() { 704

Re: Java 8 RFC 7189139: BigInteger's staticRandom field can be a source of bottlenecks

2013-08-26 Thread Paul Sandoz
On Aug 26, 2013, at 2:19 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Hi Brian, On 08/24/2013 03:39 AM, Brian Burkhalter wrote: file:///Users/bpb/Work/JSL/jdk/jdk8/tl8/jdk/7189139/index.html would be appreciated. I'm puzzled over this fix. Isn't the scalability

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Paul Sandoz
On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i suspect you will also need a committer :-) i can do that for you. Paul.

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

2013-08-26 Thread Joel Borggren-Franck
Hi Florian, Thanks for the comments, On 2013-08-26, Florian Weimer wrote: On 08/26/2013 02:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
On 08/26/2013 05:18 PM, Paul Sandoz wrote: On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i suspect you will also need a committer :-) i

Re: RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread Aleksey Shipilev
On 08/26/2013 05:37 PM, Aleksey Shipilev wrote: On 08/26/2013 05:18 PM, Paul Sandoz wrote: On Aug 26, 2013, at 2:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com wrote: Reminder :) IIRC one reviewer should be sufficient, plus i don't feel qualified to review this at the moment. But i

hg: jdk8/tl/jdk: 8023234: StampedLock serializes readers on writer unlock

2013-08-26 Thread paul . sandoz
Changeset: 8a36fc7f494c Author:shade Date: 2013-08-26 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a36fc7f494c 8023234: StampedLock serializes readers on writer unlock Summary: Sync-up the fix from jsr166 CVS, signal more readers on writer unlock Reviewed-by:

Re: Java 8 RFR 8010430: Math.round has surprising behavior for odd values of ulp 1

2013-08-26 Thread Guy Steele
On Aug 24, 2013, at 3:02 PM, Jeff Hain jeffh...@rocketmail.com wrote: Dmitry Nadezhin wrote: Nevertheless, I send this variant now in hope that it may be useful. Great! It's much faster than what I proposed, cleaner (only integers), and according to my tests it behaves the same.

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

2013-08-26 Thread roger riggs
Hi Joel, Looks fine except for a typo in the test ArrayLength.java, line 28: Filed - Field. (Not a Reviewer). Roger On 8/26/2013 8:39 AM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859

hg: jdk8/tl/jdk: 8011944: Sort fails with ArrayIndexOutOfBoundsException

2013-08-26 Thread roger . riggs
Changeset: 07585a2483fa Author:rriggs Date: 2013-08-26 11:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07585a2483fa 8011944: Sort fails with ArrayIndexOutOfBoundsException Summary: Increase the size of pending stack and add test cases Reviewed-by: alanb !

Re: RFR: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases

2013-08-26 Thread Joel Borggrén-Franck
Joe, Paul, Vicente, Thanks for the reviews! cheers /Joel On 16 aug 2013, at 14:17, Joel Borggren-Franck joel.fra...@oracle.com wrote: Hi Please review this small fix for a type annotation reflection issue. The javadoc spec for Class.getAnnotatedSuperclass says: * If this Class

Re: RFR 8022761: SQE test regression on wrongly signed indexed jar file

2013-08-26 Thread Xueming Shen
On 08/19/2013 06:11 AM, Weijun Wang wrote: Hi Sherman I try out jar i after signing and it puts INDEX.LIST at the very beginning of the file. Does this mean INDEX.LIST was actually an exception? Or it's just a bug? Anyway, I think I should update the fix for 8021788 and here is the webrev:

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

2013-08-26 Thread Mandy Chung
Joel, The spec of the getFields and getDeclaredFields() methods both states this: This method returns an array of length 0 if the class or interface declares no fields, or if this|Class| object represents a primitive type, an array class, or void. The spec of the getDeclaredField()

hg: jdk8/tl/jdk: 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions

2013-08-26 Thread sean . coffey
Changeset: 92a66af7f834 Author:igerasim Date: 2013-08-26 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions Reviewed-by: alanb, chegar !

hg: jdk8/tl: 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles.

2013-08-26 Thread mike . duigou
Changeset: f643fee2b40f Author:mduigou Date: 2013-08-26 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f643fee2b40f 8023491: Remove target names from test/Makefile and defer to sub-repo makefiles. Reviewed-by: erikj ! common/makefiles/Main.gmk ! test/Makefile

hg: jdk8/tl/langtools: 8023701: Fix badly named test

2013-08-26 Thread jonathan . gibbons
Changeset: 60f156c653d3 Author:jjg Date: 2013-08-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60f156c653d3 8023701: Fix badly named test Reviewed-by: bpatel - test/com/sun/javadoc/testNavagation/TestNavagation.java -

Re: RFR 8023463 Update HashMap and LinkedHashMap to use bins/buckets or trees (red/black)

2013-08-26 Thread Paul Sandoz
On Aug 25, 2013, at 8:04 PM, Remi Forax fo...@univ-mlv.fr wrote: On 08/21/2013 02:25 PM, Paul Sandoz wrote: Hi, Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a webrev:

Re: 8020292: j.u.SplittableRandom

2013-08-26 Thread Mike Duigou
With most recent changes, +1. Mike On Aug 19 2013, at 04:06 , Paul Sandoz wrote: Hi, This is the patch for SplittableRandom: http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-SplittableRandom/webrev/ The algorithm remains the same as reported by Doug on the 9th August:

RFR: JDK-8023647,, abc1c .matches( (\\w)+1\\1 )) returns false

2013-08-26 Thread Xueming Shen
Hi, Please help review the proposed change for 8023647: http://cr.openjdk.java.net/~sherman/8023647/webrev It appears group index updating in situation of GroupCurly backing off is incorrect from day one (the bug is reproducible back to jdk5). The current implementation does not back off the

hg: jdk8/tl/jdk: 8020292: j.u.SplittableRandom

2013-08-26 Thread paul . sandoz
Changeset: 5ce9025c9e1a Author:psandoz Date: 2013-08-26 22:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ce9025c9e1a 8020292: j.u.SplittableRandom Reviewed-by: mduigou Contributed-by: Guy Steele guy.ste...@oracle.com, Doug Lea d...@cs.oswego.edu, Brian Goetz

Re: RFR 8023463 Update HashMap and LinkedHashMap to use bins/buckets or trees (red/black)

2013-08-26 Thread Remi Forax
On 08/26/2013 10:10 PM, Paul Sandoz wrote: On Aug 25, 2013, at 8:04 PM, Remi Forax fo...@univ-mlv.fr wrote: On 08/21/2013 02:25 PM, Paul Sandoz wrote: Hi, Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a webrev:

hg: jdk8/tl/jdk: 8023681: Fix raw type warning caused by Sink

2013-08-26 Thread henry . jen
Changeset: 35c1609d9488 Author:henryjen Date: 2013-08-09 09:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35c1609d9488 8023681: Fix raw type warning caused by Sink Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/stream/Collectors.java !

hg: jdk8/tl/langtools: 8023768: Use the unannotatedType in cyclicity checks.

2013-08-26 Thread jonathan . gibbons
Changeset: 7bf6313e1ced Author:jjg Date: 2013-08-26 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bf6313e1ced 8023768: Use the unannotatedType in cyclicity checks. Reviewed-by: jjg Contributed-by: wdi...@gmail.com !

Re: Java 8 RFR 8010430: Math.round has surprising behavior for odd values of ulp 1

2013-08-26 Thread Brian Burkhalter
On Aug 26, 2013, at 7:52 AM, Guy Steele wrote: On Aug 24, 2013, at 3:02 PM, Jeff Hain jeffh...@rocketmail.com wrote: Dmitry Nadezhin wrote: Nevertheless, I send this variant now in hope that it may be useful. Great! It's much faster than what I proposed, cleaner (only integers), and

hg: jdk8/tl/jdk: 8014135: The JVMTI specification does not conform to recent changes in JNI specification

2013-08-26 Thread david . holmes
Changeset: 9586ca82bd8b Author:bpittore Date: 2013-08-26 11:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9586ca82bd8b 8014135: The JVMTI specification does not conform to recent changes in JNI specification Summary: Added support for statically linked agents

RFR: JDK-8023765 -- Improve MaxPathLength.java testcase and reduce its test load

2013-08-26 Thread Dan Xu
Hi All, MaxPathLength.javais a troublesome testcase, and fails intermittently in the nightly test. And it also runs for a long time, especially on Windows platforms. Inorder to improve the test stability, I remove its unnecessary test iterations, and use NIOdelete method todo the clean-up to

Re: RFR: 8021591 : (s) Additional explicit null checks

2013-08-26 Thread Mike Duigou
On Aug 19 2013, at 15:35 , Martin Buchholz wrote: My feeling is that the JDK specs have been creeping in the direction of excessive pedantry and doc lawyerism. I think it's overall a benefit of Java that its documentation is more readable (at the cost of being a little less precise) than

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

2013-08-26 Thread David Holmes
Hi Joel, On 26/08/2013 10:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec change to update the spec to match the long-standing implementation.

Re: RFR: 8021591 : (s) Additional explicit null checks

2013-08-26 Thread Mike Duigou
On Aug 26 2013, at 18:37 , Mike Duigou wrote: On Aug 19 2013, at 15:35 , Martin Buchholz wrote: My feeling is that the JDK specs have been creeping in the direction of excessive pedantry and doc lawyerism. I think it's overall a benefit of Java that its documentation is more readable

Re: RFR(2nd): 8023275: Wrapping collections should override default methods

2013-08-26 Thread Mike Duigou
Looks good. On Aug 21 2013, at 16:19 , Henry Jen wrote: On 08/20/2013 02:21 AM, Paul Sandoz wrote: [resending unsigned, sorry if a dup arrives later on] On Aug 19, 2013, at 9:18 PM, Henry Jen henry@oracle.com wrote: Hi, Please review the webrev at

hg: jdk8/tl/corba: 2 new changesets

2013-08-26 Thread lana . steuck
Changeset: d411c60a8c2f Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d411c60a8c2f Added tag jdk8-b103 for changeset 49c4a777fdfd ! .hgtags Changeset: 4e38de7c767e Author:cl Date: 2013-08-22 09:09 -0700 URL:

hg: jdk8/tl/nashorn: 5 new changesets

2013-08-26 Thread lana . steuck
Changeset: afc100513451 Author:cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/afc100513451 Added tag jdk8-b103 for changeset 414203de4374 ! .hgtags Changeset: 74244f43c577 Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl: 9 new changesets

2013-08-26 Thread lana . steuck
Changeset: ceefd94ef326 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ceefd94ef326 Added tag jdk8-b103 for changeset b7e64be81c8a ! .hgtags Changeset: 4fb877dfe5c4 Author:erikj Date: 2013-08-15 17:14 +0200 URL:

hg: jdk8/tl/jaxws: 3 new changesets

2013-08-26 Thread lana . steuck
Changeset: 42211ab0ab1c Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/42211ab0ab1c Added tag jdk8-b103 for changeset 6cdc6ed98780 ! .hgtags Changeset: 88390df7ed2c Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/jaxp: 4 new changesets

2013-08-26 Thread lana . steuck
Changeset: a22fe9bd01e6 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a22fe9bd01e6 Added tag jdk8-b103 for changeset b1ceab582fc6 ! .hgtags Changeset: af28b93bfb6f Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/langtools: 6 new changesets

2013-08-26 Thread lana . steuck
Changeset: dd4a00c220c6 Author:cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dd4a00c220c6 Added tag jdk8-b103 for changeset 76cfe7c61f25 ! .hgtags Changeset: f2ee3a4e7927 Author:cl Date: 2013-08-22 09:10 -0700 URL:

hg: jdk8/tl/hotspot: 32 new changesets

2013-08-26 Thread lana . steuck
Changeset: 0bbd1c775bef Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0bbd1c775bef Added tag jdk8-b103 for changeset 6f9be7f87b96 ! .hgtags Changeset: 39127bb12d32 Author:amurillo Date: 2013-08-09 01:39 -0700 URL:

hg: jdk8/tl/jdk: 23 new changesets

2013-08-26 Thread lana . steuck
Changeset: f1d8d15bfcb5 Author:cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1d8d15bfcb5 Added tag jdk8-b103 for changeset e0f6039c0290 ! .hgtags Changeset: c982f579b67e Author:cl Date: 2013-08-22 09:10 -0700 URL: