Changeset: 8df12c315ea3
Author:bpatel
Date: 2013-09-18 22:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8df12c315ea3
8024096: some javadoc tests may contain false positive results
Reviewed-by: jjg
! test/com/sun/javadoc/lib/JavadocTester.java
! test/com/sun/javadoc
On 19/09/2013 9:59 AM, Eric McCorkle wrote:
This still needs to be reviewed.
You seem to have ignored Joe's comments regarding the change to Modifier
being incorrect.
David
On 09/16/13 14:50, Eric McCorkle wrote:
I pulled the class files into byte array constants, as a temporary
measure u
Changeset: a2a5ad0853ed
Author:bpatel
Date: 2013-09-18 17:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a2a5ad0853ed
8015249: javadoc fails to document static final fields in annotation types
Reviewed-by: jjg
+
src/share/classes/com/sun/tools/doclets/formats/html/
src/share/classes/java/lang/invoke/MethodHandles.java:
+ * methods as if they were normal methods, but the JVM verifier rejects
them.
I think you should say "JVM byte code verifier" here.
+ * (Note: JVM internal methods named {@code } not visible
to this API,
+ * even thou
Looks good.
On Sep 12, 2013, at 6:02 PM, John Rose wrote:
> Please review this change for a change to the JSR 292 implementation:
>
> http://cr.openjdk.java.net/~jrose/8001109/webrev.00/
>
> The change is mostly to javadoc and unit tests, documenting and testing some
> corner cases of JSR 292
This still needs to be reviewed.
On 09/16/13 14:50, Eric McCorkle wrote:
> I pulled the class files into byte array constants, as a temporary
> measure until a viable method for testing bad class files is developed.
>
> The webrev has been refreshed. The class files will be taken out before
> I
On 09/18/2013 04:56 AM, Florian Weimer wrote:
> On 09/18/2013 08:18 AM, Henry Jen wrote:
>> Hi,
>>
>> Please review the webrev at
>> http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
>>
>> This webrev enable writing generated classes for lambda to disk at a
>> directory specified with -Djd
Volker,
I've skimmed the client related changes - mostly based on the descriptions.
I'll look in more detail as soon as I can after JavaOne. We also have some
engineers out on vacation who might want to look at these too.
A couple of things that stood out :
"On AIX, fontconfig is not a standard
A review of the TCK tests for java.time resulted in a number of changes
including refactoring the serialization tests into subpackages to follow
JCK conventions,
discovery that a number of tests were missing for serialization, and cleanup
of the test code to utilize common test functions for tes
Looks good to me.
Cheers,
Henry
On Sep 18, 2013, at 11:27 AM, Paul Sandoz wrote:
> Hi,
>
> Please review a fix for CharSequence.codePoints:
>
> http://hg.openjdk.java.net/lambda/lambda/jdk/rev/e040a0dda7e4
>
> (That change set should apply cleanly to tl.)
>
> The incorrect spliterator cha
OK, how about this one? I'm even using lambda:-)
http://cr.openjdk.java.net/~sherman/8023113/webrev/
-Sherman
On 09/18/2013 09:42 AM, Xueming Shen wrote:
On 09/18/2013 03:31 AM, Alan Bateman wrote:
On 17/09/2013 22:55, Xueming Shen wrote:
Hi,
Please help the small update to the test case to
Hi,
Please review a fix for CharSequence.codePoints:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/e040a0dda7e4
(That change set should apply cleanly to tl.)
The incorrect spliterator characteristics were being reported when constructing
the stream. Specifically it should not report SIZED
On Sep 18, 2013, at 8:20 AM, Alan Bateman wrote:
> On 15/09/2013 17:27, Paul Sandoz wrote:
>> Hi,
>>
>> http://cr.openjdk.java.net/~psandoz/tl/JDK-8024341-pattern-splitAsStream/webrev/
>>
>> This fixes an issue with Pattern.splitAsStream reporting empty trailing
>> elements and aligns with th
On Sep 18, 2013, at 11:28 AM, Mandy Chung wrote:
>
> On 9/18/2013 9:20 AM, Nick Williams wrote:
>> On Sep 9, 2013, at 4:41 PM, Mandy Chung wrote:
>>
>>> >On 9/9/13 10:02 AM, David Chase wrote:
>>Take this lightly informed suggestion with a grain of salt, but why not,
>>for purposes o
On Sep 4, 2013, at 6:23 PM, Mandy Chung wrote:
> On 9/1/2013 1:16 AM, Nick Williams wrote:
>> Class getCallerClass(): Retrieves the class of the caller of the method
>> calling getCallerClass(). This is identical to the new
>> Reflection#getCallerClass() added in Java 7u25/8.
>>
>> Class getCa
On 15/09/2013 17:27, Paul Sandoz wrote:
Hi,
http://cr.openjdk.java.net/~psandoz/tl/JDK-8024341-pattern-splitAsStream/webrev/
This fixes an issue with Pattern.splitAsStream reporting empty trailing
elements and aligns with the functionality of Pattern.split(CharSequence input).
The matching it
On 09/18/2013 03:31 AM, Alan Bateman wrote:
On 17/09/2013 22:55, Xueming Shen wrote:
Hi,
Please help the small update to the test case tools/jar/ChangeDir.java,
which might fail if the "dedicated" test directory /tmp/a exists and the
user does not have privilege to delete/clean it up.
The prop
On 9/18/2013 9:20 AM, Nick Williams wrote:
On Sep 9, 2013, at 4:41 PM, Mandy Chung wrote:
>On 9/9/13 10:02 AM, David Chase wrote:
>>Take this lightly informed suggestion with a grain of salt, but why not, for
purposes of performance and security,
>>change the logging-specific getCallerClass
Okay. Again, sorry for my absence. This wraps up my feedback for now. I now
await responses from Mandy.
On Sep 17, 2013, at 3:53 PM, Mandy Chung wrote:
> On 9/17/13 10:32 AM, cowwoc wrote:
>> Hi,
>>
>>Has this been any new progress on this thread?
>> http://mail.openjdk.java.net/pipermail/
On Sep 9, 2013, at 4:41 PM, Mandy Chung wrote:
> On 9/9/13 10:02 AM, David Chase wrote:
>> Take this lightly informed suggestion with a grain of salt, but why not, for
>> purposes of performance and security,
>> change the logging-specific getCallerClass methods so that their "class"
>> referen
On Sep 9, 2013, at 12:57 PM, Peter Levart wrote:
>
> On 09/09/2013 07:02 PM, David Chase wrote:
>> Take this lightly informed suggestion with a grain of salt, but why not, for
>> purposes of performance and security,
>> change the logging-specific getCallerClass methods so that their "class"
>
On Sep 4, 2013, at 11:38 PM, Andrew Thompson wrote:
> Indeed if giving access to arbitrary Class is going to introduce such
> headaches as exposing sun.* and trying to support arbitrary class loaders
> then Ralph has the right point.
> It's also an example of the advantages or mirrors that Gil
On Sep 3, 2013, at 7:02 PM, Mandy Chung wrote:
> Nick,
>
> I skimmed through the changes. Congratulations for your first patch making
> changes in both hotspot and jdk code.
Thanks. And, again, apologies for my extended absence.
> In my mind, the Log4J use case accessing Class instance to ob
On 09/03/2013 12:16 PM, Peter Levart wrote:
[...]
*AND* that Reflection.getCallerClass() can only be called from within
methods annotated with @CallerSensitive.
Now for that part, the public API equivalent
(StackTraceFrame.getCallerClass() or whatever it is called) need not
be restricted to met
Alright, I'm back! I'm sorry about my extended absence. I am over a month
behind on my book (as mentioned in an earlier email) and I have been heads-down
for a couple of weeks trying to get it finished. Still not finished yet, but I
know people here are awaiting my feedback. I have several email
Changeset: b3a506a30fda
Author:ewang
Date: 2013-09-18 15:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3a506a30fda
8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java
failing intermittently [win]
Reviewed-by: chegar, alanb
! test/java/nio/chan
Changeset: 1971c2d770ae
Author:sundar
Date: 2013-09-18 13:06 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1971c2d770ae
8024972: for (LeftHandSideExpression in Expression) crashes the compiler
Reviewed-by: lagergren, hannesw
! src/jdk/nashorn/internal/codegen/CodeGenera
Changeset: 07d73060e0da
Author:weijun
Date: 2013-09-18 21:37 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07d73060e0da
8011402: Move blacklisting certificate logic from hard code to data
Reviewed-by: erikj, mullan
! make/java/security/Makefile
! makefiles/CopyFiles.gmk
! s
Changeset: ac6ec071c2b2
Author:alundblad
Date: 2013-09-18 14:39 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac6ec071c2b2
8024127: javac, Code_attribute.exception_table_langth should be
Code_attribute.exception_table_length
Summary: exception_table_langth renamed to
Changeset: e92635d6834c
Author:alanb
Date: 2013-09-18 14:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e92635d6834c
8024883: (se) SelectableChannel.register throws NPE if fd >= 64k (lnx)
Reviewed-by: alanb, coffeys
Contributed-by: nmau...@redhat.com, alan.bate...@oracle.c
On 09/18/2013 08:18 AM, Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
This webrev enable writing generated classes for lambda to disk at a
directory specified with -Djdk.internal.lambda.dumpProxyClasses.
+ File out = new File(dir
On 17/09/2013 22:55, Xueming Shen wrote:
Hi,
Please help the small update to the test case tools/jar/ChangeDir.java,
which might fail if the "dedicated" test directory /tmp/a exists and the
user does not have privilege to delete/clean it up.
The proposed change here is to use a random file name
Changeset: ee8b292ee568
Author:weijun
Date: 2013-09-18 18:22 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee8b292ee568
8012615: Realm.getRealmsList returns realms list in wrong
Reviewed-by: valeriep, xuelei
! src/share/classes/sun/security/krb5/Config.java
! src/share/clas
On 2013-09-16 17:20, Volker Simonis wrote:
Hi,
could you please review the following webrev which contains the changes
needed in the 'jdk' repository in order to build the OpenJDK on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/8024265_jdk/
All in all, it looks good!
My only nitpick is t
Looks good Peter,
cheers
/Joel
On 2013-09-15, Peter Levart wrote:
> Hi,
>
> I rebased the changes and added @bug tag to test. Here's new webrev:
>
> http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.04/
>
>
> Joel, I believe you've got the "R" mojo now...
>
>
> Regards, Pete
35 matches
Mail list logo
