Changeset: e8097e1e18a7
Author:sjiang
Date: 2013-10-10 08:49 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8097e1e18a7
8025206: Intermittent test failure:
javax/management/monitor/NullAttributeValueTest.java
Reviewed-by: dholmes, dfuchs, jbachorik
!
Changeset: e901a618dcff
Author:sjiang
Date: 2013-10-10 08:37 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e901a618dcff
8025207: Intermittent test failure:
javax/management/monitor/CounterMonitorThresholdTest.java
Reviewed-by: dfuchs, dholmes
!
Changeset: a30f6fd581b3
Author:sjiang
Date: 2013-10-10 09:01 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a30f6fd581b3
8025205: Intermittent test failure:
javax/management/remote/mandatory/connection/BrokenConnectionTest.java
Reviewed-by: dholmes, dfuchs, jbachorik
!
Hi,
JDK7 triggers a compiler error on non-final methods annotated with
@SafeVarargs even if the class itself is final. I couldn't find any
literature indicating whether this is intentional (the Javadoc states
that the method must be final but says nothing about final classes). Can
we
On 10/10/2013 3:22 AM, cowwoc wrote:
Hi,
JDK7 triggers a compiler error on non-final methods annotated with
@SafeVarargs even if the class itself is final. I couldn't find any
literature indicating whether this is intentional (the Javadoc states
that the method must be final but says
Changeset: 6aa637dde16e
Author:sla
Date: 2013-10-10 09:38 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6aa637dde16e
8025427: jstat tests fails on 32-bit platforms
Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn
! src/share/classes/sun/tools/jstat/RowClosure.java
!
Changeset: 74b4d20769fd
Author:weijun
Date: 2013-10-10 15:24 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74b4d20769fd
8026235: keytool NSS test should use 64 bit lib on Solaris
Reviewed-by: vinnie
! test/sun/security/tools/keytool/autotest.sh
Changeset: 998560cccefc
Author:allwin
Date: 2013-10-10 10:14 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998560cccefc
8014446: JT_JDK: Wrong detection of test result for test
com/sun/jdi/NoLaunchOptionTest.java
Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar
!
Changeset: 99b7bbe0474f
Author:dl
Date: 2013-10-10 09:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99b7bbe0474f
7011859: java/util/concurrent/Semaphore/RacingReleases.java failing
Reviewed-by: alanb, dholmes
!
Changeset: 254173b48dcb
Author:dholmes
Date: 2013-10-10 04:57 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/254173b48dcb
8026232: Move libnpt from profile compact1 to compact3
Reviewed-by: mchung, alanb
! makefiles/profile-includes.txt
Hi Karen,
On 10/10/2013 8:13 AM, Karen Kinnear wrote:
Please review:
webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Summary:
Reflection generates code dynamically to speed up reflection processing after
startup. The first
15
On Oct 10, 2013, at 12:13 AM, Karen Kinnear karen.kinn...@oracle.com wrote:
Please review:
webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Summary:
Reflection generates code dynamically to speed up reflection processing
Dan,
Your changes look fine to me.
While looking at this I notice that there is another potential leak. If
the malloc for temp fails, then we need to free lc ( for MAC only ), right?
-Chris.
On 10/09/2013 07:51 PM, Dan Xu wrote:
Hi All,
This fix is to solve the memory leak issue in
On 10/10/2013 12:13 AM, Karen Kinnear wrote:
Please review:
webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Summary:
Reflection generates code dynamically to speed up reflection processing after
startup. The first
15 runs of a
On Oct 9, 2013, at 8:33 PM, Joel Borggren-Franck joel.fra...@oracle.com wrote:
Hi
Please review this spec update and test for getting array classes and
instances of more dimensions than the class file can express or the VM
can handle.
Array.newInstance have a test for arrays of more
Changeset: 8294c49d23b3
Author:michaelm
Date: 2013-10-10 12:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8294c49d23b3
7076487: (sctp) SCTP API classes does not exist in JDK for Mac
Reviewed-by: alanb, chegar
! makefiles/CompileJavaClasses.gmk
! makefiles/CreateJars.gmk
On 10/10/2013 2:07 PM, John Rose wrote:
On Oct 9, 2013, at 8:32 PM, David Holmes david.hol...@oracle.com wrote:
I'm unsure if it should be is null or are null given the initial subject is
singular and latter subject is plural.
The English major in me surfaces briefly to note that any can be
Changeset: 03a68e7ca1d5
Author:lagergren
Date: 2013-10-09 17:53 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03a68e7ca1d5
8026137: Fix Issues with Binary Evaluation Order
Reviewed-by: hannesw, jlaskey
Contributed-by: marcus.lagerg...@oracle.com,
Changeset: 1e7ad879f15e
Author:alundblad
Date: 2013-10-10 08:51 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e7ad879f15e
8021237: clean up JavacAnnotatedConstruct
Summary: Refactored the static helper methods in JavacAnnoConstructs into
ordinary methods and put
Thank you Alan!
On 09.10.2013 14:06, Alan Bateman wrote:
On 09/10/2013 08:47, Ivan Gerasimov wrote:
Alan, Rob, Martin,
Would you please help review the backport? I see that you were the
reviewers for the master fix.
I need a review for the backport, since the patch couldn't get
applied
Hi,
Joe, Paul, agreed the test could be better. Improved it (without using
streams) and also added a bug id tag to the old Arrays.newInstance test.
Thanks for the comments.
Webrev here: http://cr.openjdk.java.net/~jfranck/7044282/webrev.01/
cheres
/Joel
On 2013-10-09, Joel Borggren-Franck
On Oct 10, 2013, at 2:46 PM, Joel Borggren-Franck joel.fra...@oracle.com
wrote:
Hi,
Joe, Paul, agreed the test could be better. Improved it (without using
streams) and also added a bug id tag to the old Arrays.newInstance test.
Thanks for the comments.
Webrev here:
Hi Karen,
I agree with the others, the code looks good though I like Paul's
suggestion.
Silly question perhaps, do you know if we have good test coverage on
actually reflectively invoking a Method more than 15 times?
cheers
/Joel
On 2013-10-09, Karen Kinnear wrote:
Please review:
webrev:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
https://bugs.openjdk.java.net/browse/JDK-8011638
http://cr.openjdk.java.net/~dfuchs/webrev_8011638/webrev.00/
best regards,
-- daniel
Hi,
Please, review the changes [1] needed to address the tz data update in
JDK 8 from tzdata2013d to tzdata2013g.
The brief list of changes:
1. tzdata2013g data was integrated to tzdb data files
(make/sun/javazic/tzdata/* changes) and to sun/util/calendar test data
files
Hi Mike,
This looks like a good direction. Need to look more closely.
I wonder if we even require such detailed support to throw CME?
For the cases where no function values are passed it has very limited value, we
know it is effectively useless for non-current collections being modified
Paul,
Thank you so much for the review and suggestion. I will rewrite this this way
and resend.
thanks!
Karen
On Oct 10, 2013, at 5:13 AM, Paul Sandoz wrote:
On Oct 10, 2013, at 12:13 AM, Karen Kinnear karen.kinn...@oracle.com wrote:
Please review:
webrev:
Thank you Remi.
I'm actually going to leave the assertion. We are frequently asked to expand
limits and
catching this if that time ever happens would make our lives much easier.
thanks,
Karen
On Oct 10, 2013, at 5:21 AM, Remi Forax wrote:
On 10/10/2013 12:13 AM, Karen Kinnear wrote:
Please
On 09/10/2013 19:16, Brian Burkhalter wrote:
:
I have created a simple implementation for option B:
http://cr.openjdk.java.net/~bpb/8010371/webrev.3/
I should note that the Unix Inet6 implementation was already using the call
ThrowUnknownHostExceptionWithGaiError() to generate the UHE so in
David,
Thanks for the information.
The VM side of this is 8011311 which pushed on 10/8 to jdk8 master to be part
of JDK8b111.
thanks,
Karen
On Oct 10, 2013, at 5:06 AM, David Holmes wrote:
Hi Karen,
On 10/10/2013 8:13 AM, Karen Kinnear wrote:
Please review:
webrev:
Looks fine; thanks,
-Joe
On 10/10/2013 5:56 AM, Paul Sandoz wrote:
On Oct 10, 2013, at 2:46 PM, Joel Borggren-Franck joel.fra...@oracle.com
wrote:
Hi,
Joe, Paul, agreed the test could be better. Improved it (without using
streams) and also added a bug id tag to the old Arrays.newInstance
+1
Please send a tweet to @DrDeprecator when pushed
https://twitter.com/DrDeprecator
:-)
Paul.
On Oct 10, 2013, at 3:11 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
Joel,
Thank you for the review.
Actually, that is a very good question.
We will be adding the test case for this one to our vm side
defmeth.PrivateMethodsTest, because
you have to create a classfile since private methods in interfaces are not
supported by javac, they
are for internal use for
On 10/10/2013 14:11, Daniel Fuchs wrote:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
https://bugs.openjdk.java.net/browse/JDK-8011638
http://cr.openjdk.java.net/~dfuchs/webrev_8011638/webrev.00/
This looks okay to me too. You might
Updated webrev:
webrev: http://cr.openjdk.java.net/~acorn/8026213.2/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Testing:
Specific test for private methods (attached to bug)
jtreg jdk java.lang, sun.reflect
thanks,
Karen
p.s. this should look very much like Paul's suggestion
Changeset: cab80088c671
Author:sjiang
Date: 2013-10-10 17:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cab80088c671
8025204: Intermittent test failure:
javax/management/remote/mandatory/connection/IdleTimeoutTest.java
Reviewed-by: dholmes, jbachorik
!
Changeset: f25d9d8811ca
Author:jfranck
Date: 2013-10-10 18:11 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f25d9d8811ca
7044282: (reflect) Class.forName and Array.newInstance are inconsistent
regarding multidimensional arrays
Reviewed-by: darcy, psandoz
!
Hi Daniel, Lance,
I've updated the webrev to include other resource bundles. The changes
are the same.
http://cr.openjdk.java.net/~joehw/jdk8/8003262/webrev/
Thanks,
Joe
On 10/9/2013 10:58 AM, Lance Andersen - Oracle wrote:
+1
On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
Hi,
These
Hi Joe,
I skimmed all of the changes and they look in line with the previous so +1
Best
Lance
On Oct 10, 2013, at 12:47 PM, huizhe wang wrote:
Hi Daniel, Lance,
I've updated the webrev to include other resource bundles. The changes are
the same.
Changeset: 933ba3f81a87
Author:bpatel
Date: 2013-10-10 10:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/933ba3f81a87
8025633: Fix javadoc to generate valid anchor names
Reviewed-by: jjg
!
Changeset: 6dcf94e32a3a
Author:emc
Date: 2013-10-10 13:55 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6dcf94e32a3a
8019461: Clean up javac diagnostics
7196553: Review error messages for repeating annotations
Summary: Changes to the diagnostic messages to improve
On Oct 9, 2013, at 8:32 PM, David Holmes wrote:
In the text:
* @exception NullPointerException if {@code urls} or any of its elements
* is {@code null}
I'm unsure if it should be is null or are null given the initial subject
is singular and latter subject is plural.
On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote:
Nit: In the test there are a few places where you have t on a line by itself:
65t);
but it can go on the previous line and not exceed the length of other lines
nearby. Also + should be +
I don't
Alan,
getaddrinfo could return EAI_AGAIN[1]
But recomended way is to just check return value of getaddrinfo and then
use WSA functions especially, FormatMessage[2] instead of gai_strerror.
Also we may consider rewriting this code using GetAddrInfoW sometimes in
a future to support IDN.
PS:
On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote:
Nit: In the test there are a few places where you have t on a line by
itself:
65t);
but it can go on the previous line and not exceed the length
On Oct 10, 2013, at 6:52 AM, Alan Bateman wrote:
Thanks for persevering with this, we are on the right road now.
I just looked at JDK-8010371 and the OS field is set to linux. I don't
know if this is right but as IPv6 is usually enabled by default these days
then I have to guess that the
Good catch, Chris.
Btw, according to the description, it seems the block in #ifndef
__linux__ is the workaround only for Solaris. Shall we use a more strict
macro here instead of #ifndef __linux__? Thanks!
-Dan
On 10/10/2013 02:22 AM, Chris Hegarty wrote:
Dan,
Your changes look fine to
On Oct 10, 2013, at 12:37 PM, Brian Burkhalter wrote:
Yes, I read about the thread safety. There are other ways to do this but I
wanted first to air the general idea using gai_strerror() before doing any
further work.
[…]
Thanks, I did read about FormatMessage() but forewent the usage
You could, but that part only relates to the @euro locales handling,
which is at this moment almost obsolete, let alone for MacOSX platform.
So the current code should work fine.
Naoto
On 10/10/13 1:23 PM, Dan Xu wrote:
Good catch, Chris.
Btw, according to the description, it seems the
For skip: should rename the parameters away from startInclusive to
something like toSkip.
For slice: should probably change back to slice(toSkip, maxSize) rather
than start/end offsets; in this way, slice is skip+limit.
On 10/8/2013 11:38 PM, Mike Duigou wrote:
Hello all;
Based upon
Hello,
Please review this simple patch that adds javadoc comments to
MalformedParametersException to quiet doclint warnings.
Note this patch involves no code changes.
The bug report is here:
https://bugs.openjdk.java.net/browse/JDK-8026011
The webrev is here:
Hi Eric,
Looks fine; thanks,
-Joe
On 10/10/2013 3:48 PM, Eric McCorkle wrote:
Hello,
Please review this simple patch that adds javadoc comments to
MalformedParametersException to quiet doclint warnings.
Note this patch involves no code changes.
The bug report is here:
Changeset: 4abfcbac1cb6
Author:emc
Date: 2013-10-10 18:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4abfcbac1cb6
8026011: java.lang.reflect.MalformedParametersException introduces doclint
warnings
Summary: Add javadoc comments to members of MalformedParametersException
On Oct 10, 2013, at 3:44 PM, Brian Goetz brian.go...@oracle.com wrote:
maxSize
maxFoo suggests an inclusive limit to foo. fooLimit suggests an
exclusive limit.
For slice I suggest sizeLimit (limit with similar meaning to argument in
String.split or java.io.Reader.mark).
On Oct 9, 2013, at
Thanks Lance for going through the changes!
Joe
On 10/10/2013 9:57 AM, Lance Andersen - Oracle wrote:
Hi Joe,
I skimmed all of the changes and they look in line with the previous so +1
Best
Lance
On Oct 10, 2013, at 12:47 PM, huizhe wang wrote:
Hi Daniel, Lance,
I've updated the webrev to
On 10/10/2013 6:11 AM, Daniel Fuchs wrote:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
https://bugs.openjdk.java.net/browse/JDK-8011638
http://cr.openjdk.java.net/~dfuchs/webrev_8011638/webrev.00/
As the background,
Changeset: b1b4a6dcc282
Author:emc
Date: 2013-10-10 20:12 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1b4a6dcc282
8008762: Type annotation on inner class in anonymous class show up as regular
type annotations
8015257: type annotation with TYPE_USE and FIELD
Changeset: f068d235c4f7
Author:jjg
Date: 2013-10-10 17:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7
8026294: 8025633 breaks
langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java
Reviewed-by: darcy
!
Changeset: b76629725522
Author:joehw
Date: 2013-10-10 17:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b76629725522
8003262: reverse translation required changes in xalan resource bundles
Reviewed-by: lancea, dfuchs
!
Thanks for your clarification, Naoto.
Here is the updated webrev,
http://cr.openjdk.java.net/~dxu/8025712/webrev.01/. Please help review it.
-Dan
On 10/10/2013 03:14 PM, Naoto Sato wrote:
You could, but that part only relates to the @euro locales handling,
which is at this moment almost
Ship it! :)
Thanks,
David
On 11/10/2013 5:24 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote:
Nit: In the test there are a few places where you have t on a line by itself:
65
Changeset: 17ee0d3e97fd
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/17ee0d3e97fd
Added tag jdk8-b110 for changeset 4c84c5b447b0
! .hgtags
Changeset: 2107c9baa457
Author:lana
Date: 2013-10-10 10:03 -0700
URL:
Changeset: d49a8c2173f5
Author:lana
Date: 2013-09-26 17:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d49a8c2173f5
Merge
Changeset: 75fd3486e584
Author:katleman
Date: 2013-10-02 13:26 -0700
URL:
Changeset: 85c1c94e7235
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/85c1c94e7235
Added tag jdk8-b110 for changeset 3d2b7ce93c5c
! .hgtags
Changeset: d7e478820c56
Author:cl
Date: 2013-10-10 10:08 -0700
URL:
Changeset: 5ec3c4948863
Author:ksrini
Date: 2013-09-27 16:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/5ec3c4948863
8023495: [infra] create 64-bit solaris bits with symlinks
Reviewed-by: ihse, tbell, erikj
! common/makefiles/Jprt.gmk
! common/makefiles/Main.gmk
Changeset:
Changeset: 32edc7a2c866
Author:katleman
Date: 2013-10-02 13:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/32edc7a2c866
Added tag jdk8-b110 for changeset cc682329886b
! .hgtags
Changeset: da77e343f458
Author:lana
Date: 2013-10-10 10:03 -0700
URL:
Changeset: 41541097533a
Author:lana
Date: 2013-09-26 17:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41541097533a
Merge
Changeset: af6244ba81b6
Author:katleman
Date: 2013-10-02 13:26 -0700
URL:
Hi Aleksej,
Here are my review comments.
- The copyright header of the data files shouldn't be removed.
- TimeZoneNames.java:
- Middle Europe Time, MET}},
+ MET, MET}},
I don't think the long name should be changed.
I didn't
Karen,
You can set the system property sun.reflect.inflationThreshold=N to
change the magic value from 15. That makes testing easier.
David
On 11/10/2013 12:32 AM, Karen Kinnear wrote:
Joel,
Thank you for the review.
Actually, that is a very good question.
We will be adding the test case
On 11/10/2013 2:02 AM, Karen Kinnear wrote:
Updated webrev:
webrev: http://cr.openjdk.java.net/~acorn/8026213.2/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Still looks okay to me.
David
Testing:
Specific test for private methods (attached to bug)
jtreg jdk java.lang,
70 matches
Mail list logo
