Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread Mandy Chung
On 10/14/2013 11:03 PM, David Holmes wrote: It uses testng which in turn requires compact2 because its use of sax/xml Oh that's right. I missed that is a TestNG test. thanks Mandy

hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies

2013-10-14 Thread jonathan . gibbons
Changeset: 09a414673570 Author:jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/too

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread David Holmes
Hi Mandy, On 15/10/2013 3:34 PM, Mandy Chung wrote: On 10/14/2013 10:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Looks okay with one question: [..] java/util/Collection/ListDefaults.java renamed to java/util/List/ListDefaults.java I skimmed on this tes

hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail

2013-10-14 Thread jonathan . gibbons
Changeset: 7d266a2b31b2 Author:jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread Mandy Chung
On 10/14/2013 10:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Looks okay with one question: [..] java/util/Collection/ListDefaults.java renamed to java/util/List/ListDefaults.java I skimmed on this test and it's not obvious to me - what compact2 API do

hg: jdk8/tl/jdk: 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread huizhe . wang
Changeset: 50e88f25255f Author:joehw Date: 2013-10-14 22:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50e88f25255f 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb + test/javax/xml/ja

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread David Holmes
Correction ... On 15/10/2013 3:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Trivial cleanup: Non-existent java/util/SummaryStatistics deleted from group jdk_stream Non-existent com/oracle/security deleted from jdk_security3 java/util/jar/Manifest/CreateManif

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-14 Thread Michael Fang
Hi Masayoshi, I am not sure if the changes are correct. I need to check with translation team for confirmation. There are several other similar cases. About the upper casing, it's the way Oracle translation team returns their translation. Nothing we can do about it. I think it's a way for th

hg: jdk8/tl/jaxp: 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread huizhe . wang
Changeset: eb169222d3f2 Author:joehw Date: 2013-10-14 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/eb169222d3f2 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb ! src/com/sun/org/

Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Trivial cleanup: Non-existent java/util/SummaryStatistics deleted from group jdk_stream Non-existent com/oracle/security deleted from jdk_security3 java/util/jar/Manifest/CreateManifest.java - moved from needs_jdk to needs_jre jdk/lambda/s

hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files

2013-10-14 Thread jonathan . gibbons
Changeset: b9e3b55a908c Author:jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/co

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-14 Thread Masayoshi Okutsu
Hi Aleksej and Michael, TimeZoneNames_de.java: -String DARWIN[] = new String[] {"Zentrale Normalzeit (Northern Territory)", "CST", +String DARWIN[] = new String[] {"Central Normalzeit (Northern Territory)", "CST", Is this change correct? BTW, is there any reason to change low

Re: RFR: 8026404 - Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup")

2013-10-14 Thread Mandy Chung
On 10/14/2013 11:05 AM, Daniel Fuchs wrote: Hi, Please find below a fix for: 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") In some circumstances the call to JavaAWTAccess.getAppletContext() will trigger a cal

Re: Review request for jdeps option rename to Java-style and enhancements to output dot file format

2013-10-14 Thread Mandy Chung
Alan, Thanks for the review. Here is the updated webrev per your feedback: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.01/ I have also fixed jdk/test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java due to the change of ClassFileReader.newInstance method. More co

hg: jdk8/tl/jdk: 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException

2013-10-14 Thread henry . jen
Changeset: 94d4aa2fb414 Author:henryjen Date: 2013-10-14 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94d4aa2fb414 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException Reviewed-by: chegar ! te

Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-10-14 Thread Brian Burkhalter
Ping! This proposal could use more comments, not to mention review(s). http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-September/021264.html Thanks, Brian On Oct 3, 2013, at 5:58 PM, Brian Burkhalter wrote: > I have reviewed this proposed change a couple of times in its current form

hg: jdk8/tl/jdk: 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI

2013-10-14 Thread michael . x . mcmahon
Changeset: dd0deeb04933 Author:michaelm Date: 2013-10-14 22:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd0deeb04933 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI Reviewed-by: alanb, chegar + src/share/classes/java/net/HostPortrange.jav

Re: RFR: 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException

2013-10-14 Thread Chris Hegarty
> On 14 Oct 2013, at 21:03, Henry Jen wrote: > > Hi, > > Please review a quick one line fix for the test, we simply > "pass"(ignore) the test instead of "skip" the test. > > Ignore the test is the intention. It would be ideal if we know it's > "skipped" intentionally, but currently jtreg consi

hg: jdk8/tl/langtools: 8014016: javac is too late detecting invalid annotation usage

2013-10-14 Thread jan . lahoda
Changeset: 87b5bfef7edb Author:jlahoda Date: 2013-10-14 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87b5bfef7edb 8014016: javac is too late detecting invalid annotation usage Summary: Adding new queue to Annotate for validation tasks, performing annotation val

hg: jdk8/tl/jdk: 63 new changesets

2013-10-14 Thread lana . steuck
Changeset: 8a041011b6e6 Author:jgodinez Date: 2013-09-27 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a041011b6e6 6870661: Setting a custom PrintService on a PrinterJob leads to a PrinterException Reviewed-by: prr, jgodinez Contributed-by: patr...@reini.net ! src/w

Re: RFR (JAXP) : 8015092 : SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread Alan Bateman
On 14/10/2013 19:21, huizhe wang wrote: Hi, This is a quick conformance fix to allow whitespace in xpath expression such as '. //.'. http://cr.openjdk.java.net/~joehw/jdk8/8015092/webrev/ A minor comment on the test but it might be cleaner to set XSDFILE to "idJ029.xsd" and then use new File

RFR: 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException

2013-10-14 Thread Henry Jen
Hi, Please review a quick one line fix for the test, we simply "pass"(ignore) the test instead of "skip" the test. Ignore the test is the intention. It would be ideal if we know it's "skipped" intentionally, but currently jtreg consider a skipped test with a throwable failed test for other scenar

Re: RFR (JAXP) : 8015092 : SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread huizhe wang
Thanks! On 10/14/2013 11:52 AM, Lance Andersen wrote: Looks OK On Oct 14, 2013, at 2:21 PM, huizhe wang > wrote: Hi, This is a quick conformance fix to allow whitespace in xpath expression such as '. //.'. http://cr.openjdk.java.net/~joehw/jdk8/8015092/webre

Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-14 Thread Brian Burkhalter
On Oct 14, 2013, at 1:58 AM, Alan Bateman wrote: >> 2) In Inet4AddressImpl.c and Inet6AddressImpl.c replace >> NET_ThrowUnknownHostExceptionWithGaiError with NET_ThrowByNameWithLastError >> (see net_md_util.c). >> >> […] >> >> If the "con" of option 2 is acceptable then I think that would be

hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly

2013-10-14 Thread jonathan . gibbons
Changeset: b024fe427d24 Author:jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test

hg: jdk8/tl: 3 new changesets

2013-10-14 Thread lana . steuck
Changeset: 7c0e2fd8be4d Author:lana Date: 2013-10-08 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7c0e2fd8be4d Merge Changeset: 3ece65f23ed2 Author:lana Date: 2013-10-11 00:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3ece65f23ed2 Merge Changes

RFR: 8026404 - Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup")

2013-10-14 Thread Daniel Fuchs
Adding awt-dev... The change looks okay to me but I would suggest sending to awt-dev so that the folks that maintain this area know about it. On the test then does initializing SunToolkit cause AWT to be initialized? I just wonder if this test will run headless. -Alan. Hi, Please find be

Re: RFR (JAXP) : 8015092 : SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread Lance Andersen
Looks OK On Oct 14, 2013, at 2:21 PM, huizhe wang wrote: > Hi, > > This is a quick conformance fix to allow whitespace in xpath expression such > as '. //.'. > > http://cr.openjdk.java.net/~joehw/jdk8/8015092/webrev/ > > Thanks, > Joe Lance Andersen| Principal Member of Technical Staff |

hg: jdk8/tl/jaxws: 3 new changesets

2013-10-14 Thread lana . steuck
Changeset: 1d6c13d3b8de Author:lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d6c13d3b8de Merge Changeset: 7c0a7937f6ef Author:lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7c0a7937f6ef Mer

hg: jdk8/tl/langtools: 3 new changesets

2013-10-14 Thread lana . steuck
Changeset: 4dfcf3a6902f Author:lana Date: 2013-10-08 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dfcf3a6902f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: 2f43529df42f Author:lana Date: 2013-

hg: jdk8/tl/nashorn: 3 new changesets

2013-10-14 Thread lana . steuck
Changeset: 3551855c4f40 Author:lana Date: 2013-10-08 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3551855c4f40 Merge - make/java.security.override Changeset: b48b719c5efc Author:lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/jdk

hg: jdk8/tl/jaxp: 4 new changesets

2013-10-14 Thread lana . steuck
Changeset: d69f4ac43d64 Author:lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d69f4ac43d64 Merge Changeset: cdc3577cba0b Author:lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cdc3577cba0b Merge

RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

2013-10-14 Thread Alexander Zuev
Hi, please review my fix for 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking The fix adds new option to the jar command which makes created jars normalized without the need to invoke the external program. Bug description: https://bugs.openjdk

RFR (JAXP) : 8015092 : SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression

2013-10-14 Thread huizhe wang
Hi, This is a quick conformance fix to allow whitespace in xpath expression such as '. //.'. http://cr.openjdk.java.net/~joehw/jdk8/8015092/webrev/ Thanks, Joe

Re: RFR: 8026404 - Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup")

2013-10-14 Thread Alan Bateman
On 14/10/2013 19:05, Daniel Fuchs wrote: Hi, Please find below a fix for: 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") In some circumstances the call to JavaAWTAccess.getAppletContext() will trigger a call to

RFR: 8026404 - Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup")

2013-10-14 Thread Daniel Fuchs
Hi, Please find below a fix for: 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") In some circumstances the call to JavaAWTAccess.getAppletContext() will trigger a call to ecx.threadGroup.getParent() == null The t

Please Review Separate temporal interface layer (8025720)

2013-10-14 Thread roger riggs
Hi, The concrete argument types of Chronology and ZoneId in the TemporalField.resolve method are too specific and should be generalized to allow greater access to the Temporal being resolved. They should be replaced by a single more general argument of type TemporalAccessor that can be querie

Re: RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

2013-10-14 Thread Ivan Gerasimov
Thank you Sherman! Ivan On 14.10.2013 20:40, Xueming Shen wrote: looks fine. On 10/14/2013 02:51 AM, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the intermittently failing regtest? http://bugs.sun.com/view_bug.do?bug_id=8023431 The reasons of the failures were

Re: RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

2013-10-14 Thread Xueming Shen
looks fine. On 10/14/2013 02:51 AM, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the intermittently failing regtest? http://bugs.sun.com/view_bug.do?bug_id=8023431 The reasons of the failures were non closed PipedInput/OutputStreams. Thus Read/write dead end were re

Re: Please Review: refactor of Chronology class

2013-10-14 Thread Joe Darcy
Hi Roger, Looks fine; thanks, -Joe On 10/14/2013 7:34 AM, roger riggs wrote: Hi, The java.time.chrono.Chronology should be split into an interface for Chronology and an AbstractChronology class that is the base for implementing a Chronology. A number of static methods on the java.time.chr

Re: RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

2013-10-14 Thread Ivan Gerasimov
Thank you Joe! Ivan On 14.10.2013 20:20, Joe Darcy wrote: Hi Ivan, The try with resource changes look fine. Cheers, -Joe On 10/14/2013 2:51 AM, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the intermittently failing regtest? http://bugs.sun.com/view_bug.do?bug

Re: RFR: ForkJoinTask leaks exceptions

2013-10-14 Thread Mike Duigou
Looks fine. Is it practical to create a regression test for this case? Mike On Oct 14 2013, at 08:52 , Chris Hegarty wrote: > This is a request to pull a small change to ForkJoinTask into jdk8, from the > jsr166 CVS. This was first discussed over on c-i [1] a few weeks back. > > diff -r 07723

Re: RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

2013-10-14 Thread Joe Darcy
Hi Ivan, The try with resource changes look fine. Cheers, -Joe On 10/14/2013 2:51 AM, Ivan Gerasimov wrote: Hello all! Would you please help review a fix for the intermittently failing regtest? http://bugs.sun.com/view_bug.do?bug_id=8023431 The reasons of the failures were non closed Pip

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-14 Thread Ivan Gerasimov
Thanks Paul! Yes, I like your solution better. I'll test it and send the updated webrev shortly. Sincerely yours, Ivan On 14.10.2013 15:33, Paul Sandoz wrote: On Oct 14, 2013, at 11:36 AM, Ivan Gerasimov wrote: Hi Paul, Thank you for looking at the webrev! On 14.10.2013 12:50, Paul Sando

Re: RFR: ForkJoinTask leaks exceptions

2013-10-14 Thread Paul Sandoz
Looks good, Paul. On Oct 14, 2013, at 5:52 PM, Chris Hegarty wrote: > This is a request to pull a small change to ForkJoinTask into jdk8, from the > jsr166 CVS. This was first discussed over on c-i [1] a few weeks back. > > diff -r 077237e4613f src/share/classes/java/util/concurrent/ForkJoinTa

Re: Review request for jdeps option rename to Java-style and enhancements to output dot file format

2013-10-14 Thread Paul Sandoz
On Oct 13, 2013, at 10:31 PM, Alan Bateman wrote: > On 11/10/2013 08:08, Mandy Chung wrote: >> There were some discussion of jdeps CLI to follow GNU style option >> or the traditional Java style. As there will be plans to upgrade >> the JDK tools to GNU style options, it'd be desirable to keep

RFR: ForkJoinTask leaks exceptions

2013-10-14 Thread Chris Hegarty
This is a request to pull a small change to ForkJoinTask into jdk8, from the jsr166 CVS. This was first discussed over on c-i [1] a few weeks back. diff -r 077237e4613f src/share/classes/java/util/concurrent/ForkJoinTask.java --- a/src/share/classes/java/util/concurrent/ForkJoinTask.java Mon O

Re: Review: demos for jdk8

2013-10-14 Thread Andrey Nazarov
Thank you Paul, I've fixed demo http://cr.openjdk.java.net/~anazarov/try-with-resources/webrev.01 --Thanks, Andrey. On 11.10.2013 19:04, Paul Benedict wrote: I think there may be a problem with Console::close(). Even thoug

Re: Please Review: refactor of Chronology class

2013-10-14 Thread Stephen Colebourne
Fine by me (not an official reviewer) Stephen On 14 October 2013 15:34, roger riggs wrote: > Hi, > > The java.time.chrono.Chronology should be split into an interface for > Chronology > and an AbstractChronology class that is the base for implementing a > Chronology. > > A number of static method

Re: Demo for Parallel Core Collection API

2013-10-14 Thread Paul Sandoz
Hi, Some high-level points first: - try and use static import where possible. - suggest that all streams are sequential. There is an inconsistency in the use and in some cases it is embedded in other stream usages. - "ParallelCore" is not a very descriptive name. Suggest "streams". - suggest

Please Review: refactor of Chronology class

2013-10-14 Thread roger riggs
Hi, The java.time.chrono.Chronology should be split into an interface for Chronology and an AbstractChronology class that is the base for implementing a Chronology. A number of static methods on the java.time.chrono.Chronology class are inherited by subclasses but can be incorrectly understoo

hg: jdk8/tl/jdk: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

2013-10-14 Thread stefan . karlsson
Changeset: f15a0087181e Author:stefank Date: 2013-10-14 14:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2 Reviewed-by: coleenp, sla Contributed-by: stefan.karls...@oracle.com, coleen.phillim...

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-14 Thread Paul Sandoz
On Oct 14, 2013, at 11:36 AM, Ivan Gerasimov wrote: > Hi Paul, > > Thank you for looking at the webrev! > > On 14.10.2013 12:50, Paul Sandoz wrote: >> Hi Ivan, >> >> Why do you require closeLock? is it not sufficient leave processExited as is >> and just add: >> >> public synchronized void

hg: jdk8/tl/jdk: 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost

2013-10-14 Thread chris . hegarty
Changeset: 077237e4613f Author:tyan Date: 2013-10-14 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Reviewed-by: chegar, alanb ! test/java/net/Socks/SocksProxyVersion

hg: jdk8/tl/jaxp: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

2013-10-14 Thread alan . bateman
Changeset: de8c803d4958 Author:aefimov Date: 2013-10-13 13:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/de8c803d4958 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc Reviewed-by: alanb, shade ! src/com/sun/org/apache/xpath/internal/XPathContext.java

Re: RFR: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc

2013-10-14 Thread Aleksej Efimov
Thank you, Alan. I have updated the changeset (Aleksey was added as a reviewer): http://cr.openjdk.java.net/~aefimov/8008733/8008733_hg.export Best Regards, Aleksej On 10/14/2013 12:33 AM, Alan Bateman wrote: On 13/10/2013 11:

RFR [8023431] Test java/util/zip/GZIP/GZIPInZip.java failed

2013-10-14 Thread Ivan Gerasimov
Hello all! Would you please help review a fix for the intermittently failing regtest? http://bugs.sun.com/view_bug.do?bug_id=8023431 The reasons of the failures were non closed PipedInput/OutputStreams. Thus Read/write dead end were reported. The fix is to use try-with-resource for appropriate

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-14 Thread Ivan Gerasimov
Hi Paul, Thank you for looking at the webrev! On 14.10.2013 12:50, Paul Sandoz wrote: Hi Ivan, Why do you require closeLock? is it not sufficient leave processExited as is and just add: public synchronized void close() throws IOException { super.close(); } I want to limit the impact o

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-14 Thread Aleksej Efimov
Hi, The second item is dropped - I was informed in a parallel review thread, that I can have one approval from a Reviewer and another approval[s] from members. The hg patch was updated and located here: http://cr.openjdk.java.net/~aefimov/8025255/8/8025255_jdk8.patch

Re: RFR: 8024688: j.u.Map.merge doesn't work as specified if contains key:null pair

2013-10-14 Thread Paul Sandoz
On Oct 11, 2013, at 9:46 PM, Mike Duigou wrote: > > On Oct 10 2013, at 06:37 , Paul Sandoz wrote: > >> Hi Mike, >> >> This looks like a good direction. Need to look more closely. >> >> I wonder if we even require such detailed support to throw CME? > > Some additional CME will be thrown in

Re: JDK 8 RFR 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-14 Thread Alan Bateman
On 10/10/2013 21:24, Brian Burkhalter wrote:On 10/10/2013 21:24, Brian Burkhalter wrote: : Assuming that the general idea is correct, there are a few possible alternatives for a final version for Windows. I am not concerned in this discussion about picky details including naming which can be fi

Re: RFR [8024521] (process) Async close issues with Process InputStream

2013-10-14 Thread Paul Sandoz
Hi Ivan, Why do you require closeLock? is it not sufficient leave processExited as is and just add: public synchronized void close() throws IOException { super.close(); } Plus there was already some logic checking if close was asynchronously called (see BufferedInputStream.close): 372

hg: jdk8/tl/jdk: 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources.

2013-10-14 Thread daniel . fuchs
Changeset: 9f8bfdd99129 Author:dfuchs Date: 2013-10-14 10:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f8bfdd99129 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources. Reviewed-by: alanb, psandoz, mchung ! src/s

Re: Demo for Parallel Core Collection API

2013-10-14 Thread Alan Bateman
On 14/10/2013 04:27, Tristan Yan wrote: Hi all Could you please help to review the demo code for parallel core collection API? http://cr.openjdk.java.net/~pzhang/Tristan/8023555/webrev/ A drive-by comment/question (I have not studied the code in the webrev) but are you planning to include a