Re: RFR for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

2013-11-13 Thread Alan Bateman
If you have a preliminary patch then I would suggest bringing it to serviceability-dev to discuss it. -Alan On 14/11/2013 03:17, Eric Wang wrote: Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory all

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 12 Nov 2013, at 20:29, Mandy Chung wrote: > This is a simple code deletion in sun.misc.JavaAWTAccess and its > implementation class: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ > > This patch removes the methods from sun.mi

hg: jdk8/tl/jdk: 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression

2013-11-13 Thread xueming . shen
Changeset: 1d790a56de4e Author:sherman Date: 2013-11-13 22:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d790a56de4e 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Summary: to undo the change for 6559590 Reviewed-by: darcy ! src/sh

RFR for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

2013-11-13 Thread Eric Wang
Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification is sent, so both the main thread and Checker threa

Re: Reported but unconfirmed JDK issue (Bug Id: 9002739)

2013-11-13 Thread Joseph Darcy
Hello, The incident 9002739 became bug JDK-8014852 "(zipfs) ZipFileSystemProvider: newFileSystem URI format issue," which in turn was marked as a duplicate of JDK-7156873 "(zipfs) FileSystems.newFileSystem(uri, env) fails for uri with escaped octets.": https://bugs.openjdk.java.net/brows

RFR JDK-8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression.

2013-11-13 Thread Xueming Shen
Hi, The change set for JDK-6559590 [1] triggers couple regression test failures in various areas. It appears jdk8 source code itself has dependency on the "old" behavior of split() method when the input sequence is an empty string (split-ing a zero-length input sequence always returns the resu

Re: RFR(2): 7174936: several String methods claim to always create new String

2013-11-13 Thread David Holmes
Hi Stuart, Sorry for the delay (been enroute). Only issue I have remains the subSequence change - you can't weaken the post-condition of CharSequence.subSequence without breaking subtype substitutability. Thanks, David On 12/11/2013 8:43 AM, Stuart Marks wrote: Hi all, Here's an updated ve

hg: jdk8/tl/langtools: 8025113: Convert 7 tools TryWithResources tests to jtreg format

2013-11-13 Thread sonali . goel
Changeset: f90d88913c5f Author:sogoel Date: 2013-11-13 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f90d88913c5f 8025113: Convert 7 tools TryWithResources tests to jtreg format Reviewed-by: darcy, jjg + test/tools/javac/TryWithResources/ResDeclOutsideTry.java +

Reported but unconfirmed JDK issue (Bug Id: 9002739)

2013-11-13 Thread Florian Brunner
Hi, My name is Florian Brunner. This is my first E-Mail to this list. (So far I was only involved with the swing-dev and openjfx-dev mailing lists of OpenJDK.) So I hope, I'm sending my question to the right list. Back in May I filed a JDK issue regarding the ZipFileSystemProvider (see the mes

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Bill Shannon
Xueming Shen wrote on 11/13/13 12:28: > On 11/13/2013 11:37 AM, Bill Shannon wrote: >> Xueming Shen wrote on 11/13/13 11:11: >>> On 11/13/2013 10:41 AM, Bill Shannon wrote: > The other thought is the charset API where a charset decoder can be > configured > to ignore, replace or r

Re: RFR (JAXP): 8028111 : XML readers share the same entity expansion counter

2013-11-13 Thread huizhe wang
On 11/13/2013 1:33 PM, Alan Bateman wrote: On 13/11/2013 20:02, huizhe wang wrote: Hi, The issue is that the limits applied to each processing process rather than each file processing. This applies to not only StAX as reported, but also other parsers and validators. The fix is to add reset

Re: RFR (JAXP): 8028111 : XML readers share the same entity expansion counter

2013-11-13 Thread Lance Andersen - Oracle
looks fine joe On Nov 13, 2013, at 3:02 PM, huizhe wang wrote: > Hi, > > The issue is that the limits applied to each processing process rather than > each file processing. This applies to not only StAX as reported, but also > other parsers and validators. The fix is to add reset to XMLSecurity

Re: RFR (JAXP): 8028111 : XML readers share the same entity expansion counter

2013-11-13 Thread Alan Bateman
On 13/11/2013 20:02, huizhe wang wrote: Hi, The issue is that the limits applied to each processing process rather than each file processing. This applies to not only StAX as reported, but also other parsers and validators. The fix is to add reset to XMLSecurityManager and call it upon each f

hg: jdk8/tl/jdk: 8026884: test for fix of JDK-8021398 does not have @bug tag; ...

2013-11-13 Thread eric . mccorkle
Changeset: ea91826bc2e9 Author:emc Date: 2013-11-13 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea91826bc2e9 8026884: test for fix of JDK-8021398 does not have @bug tag 8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs

Re: Review request for JDK-8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs

2013-11-13 Thread Joe Darcy
Looks good; approved, Thanks, -Joe On 11/13/2013 12:34 PM, Eric McCorkle wrote: Hello, Please review this trivial fix that adds @since documentation tags to changes added in support of parameter reflection. Webrev here: http://cr.openjdk.java.net/~emc/8028021/ Thanks, Eric

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Xueming Shen
On 11/13/2013 11:37 AM, Bill Shannon wrote: Xueming Shen wrote on 11/13/13 11:11: On 11/13/2013 10:41 AM, Bill Shannon wrote: The other thought is the charset API where a charset decoder can be configured to ignore, replace or report then malformed or unmappable input. Having support for all

Review request for JDK-8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs

2013-11-13 Thread Eric McCorkle
Hello, Please review this trivial fix that adds @since documentation tags to changes added in support of parameter reflection. Webrev here: http://cr.openjdk.java.net/~emc/8028021/ Thanks, Eric

hg: jdk8/tl/hotspot: 18 new changesets

2013-11-13 Thread lana . steuck
Changeset: 5b84039ca739 Author:amurillo Date: 2013-11-01 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b84039ca739 8027580: new hotspot build - hs25-b58 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ea79ab313e98 Author:mgerdin Date: 2013-10-30

RFR (JAXP): 8028111 : XML readers share the same entity expansion counter

2013-11-13 Thread huizhe wang
Hi, The issue is that the limits applied to each processing process rather than each file processing. This applies to not only StAX as reported, but also other parsers and validators. The fix is to add reset to XMLSecurityManager and call it upon each file processing. XSLT Transform is verifi

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Bill Shannon
Xueming Shen wrote on 11/13/13 11:11: > On 11/13/2013 10:41 AM, Bill Shannon wrote: >> >> >>> The other thought is the charset API where a charset decoder can be >>> configured >>> to ignore, replace or report then malformed or unmappable input. Having >>> support >>> for all these actions is imp

hg: jdk8/tl/jdk: 8027645: Pattern.split() with positive lookahead; ...

2013-11-13 Thread xueming . shen
Changeset: 9e37caf07ce0 Author:sherman Date: 2013-11-13 11:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e37caf07ce0 8027645: Pattern.split() with positive lookahead 6559590: Pattern.compile(".*").split("") returns incorrect result Summary: updated spec/impl for these tw

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Xueming Shen
On 11/13/2013 10:41 AM, Bill Shannon wrote: The other thought is the charset API where a charset decoder can be configured to ignore, replace or report then malformed or unmappable input. Having support for all these actions is important for charset encoding/decoding but seems way too much for

hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent

2013-11-13 Thread joe . darcy
Changeset: e6333788b117 Author:darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/sh

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Bill Shannon
Alan Bateman wrote on 11/13/13 08:51: > On 13/11/2013 04:21, Bill Shannon wrote: >> : >> There's really no error recovery possible, and certainly no program is >> going to attempt error recovery. As I said, there's only two reasonable >> things to do: 1) throw up your hands, claim the data is cor

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Bill Shannon
Xueming Shen wrote on 11/13/13 08:28: > On 11/12/13 11:44 PM, Bill Shannon wrote: >> Xueming Shen wrote on 11/12/2013 09:24 PM: >>> On 11/12/13 8:21 PM, Bill Shannon wrote: Xueming Shen wrote on 11/12/2013 04:25 PM: > On 11/12/2013 03:32 PM, Bill Shannon wrote: >> This still seems like

Re: RFR raw types lint warnings fixes for java.util.concurrent

2013-11-13 Thread Joe Darcy
On 11/13/2013 1:42 AM, Chris Hegarty wrote: The changes look fine to me. Since Martin has already brought the changes into the JSR166 CVS, Joe you can go ahead and push these changes to jdk8. Will do; I'll shortly push the fix under JDK-8028300 Fix raw type lint warnings in java.util.concurr

hg: jdk8/tl/jdk: 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh

2013-11-13 Thread erik . gahlin
Changeset: 256b3395346b Author:egahlin Date: 2013-11-13 18:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Reviewed-by: sla, sspitsyn ! test/com/sun/jdi/BreakpointWithFullGC.sh

hg: jdk8/tl/jdk: 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission

2013-11-13 Thread alan . bateman
Changeset: a493871959c2 Author:alanb Date: 2013-11-13 16:52 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a493871959c2 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Reviewed-by: mchung, martin, chegar ! src/s

hg: jdk8/tl/jdk: 8022213: Intermittent test failures in java/net/URLClassLoader

2013-11-13 Thread chris . hegarty
Changeset: 70f1bed5e7fd Author:chegar Date: 2013-11-13 16:44 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f1bed5e7fd 8022213: Intermittent test failures in java/net/URLClassLoader Reviewed-by: dxu, alanb ! test/java/net/URLClassLoader/closetest/CloseTest.java ! test/java

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Alan Bateman
On 13/11/2013 04:21, Bill Shannon wrote: : There's really no error recovery possible, and certainly no program is going to attempt error recovery. As I said, there's only two reasonable things to do: 1) throw up your hands, claim the data is corrupt, and tell the user there's nothing you can do

Re: RFR 8025003: Base64 should be less strict with padding

2013-11-13 Thread Xueming Shen
On 11/12/13 11:44 PM, Bill Shannon wrote: Xueming Shen wrote on 11/12/2013 09:24 PM: On 11/12/13 8:21 PM, Bill Shannon wrote: Xueming Shen wrote on 11/12/2013 04:25 PM: On 11/12/2013 03:32 PM, Bill Shannon wrote: This still seems like an inconsistent, and inconvenient, approach to me. You've

hg: jdk8/tl/jdk: 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread mandy . chung
Changeset: 7c55fecfae65 Author:mchung Date: 2013-11-13 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c55fecfae65 8028234: Remove unused methods in sun.misc.JavaAWTAccess Reviewed-by: art, dfuchs, lancea ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/

hg: jdk8/tl/jdk: 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary

2013-11-13 Thread staffan . larsen
Changeset: a42a416351b8 Author:ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/t

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Daniel Fuchs
Hi Mandy, looks good! -- daniel On 11/12/13 8:29 PM, Mandy Chung wrote: This is a simple code deletion in sun.misc.JavaAWTAccess and its implementation class: Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ This patch removes the methods from sun.misc.JavaAWTAccess

Re: RFR (M) 8023041: The CDS classlist needs to be updated for JDK 8

2013-11-13 Thread Alan Bateman
On 13/11/2013 14:55, harold seigel wrote: Hi, Please review this fix, submitted by Ekaterina Pavlova, to update the CDS classlist files for JDK 8. The classlist files were generated using the process described in jdk/make/tools/sharing/README.txt. In addition, a checksum was included. The

RFR (M) 8023041: The CDS classlist needs to be updated for JDK 8

2013-11-13 Thread harold seigel
Hi, Please review this fix, submitted by Ekaterina Pavlova, to update the CDS classlist files for JDK 8. The classlist files were generated using the process described in jdk/make/tools/sharing/README.txt. In addition, a checksum was included. The open webrev is at: http://cr.openjdk.java.

hg: jdk8/tl/jdk: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java

2013-11-13 Thread erik . gahlin
Changeset: ddaa9a8acaed Author:egahlin Date: 2013-11-13 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Reviewed-by: sla, jbachorik ! test/ProblemList.txt !

hg: jdk8/tl/jdk: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-13 Thread jaroslav . bachorik
Changeset: 680ef14a2cc0 Author:jbachorik Date: 2013-11-13 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/680ef14a2cc0 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Reviewed-by: dholmes, ykantser ! test/com/sun/jdi/BadHandshakeTest.java

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Artem Ananiev
Hi, Mandy, the fix looks fine to me. Other people might want to ask why these methods are no longer used and can be safely removed, so be prepared to the questions :) Thanks, Artem On 11/13/2013 2:15 AM, Mandy Chung wrote: Adding awt-dev for the review. Mandy On 11/12/2013 11:29 AM, Mand

hg: jdk8/tl/jdk: 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id

2013-11-13 Thread daniel . fuchs
Changeset: 30a3aefc4084 Author:dfuchs Date: 2013-11-13 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30a3aefc4084 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Summary: Trivial: change @bug 8023163 into @bug

hg: jdk8/tl/jdk: 8023147: Test DisabledShortRSAKeys.java intermittent failed

2013-11-13 Thread xuelei . fan
Changeset: 1158d504e39e Author:xuelei Date: 2013-11-13 01:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1158d504e39e 8023147: Test DisabledShortRSAKeys.java intermittent failed Reviewed-by: mullan ! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java

Re: RFR raw types lint warnings fixes for java.util.concurrent

2013-11-13 Thread Chris Hegarty
The changes look fine to me. Since Martin has already brought the changes into the JSR166 CVS, Joe you can go ahead and push these changes to jdk8. Thanks, -Chris. On 11/12/2013 10:52 PM, Joe Darcy wrote: Hello concurrency maestros, I submit for your consideration a simple patch to silence